more printouts for rejected TC packets #505
Loading…
x
Reference in New Issue
Block a user
No description provided.
Delete Branch "eive/fsfw:mueller/packet-check-printout"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
more printouts for rejected packetto more printouts for rejected TC packetsseems useful, one comment below
@ -29,12 +29,31 @@ PUSDistributor::TcMqMapIter PUSDistributor::selectDestination() {
tcStatus = checker.checkPacket(currentPacket);
if(tcStatus != HasReturnvaluesIF::RETURN_OK) {
#if FSFW_VERBOSE_LEVEL >= 1
std::string keyword;
As we try to not use allocating classes in the framework during runtime, I do not see a reason not to use a
char
Pointer here.We should provide a custom allocator in the future so that users can use classes like
std::vector
andstd::string
without issues in the future. Another solution would be to useetl::vector
andetl::string
which do not allocate dynamically. cmake allows good dependency management for this. But this is a topic for another issue.I'll change the code to use a preallocated array.
If you change the init value to
"unnamed error"
fromnullptr
, I'll be really happy :)Fully aggree re allocators and etl, I tend towards etl, as we already started implementing something like it in
/containers
. But you are right, this is a topic for anopther issue.done
thanks