more printouts for rejected TC packets #505

muellerr · 2021-10-11T19:50:40+02:00

muellerr commented

2021-10-11 19:50:40 +02:00

No description provided.

muellerr added 1 commit 2021-10-11 19:50:41 +02:00

more printouts for rejected packet 2180c47f4f

muellerr changed title from ~~more printouts for rejected packet~~ to more printouts for rejected TC packets

2021-10-11 19:50:51 +02:00

muellerr added this to the v3.0.0 milestone 2021-10-11 19:51:13 +02:00

muellerr requested review from mohr 2021-10-15 15:04:53 +02:00

mohr requested changes 2021-10-15 16:51:14 +02:00

mohr left a comment

seems useful, one comment below

src/fsfw/tcdistribution/PUSDistributor.cpp Outdated

						
				@@ -29,12 +29,31 @@ PUSDistributor::TcMqMapIter PUSDistributor::selectDestination() {

				        tcStatus = checker.checkPacket(currentPacket);

				        if(tcStatus != HasReturnvaluesIF::RETURN_OK) {

				#if FSFW_VERBOSE_LEVEL >= 1

				            std::string keyword;

mohr commented

2021-10-15 16:51:08 +02:00

As we try to not use allocating classes in the framework during runtime, I do not see a reason not to use a char Pointer here.

As we try to not use allocating classes in the framework during runtime, I do not see a reason not to use a `char` Pointer here.

muellerr commented

2021-10-15 18:35:14 +02:00

We should provide a custom allocator in the future so that users can use classes like std::vector and std::string without issues in the future. Another solution would be to use etl::vector and etl::string which do not allocate dynamically. cmake allows good dependency management for this. But this is a topic for another issue.

I'll change the code to use a preallocated array.

We should provide a custom allocator in the future so that users can use classes like `std::vector` and `std::string` without issues in the future. Another solution would be to use `etl::vector` and `etl::string` which do not allocate dynamically. cmake allows good dependency management for this. But this is a topic for another issue. I'll change the code to use a preallocated array.

mohr commented

2021-10-18 10:55:48 +02:00

If you change the init value to "unnamed error" from nullptr, I'll be really happy :)

Fully aggree re allocators and etl, I tend towards etl, as we already started implementing something like it in /containers. But you are right, this is a topic for anopther issue.

If you change the init value to `"unnamed error"` from `nullptr`, I'll be really happy :) Fully aggree re allocators and etl, I tend towards etl, as we already started implementing something like it in `/containers`. But you are right, this is a topic for anopther issue.

muellerr commented

2021-10-18 13:58:43 +02:00

done

mohr marked this conversation as resolved

muellerr added 1 commit 2021-10-15 18:33:47 +02:00

Merge branch 'development' into mueller/packet-check-printout 0738a0b6a4

muellerr added 2 commits 2021-10-17 22:56:34 +02:00

use char* instead 113c992f99

Merge branch 'mueller/packet-check-printout' of https://egit.irs.uni-stuttgart.de/eive/fsfw into mueller/packet-check-printout 7694decaaa

muellerr added 1 commit 2021-10-18 13:58:36 +02:00

assign correct init value afe8fe6605

mohr approved these changes 2021-10-18 14:02:06 +02:00