fsfw/fsfw
fsfw/fsfw
11
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

Add feature to open GPIO by line name #506

Merged
mohr merged 1 commits from eive/fsfw:feature/open-gpio-by-line-name into development 2021-10-15 17:19:43 +02:00
Conversation 2 Commits 1 Files Changed 3 +235 -98
muellerr commented 2021-10-11 19:59:28 +02:00
Owner
Copy Link

This feature was provided by @Jakob.Meier as part of
eive/fsfw#19 .

It adds the feature to open GPIOs supplying their line names.

This feature was provided by @Jakob.Meier as part of https://egit.irs.uni-stuttgart.de/eive/fsfw/pulls/19 . It adds the feature to open GPIOs supplying their line names.
muellerr added 1 commit 2021-10-11 19:59:29 +02:00 
This features was provided by Jakob Meier as part of
eive/fsfw#19 .

It adds the feature to open GPIOs supplying their line names.
muellerr added this to the v3.0.0 milestone 2021-10-11 20:00:12 +02:00
muellerr requested review from meierj 2021-10-15 15:04:42 +02:00
meierj approved these changes 2021-10-15 17:00:19 +02:00
mohr commented 2021-10-15 17:18:57 +02:00
Owner
Copy Link

I guess technically, changing the type of the gpio_cb_t and ctor parameter from int to gpio::Levels could be considered breaking, but as I would consider not passing the enum value but a raw integer as a bug, I concur with Robin on non-breaking.

I guess technically, changing the type of the `gpio_cb_t` and ctor parameter from `int` to `gpio::Levels` could be considered breaking, but as I would consider not passing the enum value but a raw integer as a bug, I concur with Robin on non-breaking.
mohr added the
API Change
 label 2021-10-15 17:19:09 +02:00
mohr self-assigned this 2021-10-15 17:19:13 +02:00
mohr merged commit cadf97de88 into development 2021-10-15 17:19:43 +02:00
muellerr deleted branch feature/open-gpio-by-line-name 2021-10-15 18:33:10 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
meierj
Labels
Clear labels
API Change
Changes the API, so Users need to adapted
Breaking API Change
Changes the API in a non backwards compatible way
bug
Something is not working
build
Issues related to the buildsystem, including CI
cosmetics
Small change most users won't notice
Documentation
Improvement of code documentation
duplicate
This issue or pull request already exists
feature
New feature
help wanted
Need some help
hotfix
Quick or important fix that is merged directly into master, causing a new revision
invalid
#worksforme
question
More information is needed
Refactor
Contains a refactoring of some code
Tests
Issues related to testing code
wontfix
This won't be fixed
No Label
API Change
Milestone
No items
No Milestone v3.0.0
Assignees
Clear assignees
ahinkel dwoodward gaisser hanke jenkins_buildfix lrajer meierj mohr muellerr taheran tbaumgartl
No Assignees mohr
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fsfw/fsfw#506
No description provided.
Delete Branch "eive/fsfw:feature/open-gpio-by-line-name"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?