Add feature to open GPIO by line name #506

muellerr · 2021-10-11T19:59:28+02:00

muellerr commented

2021-10-11 19:59:28 +02:00

This feature was provided by @Jakob.Meier as part of
eive/fsfw#19 .

It adds the feature to open GPIOs supplying their line names.

This feature was provided by @Jakob.Meier as part of https://egit.irs.uni-stuttgart.de/eive/fsfw/pulls/19 . It adds the feature to open GPIOs supplying their line names.

muellerr added 1 commit 2021-10-11 19:59:29 +02:00

Add feature to open GPIO by line name cae3feb5da

This features was provided by Jakob Meier as part of
eive/fsfw#19 .

It adds the feature to open GPIOs supplying their line names.

muellerr added this to the v3.0.0 milestone 2021-10-11 20:00:12 +02:00

muellerr requested review from meierj 2021-10-15 15:04:42 +02:00

meierj approved these changes 2021-10-15 17:00:19 +02:00

mohr commented

2021-10-15 17:18:57 +02:00

I guess technically, changing the type of the gpio_cb_t and ctor parameter from int to gpio::Levels could be considered breaking, but as I would consider not passing the enum value but a raw integer as a bug, I concur with Robin on non-breaking.

I guess technically, changing the type of the `gpio_cb_t` and ctor parameter from `int` to `gpio::Levels` could be considered breaking, but as I would consider not passing the enum value but a raw integer as a bug, I concur with Robin on non-breaking.

mohr added the

API Change

label 2021-10-15 17:19:09 +02:00

mohr self-assigned this 2021-10-15 17:19:13 +02:00

mohr merged commit cadf97de88 into development

2021-10-15 17:19:43 +02:00

mohr referenced this issue from a commit

2021-10-15 17:19:43 +02:00

Merge pull request 'Add feature to open GPIO by line name' (#506) from eive/fsfw:feature/open-gpio-by-line-name into development

muellerr deleted branch feature/open-gpio-by-line-name

2021-10-15 18:33:10 +02:00

Sign in to join this conversation.