WIP: CFDP Init #512

muellerr · 2021-10-20T17:05:15+02:00

muellerr commented

2021-10-20 17:05:15 +02:00

Will probably be replaced by #523

OLD:

Some of these modules were provided by @mtompert
Some architecture changes for tmtcpacket. Those were necessary to support the additional CFDP CCSDS packet type
Adds first version of CCSDS file delivery protocol (CFDP) modules. It was already possible to send dedicated CFDP packets to the OBSW with this
This will be the foundation for alle PDU implementations which will operate on static store data in place and the CFDP handler which takes care of generic tasks and which is the base class for a user CFDP entity

Will probably be replaced by #523 OLD: - Some of these modules were provided by @mtompert - Some architecture changes for `tmtcpacket`. Those were necessary to support the additional CFDP CCSDS packet type - Adds first version of CCSDS file delivery protocol (CFDP) modules. It was already possible to send dedicated CFDP packets to the OBSW with this - This will be the foundation for alle PDU implementations which will operate on static store data in place and the CFDP handler which takes care of generic tasks and which is the base class for a user CFDP entity

muellerr added 6 commits 2021-10-20 17:05:15 +02:00

Added tmtcpacket modules 9c6ff685cc

added tcdistribution modules 0da32e8d43

indentation 35aad2fcad

delete TC packet base eb00c50950

update tmtcservices module 96e56ddc64

Added CFDP module b40e250fc3

muellerr added the

Breaking API Change

label 2021-10-20 17:05:24 +02:00

muellerr added this to the v3.0.0 milestone 2021-10-20 17:05:28 +02:00

muellerr commented

2021-10-22 18:55:21 +02:00

I actually refactored the RedirectableDataPointerIF* to also take a size_t maxSize argument and a void* args. The max size argument is useful if the data setter is already performing some sanity checks and the void* argument allows some flexibility for the future. I might consider merging this feature inside this PR as well.

I actually refactored the `RedirectableDataPointerIF*` to also take a `size_t maxSize` argument and a `void* args`. The max size argument is useful if the data setter is already performing some sanity checks and the void* argument allows some flexibility for the future. I might consider merging this feature inside this PR as well.

mohr modified the milestone from v3.0.0 to v0.2.0

2021-10-25 14:12:16 +02:00

mohr modified the milestone from v0.2.0 to v3.0.0

2021-10-25 15:23:10 +02:00

muellerr added 1 commit 2021-10-25 15:40:06 +02:00

Merge branch 'development' into mueller/cfdp-init 7291438e71

muellerr commented

2021-10-26 17:33:31 +02:00

It's actually tricky to make assumptions on whether RedirectableDataPointerIF acts on read-only data or also allows changing the data. In many cases, the constness of the data pointer is cast away because the data is internally represented by a non-const struct. I would propose to either use a regular uint8_t* without const or make a new interface function for read-only data. This makes it clearer to the user on whether a particular implementation also changes the data store in place or whether it leaves the data as is (even if it cast aways the constness internally).

It's actually tricky to make assumptions on whether `RedirectableDataPointerIF` acts on read-only data or also allows changing the data. In many cases, the constness of the data pointer is cast away because the data is internally represented by a non-const struct. I would propose to either use a regular `uint8_t*` without `const` or make a new interface function for read-only data. This makes it clearer to the user on whether a particular implementation also changes the data store in place or whether it leaves the data as is (even if it cast aways the constness internally).

muellerr added 1 commit 2021-10-28 09:20:25 +02:00

Merge branch 'development' into mueller/cfdp-init 07a09d532e

muellerr added 1 commit 2021-11-08 14:57:50 +01:00

Merge branch 'development' into mueller/cfdp-init 4b25015bd0

gaisser requested review from mohr 2021-11-08 15:14:34 +01:00

gaisser reviewed 2021-11-08 15:16:38 +01:00

src/fsfw/tmtcpacket/pus/tc/TcPacketPusBase.h

						
				@ -0,0 +17,4 @@

				 * @ingroup tmtcpackets

				 */

				class TcPacketPusBase : public SpacePacketBase,

				    virtual public RedirectableDataPointerIF {