fsfw/fsfw
11
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

WIP: CFDP Init #512

Closed
muellerr wants to merge 9 commits from KSat:mueller/cfdp-init into development
pull from: KSat:mueller/cfdp-init
merge into: fsfw:development
Conversation 5 Commits 9 Files Changed 53 +1794 -1059
muellerr commented 2021-10-20 17:05:15 +02:00
Owner
Copy Link

Will probably be replaced by #523

OLD:

  • Some of these modules were provided by @mtompert
  • Some architecture changes for tmtcpacket. Those were necessary to support the additional CFDP CCSDS packet type
  • Adds first version of CCSDS file delivery protocol (CFDP) modules. It was already possible to send dedicated CFDP packets to the OBSW with this
  • This will be the foundation for alle PDU implementations which will operate on static store data in place and the CFDP handler which takes care of generic tasks and which is the base class for a user CFDP entity
Will probably be replaced by #523 OLD: - Some of these modules were provided by @mtompert - Some architecture changes for `tmtcpacket`. Those were necessary to support the additional CFDP CCSDS packet type - Adds first version of CCSDS file delivery protocol (CFDP) modules. It was already possible to send dedicated CFDP packets to the OBSW with this - This will be the foundation for alle PDU implementations which will operate on static store data in place and the CFDP handler which takes care of generic tasks and which is the base class for a user CFDP entity
muellerr added 6 commits 2021-10-20 17:05:15 +02:00
Added tmtcpacket modules 9c6ff685cc
added tcdistribution modules 0da32e8d43
indentation 35aad2fcad
delete TC packet base eb00c50950
update tmtcservices module 96e56ddc64
Added CFDP module b40e250fc3
muellerr added the Breaking API Change label 2021-10-20 17:05:24 +02:00
muellerr added this to the v3.0.0 milestone 2021-10-20 17:05:28 +02:00
muellerr commented 2021-10-22 18:55:21 +02:00
Author
Owner
Copy Link

I actually refactored the RedirectableDataPointerIF* to also take a size_t maxSize argument and a void* args. The max size argument is useful if the data setter is already performing some sanity checks and the void* argument allows some flexibility for the future. I might consider merging this feature inside this PR as well.

I actually refactored the `RedirectableDataPointerIF*` to also take a `size_t maxSize` argument and a `void* args`. The max size argument is useful if the data setter is already performing some sanity checks and the void* argument allows some flexibility for the future. I might consider merging this feature inside this PR as well.
mohr modified the milestone from v3.0.0 to v0.2.0 2021-10-25 14:12:16 +02:00
mohr modified the milestone from v0.2.0 to v3.0.0 2021-10-25 15:23:10 +02:00
muellerr added 1 commit 2021-10-25 15:40:06 +02:00
Merge branch 'development' into mueller/cfdp-init 7291438e71
muellerr commented 2021-10-26 17:33:31 +02:00
Author
Owner
Copy Link

It's actually tricky to make assumptions on whether RedirectableDataPointerIF acts on read-only data or also allows changing the data. In many cases, the constness of the data pointer is cast away because the data is internally represented by a non-const struct. I would propose to either use a regular uint8_t* without const or make a new interface function for read-only data. This makes it clearer to the user on whether a particular implementation also changes the data store in place or whether it leaves the data as is (even if it cast aways the constness internally).

It's actually tricky to make assumptions on whether `RedirectableDataPointerIF` acts on read-only data or also allows changing the data. In many cases, the constness of the data pointer is cast away because the data is internally represented by a non-const struct. I would propose to either use a regular `uint8_t*` without `const` or make a new interface function for read-only data. This makes it clearer to the user on whether a particular implementation also changes the data store in place or whether it leaves the data as is (even if it cast aways the constness internally).
muellerr added 1 commit 2021-10-28 09:20:25 +02:00
Merge branch 'development' into mueller/cfdp-init 07a09d532e
muellerr added 1 commit 2021-11-08 14:57:50 +01:00
Merge branch 'development' into mueller/cfdp-init 4b25015bd0
gaisser requested review from mohr 2021-11-08 15:14:34 +01:00
gaisser reviewed 2021-11-08 15:16:38 +01:00
src/fsfw/tmtcpacket/pus/tc/TcPacketPusBase.h
@@ -0,0 +17,4 @@
* @ingroup tmtcpackets
*/
class TcPacketPusBase : public SpacePacketBase,
virtual public RedirectableDataPointerIF {
gaisser commented 2021-11-08 15:16:38 +01:00
Owner
Copy Link

Diamond inheritance.

Diamond inheritance.
muellerr commented 2021-11-10 18:53:43 +01:00
Author
Owner
Copy Link

Might be a better idea to just merge the full CFDP packet stack once it is finished..

Might be a better idea to just merge the full CFDP packet stack once it is finished..
muellerr changed title from CFDP Init to WIP: CFDP Init 2021-11-15 14:22:11 +01:00
muellerr closed this pull request 2021-12-01 16:20:50 +01:00
muellerr commented 2021-12-01 16:21:13 +01:00
Author
Owner
Copy Link

Will be replaced by #527

Will be replaced by #527

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
mohr
gaisser
Labels
Clear labels
API Change
Changes the API, so Users need to adapted
 Breaking API Change
Changes the API in a non backwards compatible way
 bug
Something is not working
 build
Issues related to the buildsystem, including CI
 cosmetics
Small change most users won't notice
 Documentation
Improvement of code documentation
 duplicate
This issue or pull request already exists
 feature
New feature
 help wanted
Need some help
 hotfix
Quick or important fix that is merged directly into master, causing a new revision
 invalid
#worksforme
 question
More information is needed
 Refactor
Contains a refactoring of some code
 Tests
Issues related to testing code
 wontfix
This won't be fixed
No Label Breaking API Change
Milestone
No items
No Milestone v3.0.0
Assignees
Clear assignees
ahinkel dwoodward gaisser hanke jenkins_buildfix lrajer meierj mohr muellerr taheran tbaumgartl
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fsfw/fsfw#512
Delete Branch "KSat:mueller/cfdp-init"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?