fsfw/fsfw
12
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

Update SerializeAdapter #513

Merged
gaisser merged 3 commits from KSat/fsfw:mueller/serializeif-update into development 2021-11-29 14:37:40 +01:00
Conversation 4 Commits 3 Files Changed 2
+429 -268
muellerr commented 2021-10-22 11:27:37 +02:00
Owner
Copy Link
Copy Source
  • Updates SerializerAdapter to also take simple pointer and simply assign the serialized and deSerialized size
  • Added related unittests
- Updates `SerializerAdapter` to also take simple pointer and simply assign the serialized and deSerialized size - Added related unittests
muellerr requested review from mohr 2021-10-22 11:27:44 +02:00
muellerr added the feature label 2021-10-22 11:28:13 +02:00
muellerr added this to the v3.0.0 milestone 2021-10-22 11:38:04 +02:00
gaisser reviewed 2021-11-02 14:15:56 +01:00
src/fsfw/serialize/SerializeAdapter.h Outdated
@@ -84,0 +140,4 @@
* - @c RETURN_OK Successful deserialization
*/
template<typename T>
static ReturnValue_t deSerialize(T *object, const uint8_t* const buffer,
gaisser commented 2021-11-02 14:15:56 +01:00
Owner
Copy Link
Copy Source

As the Pointer can not be changed here the second const seems useless to me.

This might get rid of the const_cast

As the Pointer can not be changed here the second const seems useless to me. This might get rid of the const_cast
muellerr commented 2021-11-08 14:17:31 +01:00
Author
Owner
Copy Link
Copy Source

done

done
gaisser marked this conversation as resolved
gaisser reviewed 2021-11-02 16:45:36 +01:00
src/fsfw/serialize/SerializeAdapter.h Outdated
@@ -84,0 +127,4 @@
*
* @details
* Object Must be trivially copy-able or a child of SerializeIF.
* Buffer will be moved to the current read location. Size will be decreased by the function.
gaisser commented 2021-11-02 16:45:36 +01:00
Owner
Copy Link
Copy Source

The comment here is wrong. The size is no longer decreased.

The comment here is wrong. The size is no longer decreased.
muellerr commented 2021-11-08 14:18:00 +01:00
Author
Owner
Copy Link
Copy Source

done. buffer is not moved as well here

done. buffer is not moved as well here
gaisser marked this conversation as resolved
gaisser reviewed 2021-11-02 16:52:56 +01:00
src/fsfw/serialize/SerializeAdapter.h Outdated
@@ -84,0 +130,4 @@
* Buffer will be moved to the current read location. Size will be decreased by the function.
*
* @param[in] object: Pointer to object to deserialize
* @param[in/out] buffer: Buffer to deSerialize from
gaisser commented 2021-11-02 16:52:56 +01:00
Owner
Copy Link
Copy Source

In this function the buffer is no "out" just in.

In this function the buffer is no "out" just in.
muellerr commented 2021-11-08 14:18:14 +01:00
Author
Owner
Copy Link
Copy Source

done

done
gaisser marked this conversation as resolved
gaisser approved these changes 2021-11-08 14:50:09 +01:00
muellerr force-pushed mueller/serializeif-update from 1899d004eb to 30217aa42b 2021-11-10 18:53:00 +01:00 Compare
muellerr added 1 commit 2021-11-24 18:53:31 +01:00
Merge branch 'development' into mueller/serializeif-update 9c5e3565c6
muellerr added 1 commit 2021-11-29 14:36:28 +01:00
Merge branch 'development' into mueller/serializeif-update 9fadc9b830
gaisser merged commit bf31248a50 into development 2021-11-29 14:37:40 +01:00
gaisser deleted branch mueller/serializeif-update 2021-11-29 14:37:46 +01:00
mohr declined to review 2021-12-06 14:05:40 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
gaisser
Labels
Clear labels
API Change
Changes the API, so Users need to adapted
 Breaking API Change
Changes the API in a non backwards compatible way
 bug
Something is not working
 build
Issues related to the buildsystem, including CI
 cosmetics
Small change most users won't notice
 Documentation
Improvement of code documentation
 duplicate
This issue or pull request already exists
 feature
New feature
 help wanted
Need some help
 hotfix
Quick or important fix that is merged directly into master, causing a new revision
 invalid
#worksforme
 question
More information is needed
 Refactor
Contains a refactoring of some code
 Tests
Issues related to testing code
 wontfix
This won't be fixed
No labels feature
Milestone
No items
No Milestone v3.0.0
Assignees
Clear assignees
ahinkel (Andy Hinkel) gaisser (Steffen Gaisser) jenkins_buildfix meierj (Jakob Meier) mohr (Ulrich Mohr) mspahr muellerr (Robin Müller) tbaumgartl (Tobias Baumgartl)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fsfw/fsfw#513