fsfw/fsfw
11
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

CMakeLists fixes #517

Merged
gaisser merged 3 commits from mueller/cmake-fixes into development 2021-11-08 14:44:41 +01:00
Conversation 1 Commits 3 Files Changed 2 +8 -10
muellerr commented 2021-10-27 17:11:37 +02:00
Owner
Copy Link
  • FSFW.h was generated twice but one instance is not used anymore
  • Needed to reorder the definition of CMake variables to come before the configure_file directive. This led to the OSAL preprocessor define not being set, which was problematic for the STM32 FreeRTOS example
- `FSFW.h` was generated twice but one instance is not used anymore - Needed to reorder the definition of CMake variables to come before the `configure_file` directive. This led to the OSAL preprocessor define not being set, which was problematic for the STM32 FreeRTOS example
muellerr added 2 commits 2021-10-27 17:11:38 +02:00
second cmake fix cc7250fcf5
more important fix 42458725e8
muellerr requested review from mohr 2021-10-27 17:11:58 +02:00
muellerr added the bug label 2021-10-27 17:12:34 +02:00
muellerr added this to the v3.0.0 milestone 2021-10-27 17:12:41 +02:00
muellerr added 1 commit 2021-10-28 09:20:04 +02:00
Merge branch 'development' into mueller/cmake-fixes 9ad215c9a3
gaisser approved these changes 2021-11-08 14:43:10 +01:00
gaisser removed review request for mohr 2021-11-08 14:43:15 +01:00
gaisser self-assigned this 2021-11-08 14:43:20 +01:00
gaisser merged commit 87a15910fe into development 2021-11-08 14:44:41 +01:00
gaisser deleted branch mueller/cmake-fixes 2021-11-08 14:44:51 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
gaisser
Labels
Clear labels
API Change
Changes the API, so Users need to adapted
 Breaking API Change
Changes the API in a non backwards compatible way
 bug
Something is not working
 build
Issues related to the buildsystem, including CI
 cosmetics
Small change most users won't notice
 Documentation
Improvement of code documentation
 duplicate
This issue or pull request already exists
 feature
New feature
 help wanted
Need some help
 hotfix
Quick or important fix that is merged directly into master, causing a new revision
 invalid
#worksforme
 question
More information is needed
 Refactor
Contains a refactoring of some code
 Tests
Issues related to testing code
 wontfix
This won't be fixed
No Label bug
Milestone
No items
No Milestone v3.0.0
Assignees
Clear assignees
ahinkel dwoodward gaisser hanke jenkins_buildfix lrajer meierj mohr muellerr taheran tbaumgartl
No Assignees gaisser
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fsfw/fsfw#517
Delete Branch "mueller/cmake-fixes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?