CMake optimization #533

muellerr · 2022-01-18T18:47:05+01:00

muellerr commented

2022-01-18 18:47:05 +01:00

If the uppermost CMakeLists.txt does not have the include paths set up properly, there can be compile errors that #include "fsfw/FSFW.h" was not found. This should fix the issue.

From what I have seen, the additional target include directories are obsolete because there is nothing of interest inside the fsfw/src binary directory.

The configure file will be copied to the fsfw folder of the build directory and then is accessible inside the fsfw/ header namespace for
the FSFW. They are a little bit private in that sense, but the user can still access the FSFW version as a side effect if they include the upper most binary directory in CMake, but a cleaner way would be to define a function somewhere to access the version defines. Maybe something like a getVersion function inside a version.cpp / version.h which simply returns the version integers.

If the uppermost `CMakeLists.txt` does not have the include paths set up properly, there can be compile errors that `#include "fsfw/FSFW.h"` was not found. This should fix the issue. From what I have seen, the additional target include directories are obsolete because there is nothing of interest inside the `fsfw/src` binary directory. The configure file will be copied to the `fsfw` folder of the build directory and then is accessible inside the `fsfw/` header namespace for the FSFW. They are a little bit private in that sense, but the user can still access the FSFW version as a side effect if they include the upper most binary directory in CMake, but a cleaner way would be to define a function somewhere to access the version defines. Maybe something like a `getVersion` function inside a `version.cpp` / `version.h` which simply returns the version integers.

muellerr added 2 commits 2022-01-18 18:47:11 +01:00

try an optimization

fsfw/fsfw/pipeline/head This commit looks good

Details

78ddce249c

better comment

fsfw/fsfw/pipeline/head build bug von Jenkins manuell gefixed

Details

fsfw/fsfw/pipeline/pr-development This commit looks good

Details

6c63d82f5c

muellerr added the

bug

label 2022-01-19 14:54:23 +01:00

gaisser commented

2022-01-24 12:21:44 +01:00

I like the idea of a getVersion. Sounds useful.

I like the idea of a `` getVersion ``. Sounds useful.

👍 1

gaisser added this to the v4.0.0 milestone 2022-01-24 14:41:39 +01:00

gaisser self-assigned this 2022-01-24 14:41:43 +01:00

gaisser approved these changes 2022-01-24 14:41:48 +01:00

Dismissed

gaisser dismissed gaisser’s review 2022-01-24 14:42:54 +01:00

mohr self-assigned this 2022-01-31 15:40:52 +01:00

gaisser was unassigned by mohr

2022-01-31 15:40:52 +01:00

mohr merged commit 02ac92a6b3 into development

2022-01-31 15:41:10 +01:00

mohr referenced this issue from a commit

2022-01-31 15:41:10 +01:00

Merge pull request 'CMake optimization' (#533) from mueller/cmake-optimization into development

mohr deleted branch mueller/cmake-optimization

2022-01-31 15:41:11 +01:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: fsfw/fsfw#533