CMake optimization #533

muellerr · 2022-01-18T18:47:05+01:00

muellerr commented

2022-01-18 18:47:05 +01:00

If the uppermost CMakeLists.txt does not have the include paths set up properly, there can be compile errors that #include "fsfw/FSFW.h" was not found. This should fix the issue.

From what I have seen, the additional target include directories are obsolete because there is nothing of interest inside the fsfw/src binary directory.

The configure file will be copied to the fsfw folder of the build directory and then is accessible inside the fsfw/ header namespace for
the FSFW. They are a little bit private in that sense, but the user can still access the FSFW version as a side effect if they include the upper most binary directory in CMake, but a cleaner way would be to define a function somewhere to access the version defines. Maybe something like a getVersion function inside a version.cpp / version.h which simply returns the version integers.

If the uppermost `CMakeLists.txt` does not have the include paths set up properly, there can be compile errors that `#include "fsfw/FSFW.h"` was not found. This should fix the issue. From what I have seen, the additional target include directories are obsolete because there is nothing of interest inside the `fsfw/src` binary directory. The configure file will be copied to the `fsfw` folder of the build directory and then is accessible inside the `fsfw/` header namespace for the FSFW. They are a little bit private in that sense, but the user can still access the FSFW version as a side effect if they include the upper most binary directory in CMake, but a cleaner way would be to define a function somewhere to access the version defines. Maybe something like a `getVersion` function inside a `version.cpp` / `version.h` which simply returns the version integers.

muellerr added 2 commits 2022-01-18 18:47:11 +01:00