fsfw/fsfw
fsfw/fsfw
10
3
Fork 6
Code Issues 31 Pull Requests 4 Releases 10 Wiki Activity

Fixed test issue with overflow of times #574

Merged
mohr merged 3 commits from gaisser/fsfw:gaisser_ccsds_time_tests into development 2022-03-14 14:23:36 +01:00
Conversation 0 Commits 3 Files Changed 6 +9 -1
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 445d5dd6f0 - Show all commits

10
tests/src/fsfw_tests/unit/timemanager/TestCCSDSTime.cpp
View File

@ -111,12 +111,20 @@ TEST_CASE("CCSDSTime Tests", "[TestCCSDSTime]") {
CCSDSTime::CDS_short cdsTime;
result = CCSDSTime::convertToCcsds(&cdsTime, &timeAsTimeval);
CHECK(result == HasReturnvaluesIF::RETURN_OK);
// Days in CCSDS Epoch 22704 (0x58B0)
gaisser marked this conversation as resolved Outdated
mohr commented 2022-03-09 17:48:05 +01:00
Outdated
Review
Copy Link

Can you add a check for the resulting cds_short value, to find a reversible error in the conversions?

Can you add a check for the resulting cds_short value, to find a reversible error in the conversions?
gaisser commented 2022-03-09 18:58:01 +01:00
Outdated
Review
Copy Link

Done

Done
CHECK(cdsTime.dayMSB == 0x58);
CHECK(cdsTime.dayLSB == 0xB0);
// MS of day 48285123.456 (floored here)
CHECK(cdsTime.msDay_hh == 0x2);
CHECK(cdsTime.msDay_h == 0xE0);
CHECK(cdsTime.msDay_l == 0xC5);
CHECK(cdsTime.msDay_ll == 0xC3);
// Conversion back to timeval
timeval timeReturnAsTimeval;
result = CCSDSTime::convertFromCDS(&timeReturnAsTimeval, &cdsTime);
CHECK(result == HasReturnvaluesIF::RETURN_OK);
// us precision is lost
// micro seconds precision is lost
timeval difference = timeAsTimeval - timeReturnAsTimeval;
CHECK(difference.tv_usec == 456);
CHECK(difference.tv_sec == 0);