Fixed test issue with overflow of times #574

Merged
mohr merged 3 commits from gaisser/fsfw:gaisser_ccsds_time_tests into development 2022-03-14 14:23:36 +01:00
Owner

Tests of LocalDatapoolManager had an issue with overflowing times. This is solved by using timevalOperations.

  • Added conversion function from CCSDSTime::CDS_short to timeval
  • Added unit test for that function
  • Changed behavior of Clock::convertTimeOfDayToTimeval for Linux and Host (only unix implementation anyway). It now assumes that the input is UTC and not local time.
Tests of LocalDatapoolManager had an issue with overflowing times. This is solved by using timevalOperations. * Added conversion function from CCSDSTime::CDS_short to timeval * Added unit test for that function * **Changed behavior of Clock::convertTimeOfDayToTimeval** for Linux and Host (only unix implementation anyway). It now assumes that the input is UTC and not local time.
gaisser added this to the v5.0.0 milestone 2022-03-07 18:41:50 +01:00
gaisser added the
bug
feature
API Change
labels 2022-03-07 18:41:50 +01:00
gaisser added 2 commits 2022-03-07 18:41:54 +01:00
Changed behaviour of Host and Linux Clock
Fixed another issue of time checks
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
a4f97a7ba7
gaisser requested review from mohr 2022-03-09 12:55:55 +01:00
mohr requested changes 2022-03-09 17:48:10 +01:00
@ -92,0 +111,4 @@
CCSDSTime::CDS_short cdsTime;
result = CCSDSTime::convertToCcsds(&cdsTime, &timeAsTimeval);
CHECK(result == HasReturnvaluesIF::RETURN_OK);
Owner

Can you add a check for the resulting cds_short value, to find a reversible error in the conversions?

Can you add a check for the resulting cds_short value, to find a reversible error in the conversions?
Author
Owner

Done

Done
gaisser marked this conversation as resolved
gaisser added 1 commit 2022-03-09 18:56:50 +01:00
Added Checks for CDSShort in unittests
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
445d5dd6f0
gaisser requested review from mohr 2022-03-09 18:59:16 +01:00
mohr approved these changes 2022-03-09 20:13:37 +01:00
mohr left a comment
Owner

Thanks!

Thanks!
mohr self-assigned this 2022-03-14 14:19:57 +01:00
mohr merged commit 8704b9ab06 into development 2022-03-14 14:23:36 +01:00
mohr deleted branch gaisser_ccsds_time_tests 2022-03-14 14:23:40 +01:00
Sign in to join this conversation.
No description provided.