fsfw/fsfw
fsfw
/
fsfw
10
3
Fork 6
Code Issues 31 Pull Requests 4 Releases 10 Wiki Activity

Service 11 regression #670

Merged
mohr merged 2 commits from eive/fsfw:mueller/service-11-issues into development 2022-09-01 11:59:19 +02:00
Conversation 1 Commits 2 Files Changed 5 +27 -14
muellerr commented 2022-08-30 15:21:29 +02:00
Owner
Copy Link
  • the etl::multimap::iterator type is a bidirectional iterator and not a random access iterator, so the less operator is not implemented for it
  • I removed the safety check altogether. I think there is only one case where user input really can mess something up, and that is when the fromTimetag is larger than the toTimetag. I introduced a check for this before iterator manipulation now.
  • Unittests really would be useful.. this function was not compiled into the default CI/CD build. I detected this when compiling for EIVE. I don't really have time for this right now though.
- the `etl::multimap::iterator` type is a bidirectional iterator and not a random access iterator, so the less operator is not implemented for it - I removed the safety check altogether. I think there is only one case where user input really can mess something up, and that is when the fromTimetag is larger than the toTimetag. I introduced a check for this before iterator manipulation now. - Unittests really would be useful.. this function was not compiled into the default CI/CD build. I detected this when compiling for EIVE. I don't really have time for this right now though.
muellerr added 1 commit 2022-08-30 15:21:32 +02:00
fsfw/fsfw/pipeline/pr-development This commit looks good Details
64a7fde301 this is annoying
muellerr added the
Breaking API Change
 label 2022-08-30 15:21:40 +02:00
muellerr added this to the v6.0.0 milestone 2022-08-30 15:21:43 +02:00
mohr was assigned by muellerr 2022-08-30 15:21:47 +02:00
gaisser was assigned by muellerr 2022-08-30 15:21:47 +02:00
muellerr added
bug
hotfix
 and removed
Breaking API Change
 labels 2022-08-30 15:23:03 +02:00
mohr added 1 commit 2022-09-01 11:56:17 +02:00
fsfw/fsfw/pipeline/pr-development This commit looks good Details
2b01e86f9c one small additional precaution
mohr commented 2022-09-01 11:57:08 +02:00
Owner
Copy Link

Added empty unittest, to catch at least compiler errors...

Added empty unittest, to catch at least compiler errors...
mohr approved these changes 2022-09-01 11:57:25 +02:00
mohr merged commit 7dec45ccf2 into development 2022-09-01 11:59:19 +02:00
mohr deleted branch mueller/service-11-issues 2022-09-01 11:59:20 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
mohr
Labels
Clear labels   
API Change

Changes the API, so Users need to adapted

  
Breaking API Change

Changes the API in a non backwards compatible way

  
bug

Something is not working

  
build

Issues related to the buildsystem, including CI

  
cosmetics

Small change most users won't notice

  
Documentation

Improvement of code documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
hotfix

Quick or important fix that is merged directly into master, causing a new revision

  
invalid

#worksforme

  
question

More information is needed

  
Refactor

Contains a refactoring of some code

  
Tests

Issues related to testing code

  
wontfix

This won't be fixed

No Label
API Change
Breaking API Change
bug
build
cosmetics
Documentation
duplicate
feature
help wanted
hotfix
invalid
question
Refactor
Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
v6.0.0
Assignees
Clear assignees
No Assignees
mohr
gaisser
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: fsfw/fsfw#670
No description provided.
Delete Branch "eive/fsfw:mueller/service-11-issues"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?