Service 11 regression #670

muellerr · 2022-08-30T15:21:29+02:00

muellerr commented

2022-08-30 15:21:29 +02:00

the etl::multimap::iterator type is a bidirectional iterator and not a random access iterator, so the less operator is not implemented for it
I removed the safety check altogether. I think there is only one case where user input really can mess something up, and that is when the fromTimetag is larger than the toTimetag. I introduced a check for this before iterator manipulation now.
Unittests really would be useful.. this function was not compiled into the default CI/CD build. I detected this when compiling for EIVE. I don't really have time for this right now though.

- the `etl::multimap::iterator` type is a bidirectional iterator and not a random access iterator, so the less operator is not implemented for it - I removed the safety check altogether. I think there is only one case where user input really can mess something up, and that is when the fromTimetag is larger than the toTimetag. I introduced a check for this before iterator manipulation now. - Unittests really would be useful.. this function was not compiled into the default CI/CD build. I detected this when compiling for EIVE. I don't really have time for this right now though.

muellerr added 1 commit 2022-08-30 15:21:32 +02:00

this is annoying

fsfw/fsfw/pipeline/pr-development This commit looks good

Details

64a7fde301

muellerr added the

Breaking API Change

label 2022-08-30 15:21:40 +02:00

muellerr added this to the v6.0.0 milestone 2022-08-30 15:21:43 +02:00

mohr was assigned by muellerr

2022-08-30 15:21:47 +02:00

gaisser was assigned by muellerr