fsfw/fsfw
12
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

Service 11 regression #670

Merged
mohr merged 2 commits from eive/fsfw:mueller/service-11-issues into development 2022-09-01 11:59:19 +02:00
Conversation 2 Commits 2 Files Changed 5
+27 -14
muellerr commented 2022-08-30 15:21:29 +02:00
Owner
Copy Link
Copy Source
  • the etl::multimap::iterator type is a bidirectional iterator and not a random access iterator, so the less operator is not implemented for it
  • I removed the safety check altogether. I think there is only one case where user input really can mess something up, and that is when the fromTimetag is larger than the toTimetag. I introduced a check for this before iterator manipulation now.
  • Unittests really would be useful.. this function was not compiled into the default CI/CD build. I detected this when compiling for EIVE. I don't really have time for this right now though.
- the `etl::multimap::iterator` type is a bidirectional iterator and not a random access iterator, so the less operator is not implemented for it - I removed the safety check altogether. I think there is only one case where user input really can mess something up, and that is when the fromTimetag is larger than the toTimetag. I introduced a check for this before iterator manipulation now. - Unittests really would be useful.. this function was not compiled into the default CI/CD build. I detected this when compiling for EIVE. I don't really have time for this right now though.
muellerr added 1 commit 2022-08-30 15:21:32 +02:00
this is annoying
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
64a7fde301
muellerr added the Breaking API Change label 2022-08-30 15:21:40 +02:00
muellerr added this to the v6.0.0 milestone 2022-08-30 15:21:43 +02:00
mohr was assigned by muellerr 2022-08-30 15:21:47 +02:00
gaisser was assigned by muellerr 2022-08-30 15:21:47 +02:00
muellerr added bughotfix and removed Breaking API Change labels 2022-08-30 15:23:03 +02:00
mohr added 1 commit 2022-09-01 11:56:17 +02:00
one small additional precaution
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
2b01e86f9c
mohr commented 2022-09-01 11:57:08 +02:00
Owner
Copy Link
Copy Source

Added empty unittest, to catch at least compiler errors...

Added empty unittest, to catch at least compiler errors...
mohr approved these changes 2022-09-01 11:57:25 +02:00
mohr merged commit 7dec45ccf2 into development 2022-09-01 11:59:19 +02:00
mohr deleted branch mueller/service-11-issues 2022-09-01 11:59:20 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
mohr
Labels
Clear labels
API Change
Changes the API, so Users need to adapted
 Breaking API Change
Changes the API in a non backwards compatible way
 Documentation
Improvement of code documentation
 Refactor
Contains a refactoring of some code
 Tests
Issues related to testing code
 bug
Something is not working
 build
Issues related to the buildsystem, including CI
 cosmetics
Small change most users won't notice
 duplicate
This issue or pull request already exists
 feature
New feature
 help wanted
Need some help
 hotfix
Quick or important fix that is merged directly into master, causing a new revision
 invalid
#worksforme
 question
More information is needed
 wontfix
This won't be fixed
No labels bug hotfix
Milestone
No items
No Milestone v6.0.0
Assignees
Clear assignees
ahinkel (Andy Hinkel) gaisser (Steffen Gaisser) jenkins_buildfix meierj (Jakob Meier) mohr (Ulrich Mohr) mspahr muellerr (Robin Müller) tbaumgartl (Tobias Baumgartl)
No Assignees mohr gaisser
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fsfw/fsfw#670