fsfw/fsfw
fsfw/fsfw
10
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

provide a weak print char impl #674

Merged
mohr merged 2 commits from mueller/provide-weak-print-char into development 2022-09-12 14:10:32 +02:00
Conversation 1 Commits 2 Files Changed 2 +12
2 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/fsfw_hal/common/CMakeLists.txt
View File

@ -1 +1,3 @@
add_subdirectory(gpio)
target_sources(${LIB_FSFW_NAME} PRIVATE printChar.c)

10
src/fsfw_hal/common/printChar.c Normal file
View File

@ -0,0 +1,10 @@
#include <stdio.h>
#include <stdbool.h>
void __attribute__((weak)) printChar(const char* character, bool errStream) {
gaisser commented 2022-09-05 15:40:06 +02:00
Review
Copy Link

Does not build with MSVC https://godbolt.org/z/s8hav4sdn

There seems to be solution for MSVC https://stackoverflow.com/questions/2290587/gcc-style-weak-linking-in-visual-studio

Does not build with MSVC https://godbolt.org/z/s8hav4sdn There seems to be solution for MSVC https://stackoverflow.com/questions/2290587/gcc-style-weak-linking-in-visual-studio
muellerr commented 2022-09-05 16:04:37 +02:00
Review
Copy Link

Wow, this looks.. interesting. Yet another MS specific solution

Wow, this looks.. interesting. Yet another MS specific solution
muellerr commented 2022-09-07 17:50:59 +02:00
Review
Copy Link

The solution above is for an extern const char*.
Actually, https://docs.microsoft.com/en-us/cpp/cpp/selectany?view=msvc-170 might work as well. I can't really test this as MSVC does not compile anyway, so I suggest support for this is added in a seprate PR.

The solution above is for an extern const char*. Actually, https://docs.microsoft.com/en-us/cpp/cpp/selectany?view=msvc-170 might work as well. I can't really test this as MSVC does not compile anyway, so I suggest support for this is added in a seprate PR.
if (errStream) {
fprintf(stderr, "%c", *character);
} else {
printf("%c", *character);
}
}