fsfw/fsfw
11
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

remove user includes #675

Merged
mohr merged 4 commits from mueller/remove-user-includes into development 2022-09-12 14:15:19 +02:00
Conversation 1 Commits 4 Files Changed 4 +4 -5
muellerr commented 2022-09-02 08:57:18 +02:00
Owner
Copy Link
  • Part of a small workshop project fsfw-from-zero.
  • Remove user-level includes. This might actually break a few things in user-code but I'd still prefer to avoid user-includes in core library files. Maybe include them in the include helpers fsfw/events.h and fsfw/retval.h ? Or include them in the provided misc/FSFWConfig.h ?
- Part of a small workshop project fsfw-from-zero. - Remove user-level includes. This might actually break a few things in user-code but I'd still prefer to avoid user-includes in core library files. Maybe include them in the include helpers `fsfw/events.h` and `fsfw/retval.h` ? Or include them in the provided `misc/FSFWConfig.h` ?
muellerr added 1 commit 2022-09-02 08:57:20 +02:00
remove user includes
All checks were successful
fsfw/fsfw/pipeline/head This commit looks good
Details
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
1e85cdadfd
muellerr requested review from mohr 2022-09-02 08:57:31 +02:00
muellerr added this to the v6.0.0 milestone 2022-09-02 08:57:35 +02:00
muellerr added the help wanted label 2022-09-02 08:57:40 +02:00
muellerr added 1 commit 2022-09-02 09:04:37 +02:00
another user-level-include
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
04800df31e
muellerr requested review from gaisser 2022-09-05 14:12:47 +02:00
muellerr added 1 commit 2022-09-05 15:36:05 +02:00
update FSFWCnfig.h
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
b7a1f79d5b
mohr approved these changes 2022-09-12 12:56:32 +02:00
mohr removed review request for gaisser 2022-09-12 12:56:36 +02:00
muellerr added 1 commit 2022-09-12 14:07:12 +02:00
Merge branch 'development' into mueller/remove-user-includes
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
6ae709acc3
mohr merged commit 1126db2c8a into development 2022-09-12 14:15:19 +02:00
mohr deleted branch mueller/remove-user-includes 2022-09-12 14:15:20 +02:00
muellerr added the Breaking API Change label 2022-09-14 13:14:16 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
mohr
Labels
Clear labels
API Change
Changes the API, so Users need to adapted
 Breaking API Change
Changes the API in a non backwards compatible way
 bug
Something is not working
 build
Issues related to the buildsystem, including CI
 cosmetics
Small change most users won't notice
 Documentation
Improvement of code documentation
 duplicate
This issue or pull request already exists
 feature
New feature
 help wanted
Need some help
 hotfix
Quick or important fix that is merged directly into master, causing a new revision
 invalid
#worksforme
 question
More information is needed
 Refactor
Contains a refactoring of some code
 Tests
Issues related to testing code
 wontfix
This won't be fixed
No Label Breaking API Change help wanted
Milestone
No items
No Milestone v6.0.0
Assignees
Clear assignees
ahinkel gaisser jenkins_buildfix meierj mohr muellerr tbaumgartl
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fsfw/fsfw#675
Delete Branch "mueller/remove-user-includes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?