fsfw/fsfw
fsfw/fsfw
10
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

SerialBufferAdapter refactoring #677

Merged
mohr merged 1 commits from mueller/refactor-serial-buffer-adapter into development 2022-09-12 14:30:53 +02:00
Conversation 0 Commits 1 Files Changed 8 +25 -25
muellerr commented 2022-09-05 16:33:03 +02:00
Owner
Copy Link
  • Change setBuffer to setConstBuffer. This makes it a bit clearer that only the read only portion of the serial buffer adapter is set. Also avoids some const casts in the framework code. Framework internally, the API does not have to expect a non-const pointer from what I have seen. If this API becomes necessary in the future, it could be added with the name setBuffer
  • Add a default constructor. This makes it possible to set the read-only buffer after construction, which is required sometimes.
  • Apply auto-formatter
- Change `setBuffer` to `setConstBuffer`. This makes it a bit clearer that only the read only portion of the serial buffer adapter is set. Also avoids some const casts in the framework code. Framework internally, the API does not have to expect a non-const pointer from what I have seen. If this API becomes necessary in the future, it could be added with the name `setBuffer` - Add a default constructor. This makes it possible to set the read-only buffer after construction, which is required sometimes. - Apply auto-formatter
muellerr added 1 commit 2022-09-05 16:33:06 +02:00
rename setBuffer to setConstBuffer
Some checks are pending
fsfw/fsfw/pipeline/head Build started...
Details
fsfw/fsfw/pipeline/pr-development Build started...
Details
16688316a8
muellerr changed title from rename setBuffer to setConstBuffer to Change setBuffer to setConstBuffer 2022-09-05 16:33:21 +02:00
muellerr requested review from mohr 2022-09-05 16:33:34 +02:00
muellerr requested review from gaisser 2022-09-05 16:33:37 +02:00
muellerr added this to the v6.0.0 milestone 2022-09-05 16:33:40 +02:00
muellerr added a new dependency 2022-09-05 16:34:52 +02:00
#655 Refactor TMTC Stack, improve test framework
muellerr changed title from Change setBuffer to setConstBuffer to SerialBufferAdapter refactor 2022-09-05 16:35:30 +02:00
muellerr changed title from SerialBufferAdapter refactor to SerialBufferAdapter refactoring 2022-09-05 16:36:24 +02:00
mohr approved these changes 2022-09-12 13:05:55 +02:00
mohr removed review request for gaisser 2022-09-12 13:06:03 +02:00
mohr merged commit 62cd39e573 into development 2022-09-12 14:30:53 +02:00
mohr deleted branch mueller/refactor-serial-buffer-adapter 2022-09-12 14:30:58 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
mohr
Labels
Clear labels   
API Change

Changes the API, so Users need to adapted

  
Breaking API Change

Changes the API in a non backwards compatible way

  
bug

Something is not working

  
build

Issues related to the buildsystem, including CI

  
cosmetics

Small change most users won't notice

  
Documentation

Improvement of code documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
hotfix

Quick or important fix that is merged directly into master, causing a new revision

  
invalid

#worksforme

  
question

More information is needed

  
Refactor

Contains a refactoring of some code

  
Tests

Issues related to testing code

  
wontfix

This won't be fixed

No Label
API Change
Breaking API Change
bug
build
cosmetics
Documentation
duplicate
feature
help wanted
hotfix
invalid
question
Refactor
Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
v6.0.0
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Blocks
#655 Refactor TMTC Stack, improve test framework
fsfw/fsfw
Reference: fsfw/fsfw#677
No description provided.
Delete Branch "mueller/refactor-serial-buffer-adapter"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?