SerialBufferAdapter refactoring #677

Merged
mohr merged 1 commits from mueller/refactor-serial-buffer-adapter into development 2022-09-12 14:30:53 +02:00
Owner
  • Change setBuffer to setConstBuffer. This makes it a bit clearer that only the read only portion of the serial buffer adapter is set. Also avoids some const casts in the framework code. Framework internally, the API does not have to expect a non-const pointer from what I have seen. If this API becomes necessary in the future, it could be added with the name setBuffer
  • Add a default constructor. This makes it possible to set the read-only buffer after construction, which is required sometimes.
  • Apply auto-formatter
- Change `setBuffer` to `setConstBuffer`. This makes it a bit clearer that only the read only portion of the serial buffer adapter is set. Also avoids some const casts in the framework code. Framework internally, the API does not have to expect a non-const pointer from what I have seen. If this API becomes necessary in the future, it could be added with the name `setBuffer` - Add a default constructor. This makes it possible to set the read-only buffer after construction, which is required sometimes. - Apply auto-formatter
muellerr added 1 commit 2022-09-05 16:33:06 +02:00
rename setBuffer to setConstBuffer
Some checks are pending
fsfw/fsfw/pipeline/head Build started...
fsfw/fsfw/pipeline/pr-development Build started...
16688316a8
muellerr changed title from rename setBuffer to setConstBuffer to Change setBuffer to setConstBuffer 2022-09-05 16:33:21 +02:00
muellerr requested review from mohr 2022-09-05 16:33:34 +02:00
muellerr requested review from gaisser 2022-09-05 16:33:37 +02:00
muellerr added this to the v6.0.0 milestone 2022-09-05 16:33:40 +02:00
muellerr added a new dependency 2022-09-05 16:34:52 +02:00
muellerr changed title from Change setBuffer to setConstBuffer to SerialBufferAdapter refactor 2022-09-05 16:35:30 +02:00
muellerr changed title from SerialBufferAdapter refactor to SerialBufferAdapter refactoring 2022-09-05 16:36:24 +02:00
mohr approved these changes 2022-09-12 13:05:55 +02:00
mohr removed review request for gaisser 2022-09-12 13:06:03 +02:00
mohr merged commit 62cd39e573 into development 2022-09-12 14:30:53 +02:00
mohr deleted branch mueller/refactor-serial-buffer-adapter 2022-09-12 14:30:58 +02:00
Sign in to join this conversation.
No description provided.