remove ObjectManager production callback #696
Labels
No Label
API Change
Breaking API Change
bug
build
cosmetics
Documentation
duplicate
feature
help wanted
hotfix
invalid
question
Refactor
Tests
wontfix
No Milestone
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Depends on
#697 missing retval conv
fsfw/fsfw
#698 small fix for helper
fsfw/fsfw
Reference: fsfw/fsfw#696
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "mueller/obj-man-remove-weird-proc-func"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
I am working on the workshop and I have some issues explaining why the object construction should be constrained to this callback. I can't really think of a reason. I think this can simply be removed and users can perform the object construction however they see fit.
remove weird prod callbackto remove weird object prod callbackremove weird object prod callbackto remove ObjectManager production callbackThe callback prescribes a structure in that it enforces that objects are constructed before they are initialized.
I suggested that a special configuration object could be passed to the FSFW which wraps all the configuration handling for the FSFW in some way. This config object could then contain the construction of global objects in an abstract function.
I am still not fully happy that this callback function was tied to a global singleton, but I can understand the requirement to enforce a call order structure in the code.
Checkout
From your project repository, check out a new branch and test the changes.