fsfw/fsfw
fsfw
/
fsfw
10
3
Fork 6
Code Issues 31 Pull Requests 4 Releases 10 Wiki Activity

remove ObjectManager production callback #696

Open
muellerr wants to merge 6 commits from mueller/obj-man-remove-weird-proc-func into development
pull from: mueller/obj-man-remove-weird-proc-func
merge into: fsfw:development
Conversation 1 Commits 6 Files Changed 4 +2 -23
muellerr commented 2022-10-04 10:48:59 +02:00
Owner
Copy Link

I am working on the workshop and I have some issues explaining why the object construction should be constrained to this callback. I can't really think of a reason. I think this can simply be removed and users can perform the object construction however they see fit.

I am working on the workshop and I have some issues explaining why the object construction should be constrained to this callback. I can't really think of a reason. I think this can simply be removed and users can perform the object construction however they see fit.
muellerr added 1 commit 2022-10-04 10:49:00 +02:00
fsfw/fsfw/pipeline/head There was a failure building this commit Details
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
cdbf20bae7
remove weird prod callback
muellerr requested review from mohr 2022-10-04 10:49:09 +02:00
muellerr requested review from gaisser 2022-10-04 10:49:13 +02:00
muellerr changed title from remove weird prod callback to remove weird object prod callback 2022-10-04 10:49:29 +02:00
muellerr changed title from remove weird object prod callback to remove ObjectManager production callback 2022-10-04 10:50:44 +02:00
muellerr added 1 commit 2022-10-04 10:51:14 +02:00
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
5a9d37f5d8
remove check
muellerr added this to the v6.0.0 milestone 2022-10-04 10:52:33 +02:00
muellerr added 2 commits 2022-10-04 10:52:46 +02:00
fsfw/fsfw/pipeline/head This commit looks good Details
fsfw/fsfw/pipeline/pr-development This commit looks good Details
6f562e5f3e
missing retval conv
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
1c6efe2abb Merge branch 'mueller/missing-retval-conversion' into mueller/obj-man-remove-weird-proc-func
muellerr added a new dependency 2022-10-04 10:52:47 +02:00
#697 missing retval conv
muellerr added a new dependency 2022-10-04 10:56:51 +02:00
#698 small fix for helper
muellerr added 2 commits 2022-10-04 11:03:48 +02:00
fsfw/fsfw/pipeline/head Build started... Details
fsfw/fsfw/pipeline/pr-development This commit looks good Details
448d20f3bd
small fix for helper
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
fd46784d0d Merge branch 'mueller/small-helper-script-fix' into mueller/obj-man-remove-weird-proc-func
muellerr added 1 commit 2022-10-04 13:24:34 +02:00
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
7382d0b38a
that should do the job
muellerr commented 2022-10-17 14:49:14 +02:00
Author
Owner
Copy Link

The callback prescribes a structure in that it enforces that objects are constructed before they are initialized.

I suggested that a special configuration object could be passed to the FSFW which wraps all the configuration handling for the FSFW in some way. This config object could then contain the construction of global objects in an abstract function.

I am still not fully happy that this callback function was tied to a global singleton, but I can understand the requirement to enforce a call order structure in the code.

The callback prescribes a structure in that it enforces that objects are constructed before they are initialized. I suggested that a [special configuration object](https://egit.irs.uni-stuttgart.de/fsfw/fsfw/issues/451) could be passed to the FSFW which wraps all the configuration handling for the FSFW in some way. This config object could then contain the construction of global objects in an abstract function. I am still not fully happy that this callback function was tied to a global singleton, but I can understand the requirement to enforce a call order structure in the code.
mohr removed this from the v6.0.0 milestone 2023-02-09 13:35:17 +01:00
Some checks failed
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
Details
This pull request has changes conflicting with the target branch.
  • src/fsfw/objectmanager/ObjectManager.h
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b mueller/obj-man-remove-weird-proc-func development
git pull origin mueller/obj-man-remove-weird-proc-func

Step 2:

Merge the changes and update on Gitea.
git checkout development
git merge --no-ff mueller/obj-man-remove-weird-proc-func
git push origin development
Sign in to join this conversation.
Reviewers
No reviewers
mohr
gaisser
Labels
Clear labels   
API Change

Changes the API, so Users need to adapted

  
Breaking API Change

Changes the API in a non backwards compatible way

  
bug

Something is not working

  
build

Issues related to the buildsystem, including CI

  
cosmetics

Small change most users won't notice

  
Documentation

Improvement of code documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
hotfix

Quick or important fix that is merged directly into master, causing a new revision

  
invalid

#worksforme

  
question

More information is needed

  
Refactor

Contains a refactoring of some code

  
Tests

Issues related to testing code

  
wontfix

This won't be fixed

No Label
API Change
Breaking API Change
bug
build
cosmetics
Documentation
duplicate
feature
help wanted
hotfix
invalid
question
Refactor
Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Depends on
#697 missing retval conv
fsfw/fsfw
#698 small fix for helper
fsfw/fsfw
Reference: fsfw/fsfw#696
No description provided.
Delete Branch "mueller/obj-man-remove-weird-proc-func"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?