remove ObjectManager production callback #696

Open
muellerr wants to merge 6 commits from mueller/obj-man-remove-weird-proc-func into development
Owner

I am working on the workshop and I have some issues explaining why the object construction should be constrained to this callback. I can't really think of a reason. I think this can simply be removed and users can perform the object construction however they see fit.

I am working on the workshop and I have some issues explaining why the object construction should be constrained to this callback. I can't really think of a reason. I think this can simply be removed and users can perform the object construction however they see fit.
muellerr added 1 commit 2022-10-04 10:49:00 +02:00
remove weird prod callback
Some checks failed
fsfw/fsfw/pipeline/head There was a failure building this commit
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
cdbf20bae7
muellerr requested review from mohr 2022-10-04 10:49:09 +02:00
muellerr requested review from gaisser 2022-10-04 10:49:13 +02:00
muellerr changed title from remove weird prod callback to remove weird object prod callback 2022-10-04 10:49:29 +02:00
muellerr changed title from remove weird object prod callback to remove ObjectManager production callback 2022-10-04 10:50:44 +02:00
muellerr added 1 commit 2022-10-04 10:51:14 +02:00
remove check
Some checks failed
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
5a9d37f5d8
muellerr added this to the v6.0.0 milestone 2022-10-04 10:52:33 +02:00
muellerr added 2 commits 2022-10-04 10:52:46 +02:00
missing retval conv
All checks were successful
fsfw/fsfw/pipeline/head This commit looks good
fsfw/fsfw/pipeline/pr-development This commit looks good
6f562e5f3e
Merge branch 'mueller/missing-retval-conversion' into mueller/obj-man-remove-weird-proc-func
Some checks failed
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
1c6efe2abb
muellerr added a new dependency 2022-10-04 10:52:47 +02:00
muellerr added a new dependency 2022-10-04 10:56:51 +02:00
muellerr added 2 commits 2022-10-04 11:03:48 +02:00
small fix for helper
Some checks are pending
fsfw/fsfw/pipeline/head Build started...
fsfw/fsfw/pipeline/pr-development This commit looks good
448d20f3bd
Merge branch 'mueller/small-helper-script-fix' into mueller/obj-man-remove-weird-proc-func
Some checks failed
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
fd46784d0d
muellerr added 1 commit 2022-10-04 13:24:34 +02:00
that should do the job
Some checks failed
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
7382d0b38a
Author
Owner

The callback prescribes a structure in that it enforces that objects are constructed before they are initialized.

I suggested that a special configuration object could be passed to the FSFW which wraps all the configuration handling for the FSFW in some way. This config object could then contain the construction of global objects in an abstract function.

I am still not fully happy that this callback function was tied to a global singleton, but I can understand the requirement to enforce a call order structure in the code.

The callback prescribes a structure in that it enforces that objects are constructed before they are initialized. I suggested that a [special configuration object](https://egit.irs.uni-stuttgart.de/fsfw/fsfw/issues/451) could be passed to the FSFW which wraps all the configuration handling for the FSFW in some way. This config object could then contain the construction of global objects in an abstract function. I am still not fully happy that this callback function was tied to a global singleton, but I can understand the requirement to enforce a call order structure in the code.
mohr removed this from the v6.0.0 milestone 2023-02-09 13:35:17 +01:00
Some checks failed
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
This pull request has changes conflicting with the target branch.
  • src/fsfw/objectmanager/ObjectManager.h

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin mueller/obj-man-remove-weird-proc-func:mueller/obj-man-remove-weird-proc-func
git checkout mueller/obj-man-remove-weird-proc-func
Sign in to join this conversation.
No description provided.