fsfw/fsfw
fsfw/fsfw
10
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

fix compiler warning for fixed array list copy ctor #704

Merged
gaisser merged 4 commits from eive/fsfw:mueller/fixed_array_list_copy_ctor into development 2022-11-14 14:28:51 +01:00
Conversation 0 Commits 4 Files Changed 1 +6 -2
muellerr commented 2022-11-10 15:55:04 +01:00
Owner
Copy Link

There was a compiler warning if the type T of the fixed array list is not a trivially copyable type. This fixes it and should be correct.

There was a compiler warning if the type T of the fixed array list is not a trivially copyable type. This fixes it and should be correct.
muellerr added 1 commit 2022-11-10 15:55:10 +01:00
fix compiler error for fixed array list copy ctor
Some checks failed
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
Details
83c2c4825c
muellerr requested review from gaisser 2022-11-10 15:55:17 +01:00
muellerr added this to the v6.0.0 milestone 2022-11-10 15:55:20 +01:00
muellerr added 1 commit 2022-11-10 16:15:39 +01:00
this not crash
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
5c84f12440
muellerr changed title from fix compiler error for fixed array list copy ctor to fix compiler warning for fixed array list copy ctor 2022-11-10 16:16:58 +01:00
muellerr changed title from fix compiler error for fixed array list copy ctor to fix compiler warning for fixed array list copy ctor 2022-11-10 16:17:00 +01:00
muellerr added 1 commit 2022-11-10 16:20:00 +01:00
replace other memcpy
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
16246d6ece
gaisser approved these changes 2022-11-14 14:21:01 +01:00
gaisser left a comment
Owner
Copy Link

LGTM

LGTM
gaisser added 1 commit 2022-11-14 14:21:09 +01:00
Merge branch 'development' into mueller/fixed_array_list_copy_ctor
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
1d084ee22f
gaisser merged commit 0956fbc740 into development 2022-11-14 14:28:50 +01:00
gaisser deleted branch mueller/fixed_array_list_copy_ctor 2022-11-14 14:29:03 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
gaisser
Labels
Clear labels   
API Change

Changes the API, so Users need to adapted

  
Breaking API Change

Changes the API in a non backwards compatible way

  
bug

Something is not working

  
build

Issues related to the buildsystem, including CI

  
cosmetics

Small change most users won't notice

  
Documentation

Improvement of code documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
hotfix

Quick or important fix that is merged directly into master, causing a new revision

  
invalid

#worksforme

  
question

More information is needed

  
Refactor

Contains a refactoring of some code

  
Tests

Issues related to testing code

  
wontfix

This won't be fixed

No Label
API Change
Breaking API Change
bug
build
cosmetics
Documentation
duplicate
feature
help wanted
hotfix
invalid
question
Refactor
Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
v6.0.0
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: fsfw/fsfw#704
No description provided.
Delete Branch "eive/fsfw:mueller/fixed_array_list_copy_ctor"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?