fsfw/fsfw
fsfw/fsfw
10
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

refactoring of serial drivers for linux #705

Merged
gaisser merged 4 commits from eive/fsfw:mueller/refactor_serial_linux into development 2022-11-14 14:39:42 +01:00
Conversation 0 Commits 4 Files Changed 11 +347 -333
muellerr commented 2022-11-10 17:53:23 +01:00
Owner
Copy Link
  • Rename Uart to Serial. The termios interface can be used for more than just UART, it can be used to communicate with general serial interfaces
  • Move some generic setter/getter functions to more simple C like module
  • Separate compilation flag to add serial / termios drivers
  • I am not sure that both the gpiod and the serial support need to be wrapped by FSFW_HAL_LINUX_ADD_PERIPHERAL_DRIVERS. I think those can stand as separately compilable helper modules. Might rename/remove FSFW_HAL_LINUX_ADD_PERIPHERAL_DRIVERS to FSFW_HAL_LINUX_ADD_SPI_I2C_DRIVERS in a separate PR because those are only interesting for embedded Linux devices with appropriate driver support.
- Rename `Uart` to `Serial`. The `termios` interface can be used for more than just UART, it can be used to communicate with general serial interfaces - Move some generic setter/getter functions to more simple C like module - Separate compilation flag to add serial / termios drivers - I am not sure that both the gpiod and the serial support need to be wrapped by `FSFW_HAL_LINUX_ADD_PERIPHERAL_DRIVERS`. I think those can stand as separately compilable helper modules. Might rename/remove `FSFW_HAL_LINUX_ADD_PERIPHERAL_DRIVERS` to `FSFW_HAL_LINUX_ADD_SPI_I2C_DRIVERS` in a separate PR because those are only interesting for embedded Linux devices with appropriate driver support.
muellerr added 1 commit 2022-11-10 17:53:29 +01:00
refactoring of serial drivers for linux
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
819a298b19
muellerr added this to the v6.0.0 milestone 2022-11-10 17:55:00 +01:00
muellerr requested review from gaisser 2022-11-10 17:57:29 +01:00
muellerr added 1 commit 2022-11-11 11:33:28 +01:00
rename cookie class
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
5b352978c5
muellerr added 1 commit 2022-11-11 11:34:59 +01:00
smaller include tweaks
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
b6a3c206cc
gaisser approved these changes 2022-11-14 14:36:27 +01:00
gaisser left a comment
Owner
Copy Link

LGTM

LGTM
gaisser added 1 commit 2022-11-14 14:36:36 +01:00
Merge branch 'development' into mueller/refactor_serial_linux
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
7b0db08962
muellerr added the
Breaking API Change
 label 2022-11-14 14:39:08 +01:00
gaisser merged commit 93fda71989 into development 2022-11-14 14:39:42 +01:00
gaisser deleted branch mueller/refactor_serial_linux 2022-11-14 14:39:53 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
gaisser
Labels
Clear labels   
API Change

Changes the API, so Users need to adapted

  
Breaking API Change

Changes the API in a non backwards compatible way

  
bug

Something is not working

  
build

Issues related to the buildsystem, including CI

  
cosmetics

Small change most users won't notice

  
Documentation

Improvement of code documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
hotfix

Quick or important fix that is merged directly into master, causing a new revision

  
invalid

#worksforme

  
question

More information is needed

  
Refactor

Contains a refactoring of some code

  
Tests

Issues related to testing code

  
wontfix

This won't be fixed

No Label
API Change
Breaking API Change
bug
build
cosmetics
Documentation
duplicate
feature
help wanted
hotfix
invalid
question
Refactor
Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
v6.0.0
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: fsfw/fsfw#705
No description provided.
Delete Branch "eive/fsfw:mueller/refactor_serial_linux"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?