fsfw/fsfw
fsfw/fsfw
10
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

updates for source sequence counter #714

Merged
gaisser merged 2 commits from eive/fsfw:source_seq_counter_update into development 2022-12-19 15:00:32 +01:00
Conversation 0 Commits 2 Files Changed 1 +17 -9
muellerr commented 2022-11-28 08:32:32 +01:00
Owner
Copy Link
No description provided.
muellerr added 1 commit 2022-11-28 08:32:34 +01:00
updates for source sequence counter
Some checks are pending
fsfw/fsfw/pipeline/pr-development Build started...
Details
ecde164f68
muellerr requested review from gaisser 2022-11-28 08:32:38 +01:00
muellerr added this to the v6.0.0 milestone 2022-11-28 08:32:50 +01:00
gaisser requested changes 2022-11-28 14:12:43 +01:00
gaisser left a comment
Owner
Copy Link

See comment

See comment
src/fsfw/tmtcservices/SourceSequenceCounter.h Outdated
@ -14,0 +11,4 @@
SourceSequenceCounter(uint16_t initialSequenceCount = 0) : sequenceCount(initialSequenceCount) {}
void increment() { sequenceCount = (sequenceCount + 1) % (ccsds::LIMIT_SEQUENCE_COUNT); }
void decrement() { sequenceCount = (sequenceCount - 1) % (ccsds::LIMIT_SEQUENCE_COUNT); }
uint16_t get() { return this->sequenceCount; }
gaisser commented 2022-11-28 14:12:01 +01:00
Owner
Copy Link

This could be const

This could be const
muellerr commented 2022-12-19 14:58:50 +01:00
Author
Owner
Copy Link

get ist const now

get ist const now
muellerr added 1 commit 2022-12-19 14:57:46 +01:00
make get const
Some checks are pending
fsfw/fsfw/pipeline/pr-development Build queued...
Details
ca80589233
gaisser merged commit 8589f4d63a into development 2022-12-19 15:00:32 +01:00
gaisser deleted branch source_seq_counter_update 2022-12-19 15:00:41 +01:00
gaisser requested review from gaisser 2022-12-19 15:00:45 +01:00
gaisser approved these changes 2022-12-19 15:00:52 +01:00
gaisser left a comment
Owner
Copy Link

LGTM

LGTM
Sign in to join this conversation.
Reviewers
No reviewers
gaisser
Labels
Clear labels   
API Change

Changes the API, so Users need to adapted

  
Breaking API Change

Changes the API in a non backwards compatible way

  
bug

Something is not working

  
build

Issues related to the buildsystem, including CI

  
cosmetics

Small change most users won't notice

  
Documentation

Improvement of code documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
hotfix

Quick or important fix that is merged directly into master, causing a new revision

  
invalid

#worksforme

  
question

More information is needed

  
Refactor

Contains a refactoring of some code

  
Tests

Issues related to testing code

  
wontfix

This won't be fixed

No Label
API Change
Breaking API Change
bug
build
cosmetics
Documentation
duplicate
feature
help wanted
hotfix
invalid
question
Refactor
Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
v6.0.0
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: fsfw/fsfw#714
No description provided.
Delete Branch "eive/fsfw:source_seq_counter_update"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?