updates for source sequence counter #714

Merged
gaisser merged 2 commits from eive/fsfw:source_seq_counter_update into development 2022-12-19 15:00:32 +01:00
Owner
No description provided.
muellerr added 1 commit 2022-11-28 08:32:34 +01:00
updates for source sequence counter
Some checks are pending
fsfw/fsfw/pipeline/pr-development Build started...
ecde164f68
muellerr requested review from gaisser 2022-11-28 08:32:38 +01:00
muellerr added this to the v6.0.0 milestone 2022-11-28 08:32:50 +01:00
gaisser requested changes 2022-11-28 14:12:43 +01:00
gaisser left a comment
Owner

See comment

See comment
@ -14,0 +11,4 @@
SourceSequenceCounter(uint16_t initialSequenceCount = 0) : sequenceCount(initialSequenceCount) {}
void increment() { sequenceCount = (sequenceCount + 1) % (ccsds::LIMIT_SEQUENCE_COUNT); }
void decrement() { sequenceCount = (sequenceCount - 1) % (ccsds::LIMIT_SEQUENCE_COUNT); }
uint16_t get() { return this->sequenceCount; }
Owner

This could be const

This could be const
Author
Owner

get ist const now

get ist const now
muellerr added 1 commit 2022-12-19 14:57:46 +01:00
make get const
Some checks are pending
fsfw/fsfw/pipeline/pr-development Build queued...
ca80589233
gaisser merged commit 8589f4d63a into development 2022-12-19 15:00:32 +01:00
gaisser deleted branch source_seq_counter_update 2022-12-19 15:00:41 +01:00
gaisser requested review from gaisser 2022-12-19 15:00:45 +01:00
gaisser approved these changes 2022-12-19 15:00:52 +01:00
gaisser left a comment
Owner

LGTM

LGTM
Sign in to join this conversation.
No description provided.