fsfw/fsfw
12
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

Add Health Service Announce All Health Info #725

Merged
mohr merged 9 commits from eive/fsfw:add_health_service_announce_all into development 2023-02-23 13:13:57 +01:00
Conversation 3 Commits 9 Files Changed 6
+197 -131
muellerr commented 2023-02-01 17:42:53 +01:00
Owner
Copy Link
Copy Source
No description provided.
muellerr added 3 commits 2023-02-01 17:42:56 +01:00
proper announce all impl e487f5be87
beatufil 29ea89044e
update changelog
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
61df451dd8
muellerr added this to the v6.0.0 milestone 2023-02-01 17:42:59 +01:00
muellerr added the bugBreaking API Change labels 2023-02-01 17:43:07 +01:00
muellerr marked the pull request as work in progress 2023-02-01 18:37:56 +01:00
muellerr added 1 commit 2023-02-01 19:59:13 +01:00
small but important bugfix for health service
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
c1f42618db
muellerr marked the pull request as ready for review 2023-02-01 20:02:10 +01:00
gaisser approved these changes 2023-02-02 17:27:57 +01:00
Dismissed
gaisser left a comment
Owner
Copy Link
Copy Source

We should do this in a better way in the future but I think it's ok for now.

We should do this in a better way in the future but I think it's ok for now.
muellerr added 1 commit 2023-02-06 14:40:54 +01:00
remove unreachable code
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
066f7a6f9b
gaisser added 1 commit 2023-02-06 15:03:58 +01:00
Merge branch 'development' into add_health_service_announce_all
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
d9da55fdab
gaisser added 1 commit 2023-02-06 16:31:08 +01:00
Merge branch 'development' into add_health_service_announce_all
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
Details
5b92247fbd
mohr requested changes 2023-02-09 11:59:48 +01:00
src/fsfw/pus/CServiceHealthCommanding.h Outdated
@@ -0,0 +14,4 @@
maxNumHealthInfoPerCycle(maxNumHealthInfoPerCycle) {}
object_id_t objectId;
uint16_t apid;
HealthTable &table;
mohr commented 2023-02-09 11:59:41 +01:00
Owner
Copy Link
Copy Source

Other system objects should not be passed by reference but by objectId and then gotten in initialize() from the ObjectManager.

Other system objects should not be passed by reference but by objectId and then gotten in initialize() from the ObjectManager.
muellerr commented 2023-02-09 14:54:01 +01:00
Author
Owner
Copy Link
Copy Source

Isn't it better to explicitily specify what is expected here? object_id_t yields 0 information in an API context, and I need to build a custom error in the init function.

Isn't it better to explicitily specify what is expected here? `object_id_t` yields 0 information in an API context, and I need to build a custom error in the init function.
mohr commented 2023-02-09 15:29:30 +01:00
Owner
Copy Link
Copy Source

Understood, this is just a core principle in the fsfw.

Understood, this is just a core principle in the fsfw.
mohr marked this conversation as resolved
gaisser dismissed gaisser's review 2023-02-20 14:28:39 +01:00
Reason:

See Ulis comments

mohr added 1 commit 2023-02-23 12:44:37 +01:00
changed health table parameter to objectId
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
Details
d76d97a36b
mohr force-pushed add_health_service_announce_all from 3bac779415 to 61562b18ab 2023-02-23 13:06:51 +01:00 Compare
mohr approved these changes 2023-02-23 13:13:46 +01:00
mohr merged commit 9bf3ff95b7 into development 2023-02-23 13:13:57 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
mohr
Labels
Clear labels
API Change
Changes the API, so Users need to adapted
 Breaking API Change
Changes the API in a non backwards compatible way
 bug
Something is not working
 build
Issues related to the buildsystem, including CI
 cosmetics
Small change most users won't notice
 Documentation
Improvement of code documentation
 duplicate
This issue or pull request already exists
 feature
New feature
 help wanted
Need some help
 hotfix
Quick or important fix that is merged directly into master, causing a new revision
 invalid
#worksforme
 question
More information is needed
 Refactor
Contains a refactoring of some code
 Tests
Issues related to testing code
 wontfix
This won't be fixed
No labels Breaking API Change bug
Milestone
No items
No Milestone v6.0.0
Assignees
Clear assignees
ahinkel (Andy Hinkel) gaisser (Steffen Gaisser) jenkins_buildfix meierj (Jakob Meier) mohr (Ulrich Mohr) mspahr muellerr (Robin Müller) tbaumgartl (Tobias Baumgartl)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fsfw/fsfw#725