Add Health Service Announce All Health Info #725

Merged
mohr merged 9 commits from eive/fsfw:add_health_service_announce_all into development 2023-02-23 13:13:57 +01:00
Owner
No description provided.
muellerr added 3 commits 2023-02-01 17:42:56 +01:00
muellerr added this to the v6.0.0 milestone 2023-02-01 17:42:59 +01:00
muellerr added the
bug
Breaking API Change
labels 2023-02-01 17:43:07 +01:00
muellerr changed title from Add Health Service Announce All Health Info to WIP: Add Health Service Announce All Health Info 2023-02-01 18:37:56 +01:00
muellerr added 1 commit 2023-02-01 19:59:13 +01:00
fsfw/fsfw/pipeline/pr-development This commit looks good Details
c1f42618db
small but important bugfix for health service
muellerr changed title from WIP: Add Health Service Announce All Health Info to Add Health Service Announce All Health Info 2023-02-01 20:02:10 +01:00
gaisser approved these changes 2023-02-02 17:27:57 +01:00
Dismissed
gaisser left a comment
Owner

We should do this in a better way in the future but I think it's ok for now.

We should do this in a better way in the future but I think it's ok for now.
muellerr added 1 commit 2023-02-06 14:40:54 +01:00
fsfw/fsfw/pipeline/pr-development This commit looks good Details
066f7a6f9b
remove unreachable code
gaisser added 1 commit 2023-02-06 15:03:58 +01:00
fsfw/fsfw/pipeline/pr-development This commit looks good Details
d9da55fdab
Merge branch 'development' into add_health_service_announce_all
gaisser added 1 commit 2023-02-06 16:31:08 +01:00
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
5b92247fbd
Merge branch 'development' into add_health_service_announce_all
mohr requested changes 2023-02-09 11:59:48 +01:00
@ -0,0 +14,4 @@
maxNumHealthInfoPerCycle(maxNumHealthInfoPerCycle) {}
object_id_t objectId;
uint16_t apid;
HealthTable &table;
Owner

Other system objects should not be passed by reference but by objectId and then gotten in initialize() from the ObjectManager.

Other system objects should not be passed by reference but by objectId and then gotten in initialize() from the ObjectManager.
Author
Owner

Isn't it better to explicitily specify what is expected here? object_id_t yields 0 information in an API context, and I need to build a custom error in the init function.

Isn't it better to explicitily specify what is expected here? `object_id_t` yields 0 information in an API context, and I need to build a custom error in the init function.
Owner

Understood, this is just a core principle in the fsfw.

Understood, this is just a core principle in the fsfw.
mohr marked this conversation as resolved
gaisser dismissed gaisser’s review 2023-02-20 14:28:39 +01:00
Reason:

See Ulis comments

mohr added 1 commit 2023-02-23 12:44:37 +01:00
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
d76d97a36b
changed health table parameter to objectId
mohr added 1 commit 2023-02-23 12:46:31 +01:00
fsfw/fsfw/pipeline/pr-development This commit looks good Details
3bac779415
Merge branch 'development' into add_health_service_announce_all
mohr force-pushed add_health_service_announce_all from 3bac779415 to 61562b18ab 2023-02-23 13:06:51 +01:00 Compare
mohr approved these changes 2023-02-23 13:13:46 +01:00
mohr merged commit 9bf3ff95b7 into development 2023-02-23 13:13:57 +01:00
Sign in to join this conversation.
No description provided.