CMakeLists file updates #731

Merged
mohr merged 4 commits from eive/fsfw:cmakelists_update into development 2023-02-09 15:29:47 +01:00
Owner
  • Suppress warning if ETL is not found because then we do an auto-download and the warning is confusing.
  • Correction and improvement for printout in other CMakeLists.txt file.
- Suppress warning if ETL is not found because then we do an auto-download and the warning is confusing. - Correction and improvement for printout in other `CMakeLists.txt` file.
muellerr added 1 commit 2023-02-07 12:16:05 +01:00
correction for printout, add prefix
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
0a23f2c85a
muellerr added 1 commit 2023-02-07 12:16:46 +01:00
suppress error if ETL is not found
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
539d7aac9e
muellerr changed title from correction for printout, add prefix to CMakeLists file updates 2023-02-07 12:17:00 +01:00
muellerr added this to the v6.0.0 milestone 2023-02-07 12:17:59 +01:00
muellerr requested review from gaisser 2023-02-07 12:18:05 +01:00
mohr added 1 commit 2023-02-09 11:35:25 +01:00
Making fetch Catch2 quiet as well.
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
8c712441ab
Owner

I made the fetch of Catch2 quiet as well and unified the messages when ETL or Catch2 are not found. The one for ETL was misleading as it said "installing".

As for the addition of CONFIG, I do not see how this affects the verbosity of the command. It only changes the way find_package searches for the package and I am not sure we want to restrict it to config mode only.

I made the fetch of Catch2 quiet as well and unified the messages when ETL or Catch2 are not found. The one for ETL was misleading as it said "installing". As for the addition of `CONFIG`, I do not see how this affects the verbosity of the command. It only changes the way find_package searches for the package and I am not sure we want to restrict it to config mode only.
Author
Owner

CONFIG not necessary, probably something I forgot to remove. Did you do this in another branch?

`CONFIG` not necessary, probably something I forgot to remove. Did you do this in another branch?
mohr added 1 commit 2023-02-09 13:50:20 +01:00
removed unneeded find_package parameter for etl
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
010509efb4
Owner

Ok, I removed CONFIG. Did I do what in another branch?

Ok, I removed `CONFIG`. Did I do what in another branch?
Author
Owner

Ah you pushed into this branch directly no issues.

Ah you pushed into this branch directly no issues.
mohr removed review request for gaisser 2023-02-09 15:27:36 +01:00
mohr approved these changes 2023-02-09 15:27:44 +01:00
mohr merged commit b676040c7c into development 2023-02-09 15:29:47 +01:00
muellerr deleted branch cmakelists_update 2023-02-09 18:05:08 +01:00
Sign in to join this conversation.
No description provided.