fsfw
/
fsfw
10
3
Fork 4
Code Issues 31 Pull Requests 4 Releases 10 Wiki Activity
Labels Milestones

TCP/IP server fixes and improvements #747

Merged
mohr merged 3 commits from eive/fsfw:tcpip_server_fixes_improvements into development 2 weeks ago
Conversation 0 Commits 3 Files Changed 8
muellerr commented 3 months ago
Owner
There is no content yet.
muellerr added 1 commit 3 months ago
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
c35a0a8541
TCP/IP server fixes and improvements
mohr requested changes 4 weeks ago
src/fsfw/osal/common/TcpIpBase.cpp
#elif defined(PLATFORM_UNIX)
return close(socket);
#endif
return -1;
mohr commented 4 weeks ago
Owner

#else would be cleaner, otherwise compiler will criticize double return. Same some lines below

`#else` would be cleaner, otherwise compiler will criticize double return. Same some lines below
mohr marked this conversation as resolved
muellerr added 1 commit 2 weeks ago
muellerr added 1 commit 2 weeks ago
fsfw/fsfw/pipeline/pr-development This commit looks good Details
2714e588d7
improvements
mohr approved these changes 2 weeks ago
mohr merged commit f95c373076 into development 2 weeks ago
muellerr deleted branch tcpip_server_fixes_improvements 2 weeks ago

Reviewers

mohr approved these changes 2 weeks ago
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
The pull request has been merged as f95c373076.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
mohr
Labels
Apply labels
Clear labels
API Change
Changes the API, so Users need to adapted Breaking API Change
Changes the API in a non backwards compatible way bug
Something is not working build
Issues related to the buildsystem, including CI cosmetics
Small change most users won't notice Documentation
Improvement of code documentation duplicate
This issue or pull request already exists feature
New feature help wanted
Need some help hotfix
Quick or important fix that is merged directly into master, causing a new revision invalid
#worksforme question
More information is needed Refactor
Contains a refactoring of some code Tests
Issues related to testing code wontfix
This won't be fixed
No Label API Change Breaking API Change bug build cosmetics Documentation duplicate feature help wanted hotfix invalid question Refactor Tests wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: fsfw/fsfw#747
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'eive/fsfw:tcpip_server_fixes_improvements'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes