fsfw/fsfw
fsfw/fsfw
10
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

TCP/IP server fixes and improvements #747

Merged
mohr merged 3 commits from eive/fsfw:tcpip_server_fixes_improvements into development 2023-05-25 16:04:29 +02:00
Conversation 0 Commits 3 Files Changed 8 +17 -17
muellerr commented 2023-03-15 12:41:58 +01:00
Owner
Copy Link
No description provided.
muellerr added 1 commit 2023-03-15 12:41:59 +01:00
TCP/IP server fixes and improvements
Some checks failed
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
Details
c35a0a8541
mohr requested changes 2023-05-08 14:51:36 +02:00
src/fsfw/osal/common/TcpIpBase.cpp
@ -41,6 +41,7 @@ int TcpIpBase::closeSocket(socket_t socket) {
#elif defined(PLATFORM_UNIX)
return close(socket);
#endif
return -1;
mohr commented 2023-05-08 14:50:53 +02:00
Owner
Copy Link

#else would be cleaner, otherwise compiler will criticize double return. Same some lines below

`#else` would be cleaner, otherwise compiler will criticize double return. Same some lines below
mohr marked this conversation as resolved
muellerr added 1 commit 2023-05-25 15:00:46 +02:00
Merge remote-tracking branch 'upstream/development' into tcpip_server_fixes_improvements
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
e905288adc
muellerr added 1 commit 2023-05-25 15:01:59 +02:00
improvements
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
2714e588d7
mohr approved these changes 2023-05-25 15:51:50 +02:00
mohr merged commit f95c373076 into development 2023-05-25 16:04:29 +02:00
muellerr deleted branch tcpip_server_fixes_improvements 2023-05-26 09:47:55 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
mohr
Labels
Clear labels   
API Change

Changes the API, so Users need to adapted

  
Breaking API Change

Changes the API in a non backwards compatible way

  
bug

Something is not working

  
build

Issues related to the buildsystem, including CI

  
cosmetics

Small change most users won't notice

  
Documentation

Improvement of code documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
hotfix

Quick or important fix that is merged directly into master, causing a new revision

  
invalid

#worksforme

  
question

More information is needed

  
Refactor

Contains a refactoring of some code

  
Tests

Issues related to testing code

  
wontfix

This won't be fixed

No Label
API Change
Breaking API Change
bug
build
cosmetics
Documentation
duplicate
feature
help wanted
hotfix
invalid
question
Refactor
Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: fsfw/fsfw#747
No description provided.
Delete Branch "eive/fsfw:tcpip_server_fixes_improvements"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?