fsfw/fsfw
fsfw
/
fsfw
10
3
Fork 6
Code Issues 31 Pull Requests 4 Releases 10 Wiki Activity

TCP/IP server fixes and improvements #747

Merged
mohr merged 3 commits from eive/fsfw:tcpip_server_fixes_improvements into development 2023-05-25 16:04:29 +02:00
Conversation 0 Commits 3 Files Changed 8 +4 -2
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 2714e588d7 - Show all commits

6
src/fsfw/osal/common/TcpIpBase.cpp
View File

@ -40,8 +40,9 @@ int TcpIpBase::closeSocket(socket_t socket) {
return closesocket(socket);
#elif defined(PLATFORM_UNIX)
return close(socket);
#endif
#else
return -1;
mohr marked this conversation as resolved
mohr commented 2023-05-08 14:50:53 +02:00
Review
Copy Link

#else would be cleaner, otherwise compiler will criticize double return. Same some lines below

`#else` would be cleaner, otherwise compiler will criticize double return. Same some lines below
#endif
}
int TcpIpBase::getLastSocketError() {
@ -49,6 +50,7 @@ int TcpIpBase::getLastSocketError() {
return WSAGetLastError();
#elif defined(PLATFORM_UNIX)
return errno;
#endif
#else
return 0;
#endif
}