Fix for destination handler EOF handling #22

2026-09-14T11:31:42+02:00

muellerr commented

2026-09-14 11:31:42 +02:00

Destination handler now answers a retransmitted EOF PDU instead of silently reprocessing it.
Per CFDP 4.7.2 every EOF PDU must be acknowledged, and a retransmission means our previous ACK
was lost. It used to be handled like a brand new EOF regardless of transaction state, which
re-ran completion, re-sent a fresh Finished PDU, and restarted its positive ACK procedure on
every retransmission the sender made.

Destination handler now answers a retransmitted EOF PDU instead of silently reprocessing it. Per CFDP 4.7.2 every EOF PDU must be acknowledged, and a retransmission means our previous ACK was lost. It used to be handled like a brand new EOF regardless of transaction state, which re-ran completion, re-sent a fresh Finished PDU, and restarted its positive ACK procedure on every retransmission the sender made.

muellerr added 1 commit 2026-09-14 11:32:26 +02:00

Fix for destination handler EOF handling b74893f6c7

Destination handler now answers a retransmitted EOF PDU instead of silently reprocessing it.
Per CFDP 4.7.2 every EOF PDU must be acknowledged, and a retransmission means our previous ACK
was lost. It used to be handled like a brand new EOF regardless of transaction state, which
re-ran completion, re-sent a fresh Finished PDU, and restarted its positive ACK procedure on
every retransmission the sender made.

muellerr force-pushed fix/duplicate-eof-pdu-not-acknowledged from 51123c308c to b74893f6c7

2026-09-14 11:32:26 +02:00

Compare

muellerr merged commit e394591bb1 into main

2026-09-14 11:35:00 +02:00

muellerr deleted branch fix/duplicate-eof-pdu-not-acknowledged

2026-09-14 11:35:00 +02:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: rust/cfdp#22