rust/ops-sat-rs
5
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 4 Wiki Activity

camera_merge_main #7

Merged
lkoester merged 9 commits from camera_merge_main into main 2024-04-19 11:45:25 +02:00
Conversation 2 Commits 9 Files Changed 9 +310 -9
lkoester commented 2024-04-16 16:03:21 +02:00
Member
Copy Link
No description provided.
lkoester added 3 commits 2024-04-16 16:03:22 +02:00
lkoester requested review from muellerr 2024-04-16 16:03:32 +02:00
muellerr added 1 commit 2024-04-16 17:13:23 +02:00
muellerr added 1 commit 2024-04-16 17:13:52 +02:00
muellerr reviewed 2024-04-16 17:22:05 +02:00
src/handlers/camera.rs
@ -0,0 +86,4 @@
#[allow(dead_code)]
impl CameraPictureParameters {
pub fn default_single() -> Self {
muellerr commented 2024-04-16 17:20:37 +02:00
Owner
Copy Link

maybe those can be constants?

maybe those can be constants?
lkoester marked this conversation as resolved
src/handlers/camera.rs Outdated
@ -0,0 +137,4 @@
#[allow(dead_code)]
#[derive(new)]
pub struct IMS100BatchHandler<TmSender: EcssTmSender> {
muellerr commented 2024-04-16 17:21:19 +02:00
Owner
Copy Link

I don't think we need to abstract the TM Sender. It will always be a mpsc::Sender<PacketAsVec>

I don't think we need to abstract the TM Sender. It will always be a `mpsc::Sender<PacketAsVec>`
lkoester marked this conversation as resolved
lkoester added 2 commits 2024-04-17 10:40:05 +02:00
lkoester added 1 commit 2024-04-17 13:03:29 +02:00
muellerr reviewed 2024-04-17 16:41:08 +02:00
lkoester added 1 commit 2024-04-19 11:40:27 +02:00
lkoester merged commit 0da70ab5ac into main 2024-04-19 11:45:25 +02:00
muellerr added this to the v0.1.0 milestone 2024-04-24 20:45:34 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
muellerr
Labels
Clear labels
api
Non-Breaking API change
b-api
Breaking API change
bug
Something is not working
concepts
Conception and ideas for new features
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone v0.1.0
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: rust/ops-sat-rs#7
No description provided.
Delete Branch "camera_merge_main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?