Merge pull request 'Another CDS timestamp bugfix' (#8) from another_logic_fix_cds_stamp into main

Reviewed-on: #8

.github/workflows/ci.yml

@@ -20,6 +20,21 @@ jobs:
           command: check
           args: --release
 
+  msrv:
+    name: Check with MSRV
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - uses: actions-rs/toolchain@v1
+        with:
+          toolchain: 1.60.0
+          override: true
+          profile: minimal
+      - uses: actions-rs/cargo@v1
+        with:
+          command: check
+          args: --release
+
   cross-check:
     name: Check Cross
     runs-on: ubuntu-latest
@@ -58,6 +73,21 @@ jobs:
           command: fmt
           args: --all -- --check
 
+  check-doc:
+    name: Check Documentation Build
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - uses: actions-rs/toolchain@v1
+        with:
+          toolchain: nightly
+          override: true
+          profile: minimal
+      - uses: actions-rs/cargo@v1
+        with:
+          command: doc
+          args: --all-features
+
   clippy:
     name: Clippy
     runs-on: ubuntu-latest

CHANGELOG.md

@@ -8,6 +8,23 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 # [unreleased]
 
+# [v0.4.2] 14.01.2023
+
+## Fixed
+
+- CDS timestamp: Fixed another small logic error for stamp creation from the current
+  time with picosecond precision.
+  PR: https://egit.irs.uni-stuttgart.de/rust/spacepackets/pulls/8
+
+# [v0.4.1] 14.01.2023
+
+## Fixed
+
+- CDS timestamp: The conversion function from the current time were buggy
+  when specifying picoseconds precision, which could lead to overflow
+  multiplications and/or incorrect precision fields.
+  PR: https://egit.irs.uni-stuttgart.de/rust/spacepackets/pulls/7
+
 # [v0.4.0] 10.01.2023
 
 ## Fixed

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "spacepackets"
-version = "0.4.0"
+version = "0.4.2"
 edition = "2021"
 rust-version = "1.60"
 authors = ["Robin Mueller <muellerr@irs.uni-stuttgart.de>"]

automation/Dockerfile

@@ -10,6 +10,6 @@ ARG DEBIAN_FRONTEND=noninteractive
 # set CROSS_CONTAINER_IN_CONTAINER to inform `cross` that it is executed from within a container
 ENV CROSS_CONTAINER_IN_CONTAINER=true
 
-# TODO: installing cross is problematic, permission issues
-RUN rustup target add thumbv7em-none-eabihf armv7-unknown-linux-gnueabihf && \
+RUN rustup install nightly && \
+    rustup target add thumbv7em-none-eabihf armv7-unknown-linux-gnueabihf && \
     rustup component add rustfmt clippy

automation/Jenkinsfile

@@ -13,19 +13,29 @@ pipeline {
                 sh 'cargo clippy'
             }
         }
+        stage('Docs') {
+            steps {
+                sh 'cargo +nightly doc --all-features'
+            }
+        }
         stage('Rustfmt') {
             steps {
-                sh 'cargo fmt'
+                sh 'cargo fmt --all --check'
             }
         }
         stage('Test') {
             steps {
-                sh 'cargo test'
+                sh 'cargo test --all-features'
             }
         }
-        stage('Check') {
+        stage('Check with all features') {
             steps {
-                sh 'cargo check'
+                sh 'cargo check --all-features'
+            }
+        }
+        stage('Check with no features') {
+            steps {
+                sh 'cargo check --no-default-features'
             }
         }
         stage('Check Cross Embedded Bare Metal') {

src/time/ascii.rs

@@ -3,7 +3,10 @@
 //! See [chrono::DateTime::format] for a usage example of the generated
 //! [chrono::format::DelayedFormat] structs.
 #[cfg(feature = "alloc")]
-use chrono::{DateTime, Utc, format::{DelayedFormat, StrftimeItems}};
+use chrono::{
+    format::{DelayedFormat, StrftimeItems},
+    DateTime, Utc,
+};
 
 /// Tuple of format string and formatted size for time code A.
 ///

src/time/cds.rs

@@ -170,8 +170,8 @@ impl ConversionFromNow {
                     ));
                 }
                 SubmillisPrecision::Picoseconds(_) => {
-                    prec = Some(SubmillisPrecision::Microseconds(
-                        (now.subsec_nanos() * 1000) as u16,
+                    prec = Some(SubmillisPrecision::Picoseconds(
+                        (now.subsec_nanos() % 10_u32.pow(6)) * 1000,
                     ));
                 }
                 _ => (),