rust/zynq7000-rs
11
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 14 Wiki Activity

division by zero check to avoid panic #39

Merged
muellerr merged 1 commits from mohr/div_zero into main 2026-02-14 17:45:20 +01:00
Conversation 1 Commits 1 Files Changed 2
+6 -1
mohr commented 2026-02-11 12:47:26 +01:00
Owner
Copy Link
Copy Source

I'd like to compile this crate without any panics, the check will avoid one.

As GlobalTimerCounter::frequency_to_ticks also returns 0 in a failure path, it should be reasonable to return 0 here as well, instead of panicking.

I'd like to compile this crate without any panics, the check will avoid one. As `GlobalTimerCounter::frequency_to_ticks` also returns 0 in a failure path, it should be reasonable to return 0 here as well, instead of panicking.
mohr added 1 commit 2026-02-11 12:47:27 +01:00
division by zero check to avoid panic
ci / Check build (push) Has been cancelled
Details
ci / Check formatting (push) Has been cancelled
Details
ci / Check Documentation Build (push) Has been cancelled
Details
ci / Clippy (push) Has been cancelled
Details
ci / Check build (pull_request) Has been cancelled
Details
ci / Check formatting (pull_request) Has been cancelled
Details
ci / Check Documentation Build (pull_request) Has been cancelled
Details
ci / Clippy (pull_request) Has been cancelled
Details
1abbe7b9c9
mohr requested review from muellerr 2026-02-11 12:47:43 +01:00
muellerr approved these changes 2026-02-14 17:45:06 +01:00
muellerr merged commit 3b23e9be05 into main 2026-02-14 17:45:20 +01:00
muellerr deleted branch mohr/div_zero 2026-02-14 17:45:21 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
muellerr
Labels
Clear labels
api
Non-Breaking API change
 b-api
Breaking API change
 bug
Something is not working
 concepts
Conception and ideas for new features
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ahinkel (Andy Hinkel) jenkins_buildfix lkoester meggert (Marius Eggert) meierj (Jakob Meier) mhess mohr (Ulrich Mohr) muellerr (Robin Müller) nehlichp (Paul Nehlich) steinertm (Michael Steinert) tbaumgartl (Tobias Baumgartl)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: rust/zynq7000-rs#39
Delete Branch "mohr/div_zero"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?