eive/eive-obsw
eive/eive-obsw
13
4
Fork 0
Code Issues 4 Pull Requests 1 Releases 120 Wiki Activity

MTQ Scaling Bugfix #653

Merged
muellerr merged 3 commits from mtq-cmd-bugfix into v2.1.0-dev 2023-05-30 09:25:25 +02:00
Conversation 1 Commits 3 Files Changed 2 +3 -1
meggert commented 2023-05-26 14:03:27 +02:00
Owner
Copy Link

Currently the C abs is used, which is integer only and will truncate values. In case the required dipole is in below 1Am² but above 0.2Am², this will result in the dipole vector not being scaled down to the limit of 0.2Am². Instead the full dipole is passed on the the MTQ.
According to https://egit.irs.uni-stuttgart.de/redmine/attachments/download/319/ISIS.iMTQ.User%20Manual.v1.6.pdf p.34 the MTQ will still accept the command and scale it down accordingly on its own. Therefore, this bug should not change the performance of the MTQ. Nevertheless this bug is relevant for all ACS Ctrl modes, including detumble and safe mode, and the performance of the MTQ should be checked asap during LEOP.

Currently the C `abs` is used, which is integer only and will truncate values. In case the required dipole is in below 1Am² but above 0.2Am², this will result in the dipole vector not being scaled down to the limit of 0.2Am². Instead the full dipole is passed on the the MTQ. According to https://egit.irs.uni-stuttgart.de/redmine/attachments/download/319/ISIS.iMTQ.User%20Manual.v1.6.pdf p.34 the MTQ will still accept the command and scale it down accordingly on its own. Therefore, this bug should not change the performance of the MTQ. Nevertheless this bug is relevant for all ACS Ctrl modes, including detumble and safe mode, and the performance of the MTQ should be checked asap during LEOP.
meggert added the
bug
 label 2023-05-26 14:03:27 +02:00
meggert added 2 commits 2023-05-26 14:03:28 +02:00
changelog
All checks were successful
EIVE/eive-obsw/pipeline/head This commit looks good
Details
EIVE/eive-obsw/pipeline/pr-v2.1.0-dev This commit looks good
Details
a7c6cd017d
meggert requested review from muellerr 2023-05-26 14:04:21 +02:00
meggert commented 2023-05-26 20:33:28 +02:00
Author
Owner
Copy Link

Actually math.h seems to save my ass here. No clue why, cause I cant find any documentation for that shit. Anyhow, this bug doesn't seem to be part of the flight software. This merge is still needed, cause newer versions of this function do not include math.h anymore

Actually math.h seems to save my ass here. No clue why, cause I cant find any documentation for that shit. Anyhow, this bug doesn't seem to be part of the flight software. This merge is still needed, cause newer versions of this function do not include math.h anymore
meggert removed the
bug
 label 2023-05-28 12:26:15 +02:00
muellerr added 1 commit 2023-05-30 09:25:09 +02:00
Merge branch 'v2.1.0-dev' into mtq-cmd-bugfix
Some checks are pending
EIVE/eive-obsw/pipeline/pr-v2.1.0-dev Build queued...
Details
899b19f34f
muellerr approved these changes 2023-05-30 09:25:17 +02:00
muellerr merged commit fe34f69abe into v2.1.0-dev 2023-05-30 09:25:25 +02:00
muellerr deleted branch mtq-cmd-bugfix 2023-05-30 09:25:26 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
muellerr
Labels
Clear labels   
OPS TODO

Issues identified by OPS

  
api change

API change

  
breaking api change

API change which can break existing code

  
bug

Something is not working

  
documentation

Documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
OPS TODO
api change
breaking api change
bug
documentation
duplicate
feature
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: eive/eive-obsw#653
No description provided.
Delete Branch "mtq-cmd-bugfix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?