eive/eive-obsw
eive/eive-obsw
13
4
Fork 0
Code Issues 4 Pull Requests 1 Releases 120 Wiki Activity

Swap PL and PS I2C #725

Merged
muellerr merged 20 commits from swap-pl-ps-i2c into main 2023-07-06 15:05:54 +02:00
Conversation 0 Commits 20 Files Changed 31 +318 -170
muellerr commented 2023-07-03 17:17:08 +02:00
Owner
Copy Link
No description provided.
muellerr added 18 commits 2023-07-03 17:17:11 +02:00
swap i2cs
All checks were successful
EIVE/eive-obsw/pipeline/head This commit looks good
Details
1b919ceaec
Merge remote-tracking branch 'origin/v4.0.0-dev' into swap-pl-ps-i2c
All checks were successful
EIVE/eive-obsw/pipeline/head This commit looks good
Details
3e9accfa7b
tmp is back in the house
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
Details
d6dd943ebf
that should do the job
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
Details
727050520b
tmp1075 workssssss
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
Details
07bb293816
another tmp FDIR fix
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
Details
97268af555
changelog
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
Details
8f7d3dd815
create TCS CTRL TMP1075 PLCDU 1 se tdynamically
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
Details
df4e657ec3
Merge remote-tracking branch 'origin/main' into swap-pl-ps-i2c
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
Details
697a3e8577
changelog
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
Details
25c7058da5
that should do the job
Some checks failed
EIVE/eive-obsw/pipeline/head There was a failure building this commit
Details
d1b9608a14
FM should build again
Some checks failed
EIVE/eive-obsw/pipeline/head Build started...
Details
EIVE/eive-obsw/pipeline/pr-main There was a failure building this commit
Details
d8ab6abc49
muellerr added 1 commit 2023-07-03 17:32:41 +02:00
that should fix the host build
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
5c430212e7
muellerr changed title from WIP: Swap PL and PS I2C to Swap PL and PS I2C 2023-07-05 16:38:21 +02:00
muellerr requested review from meggert 2023-07-05 17:00:20 +02:00
muellerr added this to the v6.1.0 milestone 2023-07-05 17:00:44 +02:00
meggert approved these changes 2023-07-06 10:51:08 +02:00
CHANGELOG.md Outdated
@ -19,0 +19,4 @@
## Changed
- Swapped PL and PS I2C, BPX battery and MGT are connected to PS I2C now for firmware versions
above v4. However, this software version ins compatible to both v3 and v4 of the firmware.
meggert commented 2023-07-06 10:50:48 +02:00
Owner
Copy Link

You might wanna check for typos ins this sentence.

You might wanna check for typos ins this sentence.
muellerr commented 2023-07-06 14:28:58 +02:00
Author
Owner
Copy Link

there are now typos in there

there are now typos in there
muellerr commented 2023-07-06 14:33:48 +02:00
Author
Owner
Copy Link

all typos ins now fixed

all typos ins now fixed
meggert marked this conversation as resolved
bsp_q7s/scheduling.cpp Outdated
@ -0,0 +540,4 @@
tmpSchedConf.schedulePlPcduDev1 = true;
tmpSchedConf.scheduleIfBoardDev = true;
#endif
result = pst::pstProgammableLogicI2c(tmpSchedConf, i2cPst);
meggert commented 2023-07-06 10:43:33 +02:00
Owner
Copy Link

Naming is kind of confusing, if we are trying to keep this backwad compatible. Maybe pstTmpI2c might be better here.

Naming is kind of confusing, if we are trying to keep this backwad compatible. Maybe `pstTmpI2c` might be better here.
muellerr commented 2023-07-06 14:33:35 +02:00
Author
Owner
Copy Link

good catch

good catch
meggert marked this conversation as resolved
mission/system/tcs/TmpDevFdir.cpp Outdated
@ -29,7 +29,9 @@ ReturnValue_t TmpDevFdir::eventReceived(EventMessage* event) {
case DeviceHandlerIF::DEVICE_BUILDING_COMMAND_FAILED:
// These faults all mean that there were stupid replies from a device.
// With now way to do a recovery, set the device to faulty immediately.
meggert commented 2023-07-06 10:48:32 +02:00
Owner
Copy Link

Now way you did this

Now way you did this
muellerr commented 2023-07-06 14:28:39 +02:00
Author
Owner
Copy Link

now way someone is actually reading the comments

now way someone is actually reading the comments
meggert marked this conversation as resolved
muellerr added 1 commit 2023-07-06 14:34:26 +02:00
Merge remote-tracking branch 'origin/main' into swap-pl-ps-i2c
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
bda2ba79bf 
make marius extremely happy
muellerr merged commit ee4285075a into main 2023-07-06 15:05:54 +02:00
muellerr deleted branch swap-pl-ps-i2c 2023-07-06 15:05:55 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
meggert
Labels
Clear labels   
OPS TODO

Issues identified by OPS

  
api change

API change

  
breaking api change

API change which can break existing code

  
bug

Something is not working

  
documentation

Documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
OPS TODO
api change
breaking api change
bug
documentation
duplicate
feature
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
v6.1.0
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: eive/eive-obsw#725
No description provided.
Delete Branch "swap-pl-ps-i2c"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?