eive/eive-obsw
eive
/
eive-obsw
12
3
Fork 0
Code Issues 3 Pull Requests 1 Releases 117 Wiki Activity

Fixes for RW Commanding #852

Merged
meggert merged 11 commits from cmd-rw-fix into main 2024-01-29 14:13:33 +01:00
Conversation 1 Commits 11 Files Changed 6 +53 -48
meggert commented 2024-01-26 15:45:46 +01:00
Owner
Copy Link
No description provided.
meggert added the
bug
 label 2024-01-26 15:45:46 +01:00
meggert added 1 commit 2024-01-26 15:45:46 +01:00
EIVE/eive-obsw/pipeline/head Build queued... Details
EIVE/eive-obsw/pipeline/pr-main This commit looks good Details
26f69d611e never try sending invalid command
meggert added this to the v7.6.0 milestone 2024-01-26 15:45:51 +01:00
meggert added 1 commit 2024-01-27 10:33:46 +01:00
EIVE/eive-obsw/pipeline/pr-main This commit looks good Details
5f388d53a6 reset RW cmds to 0 if they are not used anymore
meggert added 1 commit 2024-01-27 10:35:27 +01:00
EIVE/eive-obsw/pipeline/pr-main This commit looks good Details
6cf746463b is of type int
meggert added 1 commit 2024-01-27 10:37:34 +01:00
EIVE/eive-obsw/pipeline/pr-main This commit looks good Details
315365921e changelog
meggert added 2 commits 2024-01-27 10:47:36 +01:00
EIVE/eive-obsw/pipeline/pr-main This commit looks good Details
c4297975ff changelog
meggert added 1 commit 2024-01-27 11:30:31 +01:00
EIVE/eive-obsw/pipeline/pr-main This commit looks good Details
398ddd1a3f typo
meggert added 2 commits 2024-01-27 11:33:31 +01:00
EIVE/eive-obsw/pipeline/pr-main This commit looks good Details
060217fbb4 changelog
meggert changed title from WIP: Antistiction Fix for Error RW to WIP: Fixes for RW Commanding 2024-01-27 13:06:33 +01:00
meggert added 1 commit 2024-01-29 10:35:50 +01:00
EIVE/eive-obsw/pipeline/pr-main This commit looks good Details
8dbbb7b9ec Merge branch 'main' into cmd-rw-fix
meggert added 1 commit 2024-01-29 10:53:10 +01:00
EIVE/eive-obsw/pipeline/pr-main This commit looks good Details
62c11798e5 Merge branch 'main' into cmd-rw-fix
meggert requested review from muellerr 2024-01-29 10:54:19 +01:00
meggert changed title from WIP: Fixes for RW Commanding to Fixes for RW Commanding 2024-01-29 10:54:23 +01:00
muellerr approved these changes 2024-01-29 12:02:52 +01:00
muellerr commented 2024-01-29 12:03:16 +01:00
Owner
Copy Link

Does this require re-running the generators?

Does this require re-running the generators?
muellerr reviewed 2024-01-29 12:04:31 +01:00
mission/acs/RwHandler.h
@ -59,6 +59,7 @@ class RwHandler : public DeviceHandlerBase {
LocalPoolDataSetBase* getDataSetHandle(sid_t sid) override;
private:
static const uint8_t INTERFACE_ID = CLASS_ID::RW_HANDLER;
muellerr commented 2024-01-29 12:04:31 +01:00
Owner
Copy Link

oooopsie

oooopsie
muellerr approved these changes 2024-01-29 12:04:45 +01:00
meggert merged commit d065f6257e into main 2024-01-29 14:13:33 +01:00
meggert deleted branch cmd-rw-fix 2024-01-29 14:13:33 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
muellerr
Labels
Clear labels   
OPS TODO

Issues identified by OPS

  
api change

API change

  
breaking api change

API change which can break existing code

  
bug

Something is not working

  
documentation

Documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
OPS TODO
api change
breaking api change
bug
documentation
duplicate
feature
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
v7.6.0
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: eive/eive-obsw#852
No description provided.
Delete Branch "cmd-rw-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?