eive/eive-obsw
eive/eive-obsw
12
4
Fork 0
Code Issues 4 Pull Requests 1 Releases 120 Wiki Activity

Relax SUS FDIR #677

Merged
muellerr merged 17 commits from relax-sus-fdir into main 2023-09-12 10:16:07 +02:00
Conversation 0 Commits 17 Files Changed 20 +103 -38
muellerr commented 2023-06-13 07:50:14 +02:00
Owner
Copy Link

TMTC PR: eive/eive-tmtc#205

TMTC PR: https://egit.irs.uni-stuttgart.de/eive/eive-tmtc/pulls/205
muellerr added 2 commits 2023-06-13 07:50:16 +02:00
Merge remote-tracking branch 'origin/main' into relax-sus-fdir
Some checks are pending
EIVE/eive-obsw/pipeline/head Build started...
Details
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
5e79293d38
muellerr added this to the v3.1.0 milestone 2023-06-13 07:51:25 +02:00
muellerr added 1 commit 2023-06-13 07:54:54 +02:00
comment
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
b2b6e2e797
muellerr requested review from meggert 2023-06-13 07:56:49 +02:00
muellerr changed title from Relax SUS FDIR to WIP: Relax SUS FDIR 2023-06-13 07:56:54 +02:00
muellerr added 1 commit 2023-06-13 07:57:26 +02:00
changelog typo
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
0788a3d551
muellerr added 1 commit 2023-06-13 07:58:38 +02:00
removed old comment
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
8062c5edad
muellerr added 1 commit 2023-06-14 03:41:28 +02:00
Merge remote-tracking branch 'origin/main' into relax-sus-fdir
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
2a4d86de54
muellerr changed title from WIP: Relax SUS FDIR to Relax SUS FDIR 2023-06-14 03:41:39 +02:00
muellerr added 1 commit 2023-06-14 03:43:30 +02:00
Merge remote-tracking branch 'origin/main' into relax-sus-fdir
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
a023fe2c7d
muellerr modified the milestone from v3.1.0 to v3.2.0 2023-06-15 19:18:49 +02:00
muellerr modified the milestone from v3.2.0 to v4.1.0 2023-06-22 18:35:47 +02:00
muellerr modified the milestone from v4.1.0 to v5.1.0 2023-06-28 13:37:32 +02:00
muellerr removed this from the v5.1.0 milestone 2023-06-30 10:47:51 +02:00
muellerr added 1 commit 2023-08-03 13:37:38 +02:00
Merge remote-tracking branch 'origin/main' into relax-sus-fdir
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
05fbff2e6d
muellerr added 1 commit 2023-09-07 15:42:05 +02:00
Merge remote-tracking branch 'origin/main' into relax-sus-fdir
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
f9f6ac27e8
muellerr added 1 commit 2023-09-07 16:03:44 +02:00
that should get the job done
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
58961efb3f
muellerr added 1 commit 2023-09-07 16:06:02 +02:00
add recovery handling
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
c51fbb9074
muellerr added 1 commit 2023-09-07 16:08:09 +02:00
some structure clean up
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
5a1b2470f0
muellerr added 1 commit 2023-09-07 16:09:54 +02:00
another small bugfix
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
0337104173
muellerr added this to the v6.5.0 milestone 2023-09-07 16:10:54 +02:00
meggert reviewed 2023-09-11 15:08:34 +02:00
mission/acs/SusHandler.cpp
@ -95,0 +111,4 @@
}
if (invalidMsgCounter > 0) {
triggerEvent(TEMPERATURE_ALL_ONES_RECOVERY, invalidMsgCounter);
invalidMsgCounter = 0;
meggert commented 2023-09-11 15:06:10 +02:00
Owner
Copy Link

maybe decrement here instead of resetting the counter?

maybe decrement here instead of resetting the counter?
muellerr commented 2023-09-11 15:35:18 +02:00
Author
Owner
Copy Link

Then I'd change the event handling, not sure what would be best here.. Otherwise it could be a lot of events.

Then I'd change the event handling, not sure what would be best here.. Otherwise it could be a lot of events.
meggert commented 2023-09-11 15:53:56 +02:00
Owner
Copy Link

not sure either. your call

not sure either. your call
mission/acs/SusHandler.h Outdated
@ -19,0 +19,4 @@
//! [EXPORT] : [COMMENT] Detected invalid values, starting invalid message counting
static constexpr Event TEMPERATURE_ALL_ONES_START =
event::makeEvent(SUBSYSTEM_ID, 0, severity::LOW);
meggert commented 2023-09-11 15:02:08 +02:00
Owner
Copy Link

prob medium severity

prob medium severity
muellerr marked this conversation as resolved
mission/acs/SusHandler.h Outdated
@ -19,0 +23,4 @@
//! [EXPORT] : [COMMENT] Detected valid values again, resetting invalid message counter.
//! P1: Invalid message counter.
static constexpr Event TEMPERATURE_ALL_ONES_RECOVERY =
event::makeEvent(SUBSYSTEM_ID, 1, severity::LOW);
meggert commented 2023-09-11 14:54:09 +02:00
Owner
Copy Link

prob info event

prob info event
muellerr marked this conversation as resolved
muellerr added 1 commit 2023-09-11 15:39:29 +02:00
adapt event severities
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
e26338e4cb
meggert approved these changes 2023-09-11 15:54:14 +02:00
muellerr added 1 commit 2023-09-11 16:11:04 +02:00
Merge branch 'main' into relax-sus-fdir
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
aa4bf5f293
muellerr added 1 commit 2023-09-12 10:07:08 +02:00
update gen files
All checks were successful
EIVE/eive-obsw/pipeline/pr-main This commit looks good
Details
fc23438e5d
muellerr added 1 commit 2023-09-12 10:08:32 +02:00
bump tmtc
Some checks are pending
EIVE/eive-obsw/pipeline/pr-main Build started...
Details
3cb9cd124d
muellerr merged commit 2e83627139 into main 2023-09-12 10:16:07 +02:00
muellerr deleted branch relax-sus-fdir 2023-09-12 10:16:07 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
meggert
Labels
Clear labels   
OPS TODO

Issues identified by OPS

  
api change

API change

  
breaking api change

API change which can break existing code

  
bug

Something is not working

  
documentation

Documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
OPS TODO
api change
breaking api change
bug
documentation
duplicate
feature
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
v6.5.0
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: eive/eive-obsw#677
No description provided.
Delete Branch "relax-sus-fdir"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?