eive/eive-obsw
eive/eive-obsw
13
4
Fork 0
Code Issues4 Pull Requests1 Releases121 Wiki Activity

Relax SUS FDIR #677

Merged
muellerr merged 17 commits from relax-sus-fdir into main 2023-09-12 10:16:07 +02:00
Conversation 2 Commits 17 Files Changed 20 +103 -38
muellerr commented 2023-06-13 07:50:14 +02:00
Owner

TMTC PR:

TMTC PR: https://egit.irs.uni-stuttgart.de/eive/eive-tmtc/pulls/205
muellerr added 2 commits 2023-06-13 07:50:16 +02:00
muellerr added this to the v3.1.0 milestone 2023-06-13 07:51:25 +02:00
muellerr added 1 commit 2023-06-13 07:54:54 +02:00
muellerr requested review from meggert 2023-06-13 07:56:49 +02:00
muellerr changed title from Relax SUS FDIR to WIP: Relax SUS FDIR 2023-06-13 07:56:54 +02:00
muellerr added 1 commit 2023-06-13 07:57:26 +02:00
muellerr added 1 commit 2023-06-13 07:58:38 +02:00
muellerr added 1 commit 2023-06-14 03:41:28 +02:00
muellerr changed title from WIP: Relax SUS FDIR to Relax SUS FDIR 2023-06-14 03:41:39 +02:00
muellerr added 1 commit 2023-06-14 03:43:30 +02:00
muellerr modified the milestone from v3.1.0 to v3.2.0 2023-06-15 19:18:49 +02:00
muellerr modified the milestone from v3.2.0 to v4.1.0 2023-06-22 18:35:47 +02:00
muellerr modified the milestone from v4.1.0 to v5.1.0 2023-06-28 13:37:32 +02:00
muellerr removed this from the v5.1.0 milestone 2023-06-30 10:47:51 +02:00
muellerr added 1 commit 2023-08-03 13:37:38 +02:00
muellerr added 1 commit 2023-09-07 15:42:05 +02:00
muellerr added 1 commit 2023-09-07 16:03:44 +02:00
muellerr added 1 commit 2023-09-07 16:06:02 +02:00
muellerr added 1 commit 2023-09-07 16:08:09 +02:00
muellerr added 1 commit 2023-09-07 16:09:54 +02:00
muellerr added this to the v6.5.0 milestone 2023-09-07 16:10:54 +02:00
meggert reviewed 2023-09-11 15:08:34 +02:00
mission/acs/SusHandler.cpp
@ -95,0 +111,4 @@
}
if (invalidMsgCounter > 0) {
triggerEvent(TEMPERATURE_ALL_ONES_RECOVERY, invalidMsgCounter);
invalidMsgCounter = 0;
meggert commented 2023-09-11 15:06:10 +02:00
Owner

maybe decrement here instead of resetting the counter?

maybe decrement here instead of resetting the counter?
muellerr commented 2023-09-11 15:35:18 +02:00
Author
Owner

Then I'd change the event handling, not sure what would be best here.. Otherwise it could be a lot of events.

Then I'd change the event handling, not sure what would be best here.. Otherwise it could be a lot of events.
meggert commented 2023-09-11 15:53:56 +02:00
Owner

not sure either. your call

not sure either. your call
mission/acs/SusHandler.h Outdated
@ -19,0 +19,4 @@
//! [EXPORT] : [COMMENT] Detected invalid values, starting invalid message counting
static constexpr Event TEMPERATURE_ALL_ONES_START =
event::makeEvent(SUBSYSTEM_ID, 0, severity::LOW);
meggert commented 2023-09-11 15:02:08 +02:00
Owner

prob medium severity

prob medium severity
muellerr marked this conversation as resolved
mission/acs/SusHandler.h Outdated
@ -19,0 +23,4 @@
//! [EXPORT] : [COMMENT] Detected valid values again, resetting invalid message counter.
//! P1: Invalid message counter.
static constexpr Event TEMPERATURE_ALL_ONES_RECOVERY =
event::makeEvent(SUBSYSTEM_ID, 1, severity::LOW);
meggert commented 2023-09-11 14:54:09 +02:00
Owner

prob info event

prob info event
muellerr marked this conversation as resolved
muellerr added 1 commit 2023-09-11 15:39:29 +02:00
meggert approved these changes 2023-09-11 15:54:14 +02:00
muellerr added 1 commit 2023-09-11 16:11:04 +02:00
muellerr added 1 commit 2023-09-12 10:07:08 +02:00
muellerr added 1 commit 2023-09-12 10:08:32 +02:00
muellerr merged commit 2e83627139 into main 2023-09-12 10:16:07 +02:00
muellerr deleted branch relax-sus-fdir 2023-09-12 10:16:07 +02:00
Sign in to join this conversation.
No Reviewers
meggert
No Label
No Milestone v6.5.0
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: eive/eive-obsw#677
No description provided.
Delete Branch "relax-sus-fdir"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?