eive/fsfw
eive/fsfw
15
1
Fork 0
forked from fsfw/fsfw
Code Issues Pull Requests Releases 1 Wiki Activity

max value calc fix #153

Merged
muellerr merged 3 commits from max-value-fix-v2 into develop 2023-06-20 18:20:01 +02:00
Conversation 1 Commits 3 Files Changed 1 +18 -6
muellerr commented 2023-06-19 17:37:24 +02:00
Owner
Copy Link
No description provided.
muellerr added 1 commit 2023-06-19 17:37:26 +02:00
mohr commented 2023-06-20 11:53:11 +02:00
Owner
Copy Link

nice catch @meggert !

Re: Off-Band Discussion with @muellerr: I think index needs to be checked for nullptr (and my younger self needs a stern talking to for writing uint8_t *index = 0 without this check), as the interface presents nullptr as a valid choice.

Regarding checking vector and size, the whole module does not do nullptr/size checks. I am not sure whether to keep it that way or refactor it to checking and returning Returnvalue_t.

I think the idea in the first place was to keep the interface slim, to not bloat math code, which is a debatable argument...

nice catch @meggert ! Re: Off-Band Discussion with @muellerr: I think `index` needs to be checked for `nullptr` (and my younger self needs a stern talking to for writing `uint8_t *index = 0` without this check), as the interface presents `nullptr` as a valid choice. Regarding checking `vector` and `size`, the whole module does not do `nullptr`/size checks. I am not sure whether to keep it that way or refactor it to checking and returning `Returnvalue_t`. I think the idea in the first place was to keep the interface slim, to not bloat math code, which is a debatable argument...
mohr added 1 commit 2023-06-20 11:54:22 +02:00
muellerr added 1 commit 2023-06-20 18:19:21 +02:00
muellerr merged commit 268c2e87c9 into develop 2023-06-20 18:20:01 +02:00
muellerr deleted branch max-value-fix-v2 2023-06-20 18:20:02 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
api change
API change
breaking api change
API change which can break existing code
bug
Something is not working
documentation
Documentation
duplicate
This issue or pull request already exists
feature
New feature
help wanted
Need some help
invalid
Something is wrong
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: eive/fsfw#153
No description provided.
Delete Branch "max-value-fix-v2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?