max value calc fix #153

muellerr · 2023-06-19T17:37:24+02:00

muellerr commented

2023-06-19 17:37:24 +02:00

No description provided.

muellerr added 1 commit 2023-06-19 17:37:26 +02:00

f80c5980ea max value calc fix

mohr commented

2023-06-20 11:53:11 +02:00

nice catch @meggert !

Re: Off-Band Discussion with @muellerr: I think index needs to be checked for nullptr (and my younger self needs a stern talking to for writing uint8_t *index = 0 without this check), as the interface presents nullptr as a valid choice.

Regarding checking vector and size, the whole module does not do nullptr/size checks. I am not sure whether to keep it that way or refactor it to checking and returning Returnvalue_t.

I think the idea in the first place was to keep the interface slim, to not bloat math code, which is a debatable argument...

nice catch @meggert ! Re: Off-Band Discussion with @muellerr: I think `index` needs to be checked for `nullptr` (and my younger self needs a stern talking to for writing `uint8_t *index = 0` without this check), as the interface presents `nullptr` as a valid choice. Regarding checking `vector` and `size`, the whole module does not do `nullptr`/size checks. I am not sure whether to keep it that way or refactor it to checking and returning `Returnvalue_t`. I think the idea in the first place was to keep the interface slim, to not bloat math code, which is a debatable argument...

mohr added 1 commit 2023-06-20 11:54:22 +02:00

c7037d417a nullptr check for optional argument

muellerr added 1 commit 2023-06-20 18:19:21 +02:00

87f94a252f Merge branch 'develop' into max-value-fix-v2

muellerr merged commit 268c2e87c9 into develop

2023-06-20 18:20:01 +02:00

muellerr referenced this issue from a commit

2023-06-20 18:20:01 +02:00

Merge pull request 'max value calc fix' (#153) from max-value-fix-v2 into develop

muellerr deleted branch max-value-fix-v2

2023-06-20 18:20:02 +02:00

Sign in to join this conversation.