fdir update #158

muellerr · 2020-08-08T13:32:11+02:00

muellerr commented

2020-08-08 13:32:11 +02:00

General improvements.
Using objects::NO_OBJECT instead of 0 and MessageQueueIF::NO_QUEUE instead of 0.

General improvements. Using objects::NO_OBJECT instead of 0 and MessageQueueIF::NO_QUEUE instead of 0.

muellerr added the

feature

label 2020-08-08 13:32:11 +02:00

gaisser reviewed 2020-08-13 19:35:15 +02:00

devicehandlers/DeviceHandlerFailureIsolation.h Outdated

						
				@ -31,2 +31,4 @@

					bool hasPowerConfirmation = false;

					MessageQueueId_t powerConfirmation;

					static object_id_t powerConfirmationId;

					// TODO: Are those hardcoded value? How can they be changed.

gaisser commented

2020-08-13 19:35:15 +02:00

These values are used to initialize the defaults. Can be overwritten by child implementations.

muellerr commented

2020-08-19 19:27:57 +02:00

ahhh that makes sense. maybe put DEFAULT_ in name to make it more explicit?

gaisser reviewed 2020-08-25 13:54:15 +02:00

devicehandlers/DeviceHandlerFailureIsolation.cpp Outdated

						
				@ -166,1 +172,3 @@

						return RETURN_FAILED;

					if (power != nullptr) {

						powerConfirmation = power->getEventReceptionQueue();

						hasPowerConfirmation = true;