fsfw/fsfw
11
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

fdir update #158

Merged
gaisser merged 6 commits from KSat/fsfw:mueller/devices/FDIR into master 2020-09-01 12:21:51 +02:00
Conversation 2 Commits 6 Files Changed 4 +81 -45
muellerr commented 2020-08-08 13:32:11 +02:00
Owner
Copy Link

General improvements.
Using objects::NO_OBJECT instead of 0 and MessageQueueIF::NO_QUEUE instead of 0.

General improvements. Using objects::NO_OBJECT instead of 0 and MessageQueueIF::NO_QUEUE instead of 0.
muellerr added the
feature
 label 2020-08-08 13:32:11 +02:00
gaisser reviewed 2020-08-13 19:35:15 +02:00
devicehandlers/DeviceHandlerFailureIsolation.h Outdated
@@ -31,2 +31,4 @@
bool hasPowerConfirmation = false;
MessageQueueId_t powerConfirmation;
static object_id_t powerConfirmationId;
// TODO: Are those hardcoded value? How can they be changed.
gaisser commented 2020-08-13 19:35:15 +02:00
Owner
Copy Link

These values are used to initialize the defaults. Can be overwritten by child implementations.

These values are used to initialize the defaults. Can be overwritten by child implementations.
muellerr commented 2020-08-19 19:27:57 +02:00
Author
Owner
Copy Link

ahhh that makes sense. maybe put DEFAULT_ in name to make it more explicit?

ahhh that makes sense. maybe put DEFAULT_ in name to make it more explicit?
gaisser reviewed 2020-08-25 13:54:15 +02:00
devicehandlers/DeviceHandlerFailureIsolation.cpp Outdated
@@ -166,1 +172,3 @@
return RETURN_FAILED;
if (power != nullptr) {
powerConfirmation = power->getEventReceptionQueue();
hasPowerConfirmation = true;
gaisser commented 2020-08-25 13:54:15 +02:00
Owner
Copy Link

Can we avoid the aditional bool by checking powerConfirmation != NO_QUEUE?

Can we avoid the aditional bool by checking powerConfirmation != NO_QUEUE?
muellerr commented 2020-08-27 20:01:52 +02:00
Author
Owner
Copy Link

Yeah it's better like that.

Yeah it's better like that.
gaisser merged commit e77c294360 into master 2020-09-01 12:21:49 +02:00
gaisser deleted branch mueller/devices/FDIR 2020-09-01 12:21:54 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
API Change
Changes the API, so Users need to adapted
Breaking API Change
Changes the API in a non backwards compatible way
bug
Something is not working
build
Issues related to the buildsystem, including CI
cosmetics
Small change most users won't notice
Documentation
Improvement of code documentation
duplicate
This issue or pull request already exists
feature
New feature
help wanted
Need some help
hotfix
Quick or important fix that is merged directly into master, causing a new revision
invalid
#worksforme
question
More information is needed
Refactor
Contains a refactoring of some code
Tests
Issues related to testing code
wontfix
This won't be fixed
No Label
feature
Milestone
No items
No Milestone
Assignees
Clear assignees
ahinkel dwoodward gaisser hanke jenkins_buildfix lrajer meierj mohr muellerr taheran tbaumgartl
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fsfw/fsfw#158
No description provided.
Delete Branch "KSat/fsfw:mueller/devices/FDIR"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?