Thoughts on DHB PowerSwitchIF #20

New Issue

gaisser · 2020-03-24T15:29:30+01:00

gaisser commented

2020-03-24 15:29:30 +01:00

Think about making the PowerSwitchIF setting optional. Devices without switches will call it even though the have no switch. The example is another software on the SOURCE PLOC. In every other aspect it behaves like a physical device but has no switches.
Furthermore, DHB uses a static to initialize the powerSwitcher at the moment. This has some advantages in comfort but duplicates information as every device only uses the static information for initializing its internal pointer. So, theoretical you are able to set different PowerSwitchIFs for different DHBs but in reality the init value is always taken from the static objectId.

- Think about making the PowerSwitchIF setting optional. Devices without switches will call it even though the have no switch. The example is another software on the SOURCE PLOC. In every other aspect it behaves like a physical device but has no switches. - Furthermore, DHB uses a static to initialize the powerSwitcher at the moment. This has some advantages in comfort but duplicates information as every device only uses the static information for initializing its internal pointer. So, theoretical you are able to set different PowerSwitchIFs for different DHBs but in reality the init value is always taken from the static objectId.

gaisser added the

feature

label 2020-03-24 15:29:30 +01:00

taheran commented

2020-03-26 11:21:24 +01:00

This is quite useful for ESBO, we have devices that we do not control their power switch, and interfaces that behave as a device but have no switches.

mohr commented

2020-03-31 11:59:46 +02:00

Proposed Solution as of 31.03.20:

in initialize(): Check if the static Id is NO_OBJECT. If so, do not initialze powerSwitcher
Change default implementation of getSwitches() to return NO_SWITCH
Access to powerSwitcher is protected by a check of commandSwitch, so in default implementation it is not dereferenced
Remove the setDeviceSwitch constructor parameter from DHB, let the child implementation handle it
Make powerSwitcher private to dissuade users from dereferencing it
Make commandSwitch protected
Keep powerSwitcher a member of DHB, no better solution found

Proposed Solution as of 31.03.20: - in [initialize()](https://egit.irs.uni-stuttgart.de/fsfw/fsfw/src/branch/master/devicehandlers/DeviceHandlerBase.cpp#L614): Check if the static Id is [NO_OBJECT](https://egit.irs.uni-stuttgart.de/fsfw/fsfw/src/branch/master/objectmanager/frameworkObjects.h#L15). If so, do not initialze [powerSwitcher](https://egit.irs.uni-stuttgart.de/fsfw/fsfw/src/branch/master/devicehandlers/DeviceHandlerBase.h#L225) - Change default implementation of [getSwitches()](https://egit.irs.uni-stuttgart.de/fsfw/fsfw/src/branch/master/devicehandlers/DeviceHandlerBase.cpp#L794) to return [NO_SWITCH](https://egit.irs.uni-stuttgart.de/fsfw/fsfw/src/branch/master/devicehandlers/DeviceHandlerBase.h#L150) - Access to [powerSwitcher](https://egit.irs.uni-stuttgart.de/fsfw/fsfw/src/branch/master/devicehandlers/DeviceHandlerBase.h#L225) is protected by a check of [commandSwitch](https://egit.irs.uni-stuttgart.de/fsfw/fsfw/src/branch/master/devicehandlers/DeviceHandlerBase.h#L1006), so in default implementation it is not dereferenced - Remove the [setDeviceSwitch](https://egit.irs.uni-stuttgart.de/fsfw/fsfw/src/branch/master/devicehandlers/DeviceHandlerBase.h#L74) constructor parameter from DHB, let the child implementation handle it - Make [powerSwitcher](https://egit.irs.uni-stuttgart.de/fsfw/fsfw/src/branch/master/devicehandlers/DeviceHandlerBase.h#L225) private to dissuade users from dereferencing it - Make [commandSwitch](https://egit.irs.uni-stuttgart.de/fsfw/fsfw/src/branch/master/devicehandlers/DeviceHandlerBase.h#L1006) protected - Keep [powerSwitcher](https://egit.irs.uni-stuttgart.de/fsfw/fsfw/src/branch/master/devicehandlers/DeviceHandlerBase.h#L225) a member of DHB, no better solution found

muellerr referenced this issue

2020-05-28 15:49:42 +02:00

DHB - PowerSwitcherIF - first changes #88

muellerr referenced this issue

2020-05-28 15:56:26 +02:00

DHB - PowerSwitcherIF - first changes #88

~~muellerr referenced this issue 2020-07-16 12:53:42 +02:00~~

DHB Update #144

gaisser referenced this issue

2020-09-01 11:49:36 +02:00

DHB Update #144

gaisser commented