DHB - PowerSwitcherIF - first changes #88

New Issue

muellerr · 2020-05-28T15:45:19+02:00

muellerr commented

2020-05-28 15:45:19 +02:00

I am changing DHB again to test distributed pools too and the issue from #20 came up again when I disabled most device handlers for testing: I need to implement a PowerSwitcherIF (so ,an empty PCDU handler basically), or the DH initialization will fail.

I might implement some suggestions of #20 .

I am changing DHB again to test distributed pools too and the issue from #20 came up again when I disabled most device handlers for testing: I need to implement a PowerSwitcherIF (so ,an empty PCDU handler basically), or the DH initialization will fail. I might implement some suggestions of #20 .

muellerr changed title from ~~Better error value for missing powerConfirmationId object~~ to Better error value for missing PowerSwitcherIF

2020-05-28 15:49:13 +02:00

muellerr commented

2020-05-28 15:49:42 +02:00

This is related to #20 .
I might implement parts of the suggestions to make the switch optional as I am changing parts of the DHB for the new distributed datapools anyway (I disabled all but one device handler for easy of testing and the initialization failed, of course)

Point 1 and Point 2 would be a good beginning.

In fact, for every single device handler implemented so far I implemented the getSwitches function() just to return NO_SWITCHES and write a comment above to replace this as soon the PCDU is implemented..

This is related to #20 . I might implement parts of the suggestions to make the switch optional as I am changing parts of the DHB for the new distributed datapools anyway (I disabled all but one device handler for easy of testing and the initialization failed, of course) Point 1 and Point 2 would be a good beginning. In fact, for every single device handler implemented so far I implemented the getSwitches function() just to return NO_SWITCHES and write a comment above to replace this as soon the PCDU is implemented..

muellerr added the

feature

label 2020-05-28 15:52:15 +02:00

muellerr changed title from ~~Better error value for missing PowerSwitcherIF~~ to DHB - PowerSwitcherIF - first changes

2020-05-28 15:54:54 +02:00

muellerr added the

question

label 2020-05-28 17:14:51 +02:00

muellerr commented

2020-05-28 17:25:09 +02:00

I check powerSwitcher for nullptr now at various places in the state machine and related functions which use the powerSwitcher pointer (hopefully didnt forget anyhting..) and tested a dummy device handler with an uninitialized powerSwitcher. (basic DH command, Action command and of course mode command tests) maybe there is a better solution but it propaply involves packaging the powerSwitcher functionality into a helper or the state machine into a separate class.