fsfw/fsfw
fsfw
/
fsfw
10
3
Fork 6
Code Issues 31 Pull Requests 4 Releases 10 Wiki Activity

mueller_TmTcBridge_cherryPicked #40

Merged
muellerr merged 30 commits from KSat/fsfw:mueller_TmTcBridge_cherryPicked into master 2020-07-07 12:06:47 +02:00
Conversation 3 Commits 30 Files Changed 2 +344
muellerr commented 2020-04-18 13:41:41 +02:00
Owner
Copy Link

This fixes #39 .
New generic TMTC bridge, which handles FSFW related tasks.

This fixes #39 . New generic TMTC bridge, which handles FSFW related tasks.
mohr requested changes 2020-04-20 14:08:15 +02:00
mohr left a comment
Owner
Copy Link

Added some comments which should also be reflected in our coding guidelines

Added some comments which should also be reflected in our coding guidelines
tmtcservices/TmTcBridge.cpp Outdated
@ -0,0 +3,4 @@
*
* @date 26.12.2019
* @author R. Mueller
*/
mohr commented 2020-04-20 10:53:09 +02:00
Owner
Copy Link

Please don't add file headers, we have git and a file system for this information

Please don't add file headers, we have git and a file system for this information
muellerr commented 2020-04-21 14:21:48 +02:00
Author
Owner
Copy Link

Removed

Removed
tmtcservices/TmTcBridge.h Outdated
@ -0,0 +36,4 @@
* other member of the class can be used.
* @return Currently, the return value is ignored.
*/
virtual ReturnValue_t performOperation(uint8_t operationCode = 0);
mohr commented 2020-04-20 11:15:44 +02:00
Owner
Copy Link

I recently learned that the override keyword would be useful here ;)

I recently learned that the override keyword would be useful here ;)
muellerr commented 2020-04-21 14:22:08 +02:00
Author
Owner
Copy Link

Was added.

Was added.
mohr requested changes 2020-04-20 14:12:31 +02:00
tmtcservices/TmTcBridge.h Outdated
@ -0,0 +71,4 @@
* @param size [out] Size of received data
* @return
*/
virtual ReturnValue_t receiveTc(uint8_t ** recvBuffer, uint32_t * size) = 0;
mohr commented 2020-04-20 14:12:01 +02:00
Owner
Copy Link

Maybe already use size_t here

Maybe already use size_t here
muellerr commented 2020-04-21 14:57:21 +02:00
Author
Owner
Copy Link

done

done
mohr reviewed 2020-04-20 14:13:55 +02:00
tmtcservices/TmTcBridge.cpp Outdated
@ -0,0 +106,4 @@
store_address_t storeId = 0;
if(fifo.full()) {
info << "TMTC Bridge: TM downlink max. number of stored packet IDs reached."
mohr commented 2020-04-20 14:13:55 +02:00
Owner
Copy Link

this might be better in the error stream

this might be better in the error stream
muellerr commented 2020-04-21 14:54:47 +02:00
Author
Owner
Copy Link

done

done
mohr reviewed 2020-04-20 14:14:27 +02:00
tmtcservices/TmTcBridge.cpp Outdated
@ -0,0 +101,4 @@
}
ReturnValue_t TmTcBridge::storeDownlinkData(TmTcMessage *message) {
info << "TMTC Bridge: Comm Link down. "
mohr commented 2020-04-20 14:14:27 +02:00
Owner
Copy Link

can this be moved to debug? we try to keep info as clean as possible

can this be moved to debug? we try to keep info as clean as possible
muellerr commented 2020-04-21 14:54:25 +02:00
Author
Owner
Copy Link

done

done
mohr added the
feature
 label 2020-04-20 14:31:38 +02:00
mohr self-assigned this 2020-04-20 14:31:42 +02:00
muellerr commented 2020-04-22 18:17:31 +02:00
Author
Owner
Copy Link

I added all requested changes and fixed some faulty includes.

I added all requested changes and fixed some faulty includes.
muellerr commented 2020-04-23 11:52:24 +02:00
Author
Owner
Copy Link

Some more improvements added:

  • Default value for number packet stored and max number of packets sent per cycle.
  • Limit value for these parameter too
  • values can be set with setter functions
  • virtual keyword for initialize() + performOperation() (with override)
  • more functions virtual

What still needs to be implemented:

  • Make FIFO protected instead of private
Some more improvements added: - Default value for number packet stored and max number of packets sent per cycle. - Limit value for these parameter too - values can be set with setter functions - virtual keyword for initialize() + performOperation() (with override) - more functions virtual What still needs to be implemented: - Make FIFO protected instead of private
muellerr changed title from mueller_TmTcBridge_cherryPicked to WIP:mueller_TmTcBridge_cherryPicked 2020-04-23 12:13:51 +02:00
muellerr changed title from WIP:mueller_TmTcBridge_cherryPicked to mueller_TmTcBridge_cherryPicked 2020-05-11 19:38:11 +02:00
muellerr commented 2020-07-06 12:41:32 +02:00
Author
Owner
Copy Link

This will be the base for the new UnixUdpTmTcBridge

This will be the base for the new UnixUdpTmTcBridge
mohr approved these changes 2020-07-07 12:06:12 +02:00
muellerr closed this pull request 2020-07-07 12:06:47 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
API Change

Changes the API, so Users need to adapted

  
Breaking API Change

Changes the API in a non backwards compatible way

  
bug

Something is not working

  
build

Issues related to the buildsystem, including CI

  
cosmetics

Small change most users won't notice

  
Documentation

Improvement of code documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
hotfix

Quick or important fix that is merged directly into master, causing a new revision

  
invalid

#worksforme

  
question

More information is needed

  
Refactor

Contains a refactoring of some code

  
Tests

Issues related to testing code

  
wontfix

This won't be fixed

No Label
API Change
Breaking API Change
bug
build
cosmetics
Documentation
duplicate
feature
help wanted
hotfix
invalid
question
Refactor
Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
mohr
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: fsfw/fsfw#40
No description provided.
Delete Branch "KSat/fsfw:mueller_TmTcBridge_cherryPicked"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?