mueller_TmTcBridge_cherryPicked #40
No reviewers
Labels
No Label
API Change
Breaking API Change
bug
build
cosmetics
Documentation
duplicate
feature
help wanted
hotfix
invalid
question
Refactor
Tests
wontfix
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: fsfw/fsfw#40
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "KSat/fsfw:mueller_TmTcBridge_cherryPicked"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This fixes #39 .
New generic TMTC bridge, which handles FSFW related tasks.
muellerr referenced this pull request2020-04-18 13:42:49 +02:00
Added some comments which should also be reflected in our coding guidelines
@ -0,0 +3,4 @@
*
* @date 26.12.2019
* @author R. Mueller
*/
Please don't add file headers, we have git and a file system for this information
Removed
@ -0,0 +36,4 @@
* other member of the class can be used.
* @return Currently, the return value is ignored.
*/
virtual ReturnValue_t performOperation(uint8_t operationCode = 0);
I recently learned that the override keyword would be useful here ;)
Was added.
@ -0,0 +71,4 @@
* @param size [out] Size of received data
* @return
*/
virtual ReturnValue_t receiveTc(uint8_t ** recvBuffer, uint32_t * size) = 0;
Maybe already use size_t here
done
@ -0,0 +106,4 @@
store_address_t storeId = 0;
if(fifo.full()) {
info << "TMTC Bridge: TM downlink max. number of stored packet IDs reached."
this might be better in the error stream
done
@ -0,0 +101,4 @@
}
ReturnValue_t TmTcBridge::storeDownlinkData(TmTcMessage *message) {
info << "TMTC Bridge: Comm Link down. "
can this be moved to debug? we try to keep info as clean as possible
done
I added all requested changes and fixed some faulty includes.
Some more improvements added:
What still needs to be implemented:
mueller_TmTcBridge_cherryPickedto WIP:mueller_TmTcBridge_cherryPickedWIP:mueller_TmTcBridge_cherryPickedto mueller_TmTcBridge_cherryPickedThis will be the base for the new UnixUdpTmTcBridge