mueller_TmTcBridge_cherryPicked #40

Merged
muellerr merged 30 commits from KSat/fsfw:mueller_TmTcBridge_cherryPicked into master 2020-07-07 12:06:47 +02:00
Owner

This fixes #39 .
New generic TMTC bridge, which handles FSFW related tasks.

This fixes #39 . New generic TMTC bridge, which handles FSFW related tasks.
mohr requested changes 2020-04-20 14:08:15 +02:00
mohr left a comment
Owner

Added some comments which should also be reflected in our coding guidelines

Added some comments which should also be reflected in our coding guidelines
@ -0,0 +3,4 @@
*
* @date 26.12.2019
* @author R. Mueller
*/
Owner

Please don't add file headers, we have git and a file system for this information

Please don't add file headers, we have git and a file system for this information
Author
Owner

Removed

Removed
@ -0,0 +36,4 @@
* other member of the class can be used.
* @return Currently, the return value is ignored.
*/
virtual ReturnValue_t performOperation(uint8_t operationCode = 0);
Owner

I recently learned that the override keyword would be useful here ;)

I recently learned that the override keyword would be useful here ;)
Author
Owner

Was added.

Was added.
mohr requested changes 2020-04-20 14:12:31 +02:00
@ -0,0 +71,4 @@
* @param size [out] Size of received data
* @return
*/
virtual ReturnValue_t receiveTc(uint8_t ** recvBuffer, uint32_t * size) = 0;
Owner

Maybe already use size_t here

Maybe already use size_t here
Author
Owner

done

done
mohr reviewed 2020-04-20 14:13:55 +02:00
@ -0,0 +106,4 @@
store_address_t storeId = 0;
if(fifo.full()) {
info << "TMTC Bridge: TM downlink max. number of stored packet IDs reached."
Owner

this might be better in the error stream

this might be better in the error stream
Author
Owner

done

done
mohr reviewed 2020-04-20 14:14:27 +02:00
@ -0,0 +101,4 @@
}
ReturnValue_t TmTcBridge::storeDownlinkData(TmTcMessage *message) {
info << "TMTC Bridge: Comm Link down. "
Owner

can this be moved to debug? we try to keep info as clean as possible

can this be moved to debug? we try to keep info as clean as possible
Author
Owner

done

done
mohr added the
feature
label 2020-04-20 14:31:38 +02:00
mohr self-assigned this 2020-04-20 14:31:42 +02:00
Author
Owner

I added all requested changes and fixed some faulty includes.

I added all requested changes and fixed some faulty includes.
Author
Owner

Some more improvements added:

  • Default value for number packet stored and max number of packets sent per cycle.
  • Limit value for these parameter too
  • values can be set with setter functions
  • virtual keyword for initialize() + performOperation() (with override)
  • more functions virtual

What still needs to be implemented:

  • Make FIFO protected instead of private
Some more improvements added: - Default value for number packet stored and max number of packets sent per cycle. - Limit value for these parameter too - values can be set with setter functions - virtual keyword for initialize() + performOperation() (with override) - more functions virtual What still needs to be implemented: - Make FIFO protected instead of private
muellerr changed title from mueller_TmTcBridge_cherryPicked to WIP:mueller_TmTcBridge_cherryPicked 2020-04-23 12:13:51 +02:00
muellerr changed title from WIP:mueller_TmTcBridge_cherryPicked to mueller_TmTcBridge_cherryPicked 2020-05-11 19:38:11 +02:00
Author
Owner

This will be the base for the new UnixUdpTmTcBridge

This will be the base for the new UnixUdpTmTcBridge
mohr approved these changes 2020-07-07 12:06:12 +02:00
muellerr closed this pull request 2020-07-07 12:06:47 +02:00
Sign in to join this conversation.
No description provided.