fifo enhancement #57

muellerr · 2020-04-23T15:05:08+02:00

muellerr commented

2020-04-23 15:05:08 +02:00

fixes #56

muellerr added the

feature

label 2020-04-24 17:09:55 +02:00

gaisser self-assigned this 2020-05-05 17:33:07 +02:00

gaisser commented

2020-05-05 17:38:00 +02:00

We could avoid code duplications with implementing pop as:

	ReturnValue_t pop() {
	    T value;
        return this->retrieve(&value);
	}

What do you think?

We could avoid code duplications with implementing pop as: ``` C++ ReturnValue_t pop() { T value; return this->retrieve(&value); } ``` What do you think?

muellerr commented

2020-05-05 18:21:53 +02:00

Nice. Will integrate.

muellerr commented

2020-05-05 19:07:33 +02:00

change integrated

gaisser referenced this issue from a commit

2020-05-25 14:48:29 +02:00

Merge pull request 'fifo enhancement' (#57) from KSat/fsfw:mueller_fifo_enhancement into master Implements #57

gaisser closed this pull request

2020-05-25 14:48:29 +02:00

gaisser deleted branch mueller_fifo_enhancement

2020-05-25 14:54:54 +02:00

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: fsfw/fsfw#57