fsfw/fsfw
11
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

fifo enhancement #57

Merged
gaisser merged 3 commits from KSat/fsfw:mueller_fifo_enhancement into master 2020-05-25 14:48:29 +02:00
Conversation 3 Commits 3 Files Changed 1 +20
muellerr commented 2020-04-23 15:05:08 +02:00
Owner
Copy Link

fixes #56

fixes #56
muellerr added the
feature
 label 2020-04-24 17:09:55 +02:00
gaisser self-assigned this 2020-05-05 17:33:07 +02:00
gaisser commented 2020-05-05 17:38:00 +02:00
Owner
Copy Link

We could avoid code duplications with implementing pop as:

	ReturnValue_t pop() {
	    T value;
        return this->retrieve(&value);
	}

What do you think?

We could avoid code duplications with implementing pop as: ``` C++ ReturnValue_t pop() { T value; return this->retrieve(&value); } ``` What do you think?
muellerr commented 2020-05-05 18:21:53 +02:00
Author
Owner
Copy Link

Nice. Will integrate.

Nice. Will integrate.
muellerr commented 2020-05-05 19:07:33 +02:00
Author
Owner
Copy Link

change integrated

change integrated
gaisser closed this pull request 2020-05-25 14:48:29 +02:00
gaisser deleted branch mueller_fifo_enhancement 2020-05-25 14:54:54 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
API Change
Changes the API, so Users need to adapted
Breaking API Change
Changes the API in a non backwards compatible way
bug
Something is not working
build
Issues related to the buildsystem, including CI
cosmetics
Small change most users won't notice
Documentation
Improvement of code documentation
duplicate
This issue or pull request already exists
feature
New feature
help wanted
Need some help
hotfix
Quick or important fix that is merged directly into master, causing a new revision
invalid
#worksforme
question
More information is needed
Refactor
Contains a refactoring of some code
Tests
Issues related to testing code
wontfix
This won't be fixed
No Label
feature
Milestone
No items
No Milestone
Assignees
Clear assignees
ahinkel dwoodward gaisser hanke jenkins_buildfix lrajer meierj mohr muellerr taheran tbaumgartl
No Assignees gaisser
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fsfw/fsfw#57
No description provided.
Delete Branch "KSat/fsfw:mueller_fifo_enhancement"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?