run auto-formatter over cmakelists.txt #619

Merged
gaisser merged 16 commits from mueller/amft-cmakelists into development 2022-05-13 11:44:48 +02:00
Owner

Run clion CMake auto-formatter over the CMakeLists.txt file

Run `clion` CMake auto-formatter over the `CMakeLists.txt` file
muellerr added 1 commit 2022-05-09 11:20:16 +02:00
run auto-formatter over cmakelists.txt
Some checks failed
fsfw/fsfw/pipeline/head Build started...
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
6308427d03
muellerr added the
cosmetics
label 2022-05-09 11:20:26 +02:00
muellerr added this to the v5.0.0 milestone 2022-05-09 11:21:00 +02:00
muellerr added 1 commit 2022-05-09 15:16:19 +02:00
Merge remote-tracking branch 'origin/development' into mueller/amft-cmakelists
Some checks failed
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
220469a2dd
muellerr added 2 commits 2022-05-09 15:54:29 +02:00
indentation
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
5989c88c88
gaisser added 1 commit 2022-05-09 16:34:25 +02:00
Merge branch 'development' into mueller/amft-cmakelists
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
d983305ea5
muellerr added 1 commit 2022-05-09 17:22:43 +02:00
Merge branch 'development' into mueller/amft-cmakelists
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
d8bd08dd8c
gaisser requested changes 2022-05-09 20:27:06 +02:00
gaisser left a comment
Owner

Can you add that to the auto format script?

Can you add that to the auto format script?
Owner

Can you add that to the auto format script?

I guess the problem is that clion is not open source and thus would be a bad dependency imho.

It also seems there is no "standard" formatter for cmake.

I just tried cmakelang (available via pip) and it produces similar but different output.

We could use this as an open source tool or just depend on one developer running clion from time to time...

> Can you add that to the auto format script? I guess the problem is that clion is not open source and thus would be a bad dependency imho. It also seems there is no "standard" formatter for cmake. I just tried [cmakelang](https://https://github.com/cheshirekow/cmake_format) (available via [pip](https://https://pypi.org/project/cmakelang/)) and it produces similar but different output. We could use this as an open source tool or just depend on one developer running clion from time to time...
muellerr added 1 commit 2022-05-11 11:30:49 +02:00
Merge branch 'development' into mueller/amft-cmakelists
Some checks failed
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
34e124f2db
Author
Owner

I don' think clang-tidy can do this. I like the idea using cmakelang instead of relying on a propriertary tool. I might give it a try

I don' think `clang-tidy` can do this. I like the idea using `cmakelang` instead of relying on a propriertary tool. I might give it a try
muellerr added 2 commits 2022-05-12 17:16:21 +02:00
muellerr added 1 commit 2022-05-12 17:28:00 +02:00
run cmake-format
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
3046822e88
Author
Owner

I ran cmake-format and I am happy with the output

I ran `cmake-format` and I am happy with the output
muellerr added 1 commit 2022-05-13 11:31:03 +02:00
Merge branch 'development' into mueller/amft-cmakelists
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
57a830cb46
Author
Owner

I will add the clang-format call to the auto-formatter script

I will add the `clang-format` call to the auto-formatter script
muellerr added 3 commits 2022-05-13 11:35:31 +02:00
muellerr added 2 commits 2022-05-13 11:38:06 +02:00
finally this works
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
deee4c43c0
gaisser approved these changes 2022-05-13 11:42:59 +02:00
gaisser left a comment
Owner

Great! LGTM

Great! LGTM
gaisser merged commit b6b3221b22 into development 2022-05-13 11:44:48 +02:00
gaisser deleted branch mueller/amft-cmakelists 2022-05-13 11:44:52 +02:00
Sign in to join this conversation.
No description provided.