run auto-formatter over cmakelists.txt #619

Merged

gaisser merged 16 commits from mueller/amft-cmakelists into development 2022-05-13 11:44:48 +02:00

Conversation 6 Commits 16 Files Changed 2

+251 -276

muellerr commented 2022-05-09 11:20:15 +02:00

Owner

Copy link

Copy source

Run clion CMake auto-formatter over the CMakeLists.txt file

Run `clion` CMake auto-formatter over the `CMakeLists.txt` file

muellerr added 1 commit 2022-05-09 11:20:16 +02:00

run auto-formatter over cmakelists.txt 6308427d03

muellerr added the cosmetics label 2022-05-09 11:20:26 +02:00

muellerr added this to the v5.0.0 milestone 2022-05-09 11:21:00 +02:00

muellerr added 1 commit 2022-05-09 15:16:19 +02:00

Merge remote-tracking branch 'origin/development' into mueller/amft-cmakelists 220469a2dd

muellerr added 2 commits 2022-05-09 15:54:29 +02:00

Merge remote-tracking branch 'origin/development' into mueller/amft-cmakelists da8a108cb7

indentation 5989c88c88

gaisser added 1 commit 2022-05-09 16:34:25 +02:00

Merge branch 'development' into mueller/amft-cmakelists d983305ea5

muellerr added 1 commit 2022-05-09 17:22:43 +02:00

Merge branch 'development' into mueller/amft-cmakelists d8bd08dd8c

gaisser requested changes 2022-05-09 20:27:06 +02:00

gaisser left a comment

Owner

Copy link

Copy source

Can you add that to the auto format script?

Can you add that to the auto format script?

mohr commented 2022-05-11 11:29:06 +02:00

Owner

Copy link

Copy source

Can you add that to the auto format script?

I guess the problem is that clion is not open source and thus would be a bad dependency imho.

It also seems there is no "standard" formatter for cmake.

I just tried cmakelang (available via pip) and it produces similar but different output.

We could use this as an open source tool or just depend on one developer running clion from time to time...

> Can you add that to the auto format script? I guess the problem is that clion is not open source and thus would be a bad dependency imho. It also seems there is no "standard" formatter for cmake. I just tried [cmakelang](https://https://github.com/cheshirekow/cmake_format) (available via [pip](https://https://pypi.org/project/cmakelang/)) and it produces similar but different output. We could use this as an open source tool or just depend on one developer running clion from time to time...

muellerr added 1 commit 2022-05-11 11:30:49 +02:00

Merge branch 'development' into mueller/amft-cmakelists 34e124f2db

muellerr commented 2022-05-11 11:33:26 +02:00

Author

Owner

Copy link

Copy source

I don' think clang-tidy can do this. I like the idea using cmakelang instead of relying on a propriertary tool. I might give it a try

I don' think `clang-tidy` can do this. I like the idea using `cmakelang` instead of relying on a propriertary tool. I might give it a try

muellerr added 2 commits 2022-05-12 17:16:21 +02:00

Merge remote-tracking branch 'origin/development' into mueller/amft-cmakelists 9b6fa646ed

Merge branch 'mueller/amft-cmakelists' of https://egit.irs.uni-stuttgart.de/fsfw/fsfw into mueller/amft-cmakelists 6442dd0c38

muellerr added 1 commit 2022-05-12 17:28:00 +02:00

run cmake-format 3046822e88

muellerr commented 2022-05-12 17:28:16 +02:00

Author

Owner

Copy link

Copy source

I ran cmake-format and I am happy with the output

I ran `cmake-format` and I am happy with the output

muellerr added 1 commit 2022-05-13 11:31:03 +02:00

Merge branch 'development' into mueller/amft-cmakelists 57a830cb46

muellerr commented 2022-05-13 11:31:20 +02:00

Author

Owner

Copy link

Copy source

I will add the clang-format call to the auto-formatter script

I will add the `clang-format` call to the auto-formatter script

muellerr added 3 commits 2022-05-13 11:35:31 +02:00

add cmake-format command to shell script 994c7299b9

small fix 9e3d5b6a0c

Merge branch 'mueller/amft-cmakelists' of https://egit.irs.uni-stuttgart.de/fsfw/fsfw into mueller/amft-cmakelists ec03a674bd

muellerr added 2 commits 2022-05-13 11:38:06 +02:00

another small fix ad0b6f1ed1

finally this works deee4c43c0

gaisser approved these changes 2022-05-13 11:42:59 +02:00

gaisser left a comment

Owner

Copy link

Copy source

Great! LGTM

Great! LGTM

gaisser merged commit b6b3221b22 into development 2022-05-13 11:44:48 +02:00

gaisser referenced this issue from a commit 2022-05-13 11:44:48 +02:00

Merge pull request 'run auto-formatter over cmakelists.txt' (#619) from mueller/amft-cmakelists into development

gaisser deleted branch mueller/amft-cmakelists 2022-05-13 11:44:52 +02:00

Sign in to join this conversation.

Reviewers

No Reviewers

gaisser

Labels

Clear labels

API Change

Changes the API, so Users need to adapted

Breaking API Change

Changes the API in a non backwards compatible way

Documentation

Improvement of code documentation

Refactor

Contains a refactoring of some code

Tests

Issues related to testing code

bug

Something is not working

build

Issues related to the buildsystem, including CI

cosmetics

Small change most users won't notice

duplicate

This issue or pull request already exists

feature

New feature

help wanted

Need some help

hotfix

Quick or important fix that is merged directly into master, causing a new revision

invalid

#worksforme

question

More information is needed

wontfix

This won't be fixed

No labels cosmetics

Milestone

No items

No Milestone v5.0.0

Assignees

Clear assignees

ahinkel (Andy Hinkel) gaisser (Steffen Gaisser) jenkins_buildfix meierj (Jakob Meier) mohr (Ulrich Mohr) mspahr muellerr (Robin Müller) tbaumgartl (Tobias Baumgartl)

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: fsfw/fsfw#619