fsfw/fsfw
fsfw
/
fsfw
10
3
Fork 6
Code Issues 31 Pull Requests 4 Releases 10 Wiki Activity

run auto-formatter over cmakelists.txt #619

Merged
gaisser merged 16 commits from mueller/amft-cmakelists into development 2022-05-13 11:44:48 +02:00
Conversation 4 Commits 16 Files Changed 2 +251 -276
muellerr commented 2022-05-09 11:20:15 +02:00
Owner
Copy Link

Run clion CMake auto-formatter over the CMakeLists.txt file

Run `clion` CMake auto-formatter over the `CMakeLists.txt` file
muellerr added 1 commit 2022-05-09 11:20:16 +02:00
fsfw/fsfw/pipeline/head Build started... Details
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
6308427d03
run auto-formatter over cmakelists.txt
muellerr added the
cosmetics
 label 2022-05-09 11:20:26 +02:00
muellerr added this to the v5.0.0 milestone 2022-05-09 11:21:00 +02:00
muellerr added 1 commit 2022-05-09 15:16:19 +02:00
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
220469a2dd Merge remote-tracking branch 'origin/development' into mueller/amft-cmakelists
muellerr added 2 commits 2022-05-09 15:54:29 +02:00
fsfw/fsfw/pipeline/pr-development This commit looks good Details
5989c88c88 indentation
gaisser added 1 commit 2022-05-09 16:34:25 +02:00
fsfw/fsfw/pipeline/pr-development This commit looks good Details
d983305ea5 Merge branch 'development' into mueller/amft-cmakelists
muellerr added 1 commit 2022-05-09 17:22:43 +02:00
fsfw/fsfw/pipeline/pr-development This commit looks good Details
d8bd08dd8c Merge branch 'development' into mueller/amft-cmakelists
gaisser requested changes 2022-05-09 20:27:06 +02:00
gaisser left a comment
Owner
Copy Link

Can you add that to the auto format script?

Can you add that to the auto format script?
mohr commented 2022-05-11 11:29:06 +02:00
Owner
Copy Link

Can you add that to the auto format script?

I guess the problem is that clion is not open source and thus would be a bad dependency imho.

It also seems there is no "standard" formatter for cmake.

I just tried cmakelang (available via pip) and it produces similar but different output.

We could use this as an open source tool or just depend on one developer running clion from time to time...

> Can you add that to the auto format script? I guess the problem is that clion is not open source and thus would be a bad dependency imho. It also seems there is no "standard" formatter for cmake. I just tried [cmakelang](https://https://github.com/cheshirekow/cmake_format) (available via [pip](https://https://pypi.org/project/cmakelang/)) and it produces similar but different output. We could use this as an open source tool or just depend on one developer running clion from time to time...
muellerr added 1 commit 2022-05-11 11:30:49 +02:00
fsfw/fsfw/pipeline/pr-development There was a failure building this commit Details
34e124f2db Merge branch 'development' into mueller/amft-cmakelists
muellerr commented 2022-05-11 11:33:26 +02:00
Author
Owner
Copy Link

I don' think clang-tidy can do this. I like the idea using cmakelang instead of relying on a propriertary tool. I might give it a try

I don' think `clang-tidy` can do this. I like the idea using `cmakelang` instead of relying on a propriertary tool. I might give it a try
muellerr added 2 commits 2022-05-12 17:16:21 +02:00
muellerr added 1 commit 2022-05-12 17:28:00 +02:00
fsfw/fsfw/pipeline/pr-development This commit looks good Details
3046822e88
run cmake-format
muellerr commented 2022-05-12 17:28:16 +02:00
Author
Owner
Copy Link

I ran cmake-format and I am happy with the output

I ran `cmake-format` and I am happy with the output
muellerr added 1 commit 2022-05-13 11:31:03 +02:00
fsfw/fsfw/pipeline/pr-development This commit looks good Details
57a830cb46 Merge branch 'development' into mueller/amft-cmakelists
muellerr commented 2022-05-13 11:31:20 +02:00
Author
Owner
Copy Link

I will add the clang-format call to the auto-formatter script

I will add the `clang-format` call to the auto-formatter script
muellerr added 3 commits 2022-05-13 11:35:31 +02:00
muellerr added 2 commits 2022-05-13 11:38:06 +02:00
fsfw/fsfw/pipeline/pr-development This commit looks good Details
deee4c43c0
finally this works
gaisser approved these changes 2022-05-13 11:42:59 +02:00
gaisser left a comment
Owner
Copy Link

Great! LGTM

Great! LGTM
gaisser merged commit b6b3221b22 into development 2022-05-13 11:44:48 +02:00
gaisser deleted branch mueller/amft-cmakelists 2022-05-13 11:44:52 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
gaisser
Labels
Clear labels   
API Change

Changes the API, so Users need to adapted

  
Breaking API Change

Changes the API in a non backwards compatible way

  
bug

Something is not working

  
build

Issues related to the buildsystem, including CI

  
cosmetics

Small change most users won't notice

  
Documentation

Improvement of code documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
hotfix

Quick or important fix that is merged directly into master, causing a new revision

  
invalid

#worksforme

  
question

More information is needed

  
Refactor

Contains a refactoring of some code

  
Tests

Issues related to testing code

  
wontfix

This won't be fixed

No Label
API Change
Breaking API Change
bug
build
cosmetics
Documentation
duplicate
feature
help wanted
hotfix
invalid
question
Refactor
Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
v5.0.0
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: fsfw/fsfw#619
No description provided.
Delete Branch "mueller/amft-cmakelists"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?