fsfw/fsfw
fsfw/fsfw
10
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

return end iterator instead of crashing #633

Merged
gaisser merged 2 commits from mueller/possible-fix-ccsds-distrib into development 2022-05-25 13:59:36 +02:00
Conversation 3 Commits 2 Files Changed 1 +3 -2
muellerr commented 2022-05-24 14:35:46 +02:00
Owner
Copy Link
  • Some clang-tidy improvements
  • Instead of continuing if a packet can not be loaded from a store, return
    the invalid value equivalent of the iterator
- Some `clang-tidy` improvements - Instead of continuing if a packet can not be loaded from a store, return the invalid value equivalent of the iterator
muellerr added 1 commit 2022-05-24 14:35:49 +02:00
return end iterator instead of crashing
All checks were successful
fsfw/fsfw/pipeline/head This commit looks good
Details
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
e59f1f26bf
muellerr added the
bug
 label 2022-05-24 14:35:56 +02:00
muellerr requested review from gaisser 2022-05-24 14:36:03 +02:00
muellerr added this to the v5.0.0 milestone 2022-05-24 14:53:12 +02:00
gaisser commented 2022-05-24 23:48:03 +02:00
Owner
Copy Link

Oh what happend here? How was the packet lost in your case?

Oh what happend here? How was the packet lost in your case?
muellerr added 1 commit 2022-05-25 09:52:42 +02:00
Merge branch 'development' into mueller/possible-fix-ccsds-distrib
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
7dddcdfd55
muellerr commented 2022-05-25 09:53:28 +02:00
Author
Owner
Copy Link

Configuration error. It was a hint at a bug. A TC was deleted from a store, but then sending that TC was requested. The bug came from PUS 11 and was fixed.

Configuration error. It was a hint at a bug. A TC was deleted from a store, but then sending that TC was requested. The bug came from PUS 11 and was fixed.
gaisser approved these changes 2022-05-25 13:59:23 +02:00
gaisser left a comment
Owner
Copy Link

LGTM

LGTM
gaisser merged commit c7cf8e710d into development 2022-05-25 13:59:36 +02:00
gaisser deleted branch mueller/possible-fix-ccsds-distrib 2022-05-25 13:59:36 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
gaisser
Labels
Clear labels
API Change
Changes the API, so Users need to adapted
Breaking API Change
Changes the API in a non backwards compatible way
bug
Something is not working
build
Issues related to the buildsystem, including CI
cosmetics
Small change most users won't notice
Documentation
Improvement of code documentation
duplicate
This issue or pull request already exists
feature
New feature
help wanted
Need some help
hotfix
Quick or important fix that is merged directly into master, causing a new revision
invalid
#worksforme
question
More information is needed
Refactor
Contains a refactoring of some code
Tests
Issues related to testing code
wontfix
This won't be fixed
No Label
bug
Milestone
No items
No Milestone v5.0.0
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fsfw/fsfw#633
No description provided.
Delete Branch "mueller/possible-fix-ccsds-distrib"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?