FixedTimeslotTask object check #10

Merged

gaisser merged 14 commits from KSat/fsfw:luz_FixedTimeslotTask_ExistenceCheck into master

2020-05-05 20:12:40 +02:00

muellerr commented

2020-01-20 22:13:44 +01:00

Owner

Before adding to PST. Prevents NULL exception.

Before adding to PST. Prevents NULL exception.

gaisser commented

2020-02-11 16:46:15 +01:00

Owner

I think we should write this as:

ReturnValue_t FixedTimeslotTask::addSlot(object_id_t componentId,
	uint32_t slotTimeMs, int8_t executionStep) {
if (objectManager->get<ExecutableObjectIF>(componentId) != NULL) {
        pst.addSlot(componentId, slotTimeMs, executionStep, this);
    return HasReturnvaluesIF::RETURN_OK;
	
}
error << "Component " << std::hex << componentId << " not found, not adding it to pst" << std::endl;
return HasReturnvaluesIF::RETURN_FAILED;
    }

This seems to be more clear about the intention.

I think we should write this as: ReturnValue_t FixedTimeslotTask::addSlot(object_id_t componentId, uint32_t slotTimeMs, int8_t executionStep) { if (objectManager->get<ExecutableObjectIF>(componentId) != NULL) { pst.addSlot(componentId, slotTimeMs, executionStep, this); return HasReturnvaluesIF::RETURN_OK; } error << "Component " << std::hex << componentId << " not found, not adding it to pst" << std::endl; return HasReturnvaluesIF::RETURN_FAILED; } This seems to be more clear about the intention.

muellerr commented

2020-02-15 15:29:56 +01:00

Author

Owner

Done

Done

gaisser commented

2020-03-20 14:23:18 +01:00

Owner

Have you tested the code?

Have you tested the code?

gaisser closed this pull request

2020-03-20 14:23:18 +01:00

gaisser reopened this pull request

2020-03-20 14:23:21 +01:00

gaisser added the

label 2020-03-20 15:19:19 +01:00

muellerr commented

2020-04-01 15:10:15 +02:00

Author

Owner

Yes. Return error code if object does not exist instead of crashing with null pointer exception. Works fine otherwise.

Yes. Return error code if object does not exist instead of crashing with null pointer exception. Works fine otherwise.

gaisser commented

2020-04-02 17:49:04 +02:00

Owner

I think we have to fix this for other OSAL versions as well

I think we have to fix this for other OSAL versions as well

gaisser self-assigned this 2020-05-05 11:47:10 +02:00

muellerr commented

2020-05-05 18:34:37 +02:00

Author

Owner

I reported the changes to the other OSes.
However, linux and RTEMS are untested.

I reported the changes to the other OSes. However, linux and RTEMS are untested.

gaisser referenced this issue from a commit

2020-05-05 20:12:40 +02:00

Merge pull request 'FixedTimeslotTask object check' (#10) from KSat/fsfw:luz_FixedTimeslotTask_ExistenceCheck into master Now I think we are done here.

gaisser closed this pull request

2020-05-05 20:12:40 +02:00

gaisser deleted branch luz_FixedTimeslotTask_ExistenceCheck

2020-05-05 20:12:50 +02:00

Sign in to join this conversation.

No reviewers

No Label

Breaking API Change

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: fsfw/fsfw#10

No description provided.