FixedTimeslotTask object check #10

muellerr · 2020-01-20T22:13:44+01:00

muellerr commented

2020-01-20 22:13:44 +01:00

Before adding to PST. Prevents NULL exception.

gaisser commented

2020-02-11 16:46:15 +01:00

I think we should write this as:

ReturnValue_t FixedTimeslotTask::addSlot(object_id_t componentId,
	uint32_t slotTimeMs, int8_t executionStep) {
if (objectManager->get<ExecutableObjectIF>(componentId) != NULL) {
        pst.addSlot(componentId, slotTimeMs, executionStep, this);
    return HasReturnvaluesIF::RETURN_OK;
	
}
error << "Component " << std::hex << componentId << " not found, not adding it to pst" << std::endl;
return HasReturnvaluesIF::RETURN_FAILED;
    }

This seems to be more clear about the intention.

I think we should write this as: ReturnValue_t FixedTimeslotTask::addSlot(object_id_t componentId, uint32_t slotTimeMs, int8_t executionStep) { if (objectManager->get<ExecutableObjectIF>(componentId) != NULL) { pst.addSlot(componentId, slotTimeMs, executionStep, this); return HasReturnvaluesIF::RETURN_OK; } error << "Component " << std::hex << componentId << " not found, not adding it to pst" << std::endl; return HasReturnvaluesIF::RETURN_FAILED; } This seems to be more clear about the intention.

muellerr commented

2020-02-15 15:29:56 +01:00

Done