CommandingServiceBase improvements #105

muellerr · 2020-06-10T22:21:31+02:00

muellerr commented

2020-06-10 22:21:31 +02:00

sendTmPacket functions return their result now (had void retval for some reason).
size_t replacements.

If handleReply() returns RETURN_FAILED and the command is a rejected reply, a rejected reply will be set by the base class. Is that okay? I also added a getter function for rejected replies.

I also cleaned up includes a bit, moved 0 initializations to header and improved the doc a bit. I split up the huge handleCommandQueue function to increase readability.

Marked as API change because the cleaned up includes could lead to non-compiling code because of missing includes and because of the size_t changes.

`sendTmPacket` functions return their result now (had void retval for some reason). size_t replacements. If `handleReply()` returns `RETURN_FAILED` and the command is a rejected reply, a rejected reply will be set by the base class. Is that okay? I also added a getter function for rejected replies. I also cleaned up includes a bit, moved 0 initializations to header and improved the doc a bit. I split up the huge handleCommandQueue function to increase readability. Marked as API change because the cleaned up includes could lead to non-compiling code because of missing includes and because of the size_t changes.

muellerr added the

feature

API Change

Documentation

labels 2020-06-10 22:21:31 +02:00

muellerr referenced this pull request

2020-07-16 13:43:46 +02:00

CSB improvements #143

mohr reviewed 2020-07-21 11:47:18 +02:00

mohr commented

2020-07-21 11:49:50 +02:00

please add explicit bracklets around substatements in boolean statements

gaisser reviewed 2020-07-21 11:59:18 +02:00

tmtcservices/CommandingServiceBase.cpp Outdated

						
				@ -182,3 +214,2 @@

						if ((packet.getSubService() == 0)

								|| (isValidSubservice(packet.getSubService()) != RETURN_OK)) {

						if (packet.getSubService() == 0