fsfw/fsfw
fsfw/fsfw
10
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

singly linked list improvements #108

Merged
gaisser merged 7 commits from KSat/fsfw:mueller_SinglyLinkedListImprovements into master 2020-08-25 12:18:23 +02:00
Conversation 2 Commits 7 Files Changed 1 +82 -35
muellerr commented 2020-06-17 20:55:05 +02:00
Owner
Copy Link

New setEnd() function

New `setEnd()` function
muellerr added the
feature
 label 2020-06-17 20:55:20 +02:00
gaisser reviewed 2020-06-23 20:19:28 +02:00
container/SinglyLinkedList.h Outdated
@ -86,3 +90,2 @@
}
typename LinkedElement<T>::Iterator::Iterator end() const {
return LinkedElement<T>::Iterator::Iterator();
typename ElementIterator::Iterator end() const {
gaisser commented 2020-06-23 20:19:28 +02:00
Owner
Copy Link

Do we need that typename there?

Do we need that typename there?
muellerr commented 2020-06-24 11:41:33 +02:00
Author
Owner
Copy Link

I think not. Made as above now

I think not. Made as above now
gaisser self-assigned this 2020-06-23 20:19:38 +02:00
gaisser commented 2020-07-13 19:49:37 +02:00
Owner
Copy Link

Just one small thing: The functions sets last. End is a pointer past the last element. I suggest to call the function "setLast"

Just one small thing: The functions sets last. End is a pointer past the last element. I suggest to call the function "setLast"
muellerr commented 2020-07-13 19:59:58 +02:00
Author
Owner
Copy Link

oh, correct. I renamed them and merged upstream master

oh, correct. I renamed them and merged upstream master
gaisser closed this pull request 2020-08-25 12:18:23 +02:00
gaisser deleted branch mueller_SinglyLinkedListImprovements 2020-08-25 12:18:28 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
API Change

Changes the API, so Users need to adapted

  
Breaking API Change

Changes the API in a non backwards compatible way

  
bug

Something is not working

  
build

Issues related to the buildsystem, including CI

  
cosmetics

Small change most users won't notice

  
Documentation

Improvement of code documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
hotfix

Quick or important fix that is merged directly into master, causing a new revision

  
invalid

#worksforme

  
question

More information is needed

  
Refactor

Contains a refactoring of some code

  
Tests

Issues related to testing code

  
wontfix

This won't be fixed

No Label
API Change
Breaking API Change
bug
build
cosmetics
Documentation
duplicate
feature
help wanted
hotfix
invalid
question
Refactor
Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
gaisser
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: fsfw/fsfw#108
No description provided.
Delete Branch "KSat/fsfw:mueller_SinglyLinkedListImprovements"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?