fsfw/fsfw
11
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

hybrid iterator fix and improvement #109

Merged
gaisser merged 5 commits from KSat/fsfw:mueller_HybridIterator into master 2020-07-14 11:40:49 +02:00
Conversation 2 Commits 5 Files Changed 1 +21 -23
muellerr commented 2020-06-17 20:58:46 +02:00
Owner
Copy Link

I think there was a mistake (using a pointer where no pointer was passed).
Also, I am not sure what happens if a bool is initialized with NULL and I am not sure this was intended.

I think there was a mistake (using a pointer where no pointer was passed). Also, I am not sure what happens if a bool is initialized with NULL and I am not sure this was intended.
muellerr added the bug label 2020-06-17 20:58:46 +02:00
gaisser self-assigned this 2020-06-23 20:16:16 +02:00
gaisser requested changes 2020-06-23 20:17:14 +02:00
gaisser left a comment
Owner
Copy Link

There is another issue in the other constructor. End(NULL) can now be removed.

There is another issue in the other constructor. End(NULL) can now be removed.
container/HybridIterator.h Outdated
@@ -68,3 +66,2 @@
bool operator==(HybridIterator other) {
return value == other->value;
bool operator==(const HybridIterator& other) {
gaisser commented 2020-06-23 20:15:52 +02:00
Owner
Copy Link

This function can also be const

This function can also be const
container/HybridIterator.h Outdated
@@ -71,3 +69,3 @@
}
bool operator!=(HybridIterator other) {
bool operator!=(const HybridIterator& other) {
gaisser commented 2020-06-23 20:16:05 +02:00
Owner
Copy Link

This function can be const as well

This function can be const as well
gaisser reviewed 2020-06-25 18:07:26 +02:00
container/HybridIterator.h Outdated
@@ -90,3 +87,4 @@
T *end = nullptr;
};
#endif /* HYBRIDITERATOR_H_ */
gaisser commented 2020-06-25 18:07:26 +02:00
Owner
Copy Link

This is picky, but the comment is wrong :P

This is picky, but the comment is wrong :P
gaisser closed this pull request 2020-07-14 11:40:49 +02:00
gaisser deleted branch mueller_HybridIterator 2020-07-14 11:40:54 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
gaisser
Labels
Clear labels
API Change
Changes the API, so Users need to adapted
 Breaking API Change
Changes the API in a non backwards compatible way
 bug
Something is not working
 build
Issues related to the buildsystem, including CI
 cosmetics
Small change most users won't notice
 Documentation
Improvement of code documentation
 duplicate
This issue or pull request already exists
 feature
New feature
 help wanted
Need some help
 hotfix
Quick or important fix that is merged directly into master, causing a new revision
 invalid
#worksforme
 question
More information is needed
 Refactor
Contains a refactoring of some code
 Tests
Issues related to testing code
 wontfix
This won't be fixed
No Label bug
Milestone
No items
No Milestone
Assignees
Clear assignees
ahinkel dwoodward gaisser hanke jenkins_buildfix lrajer meierj mohr muellerr taheran tbaumgartl
No Assignees gaisser
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fsfw/fsfw#109
Delete Branch "KSat/fsfw:mueller_HybridIterator"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?