hybrid iterator fix and improvement #109
No reviewers
Labels
No Label
API Change
Breaking API Change
bug
build
cosmetics
Documentation
duplicate
feature
help wanted
hotfix
invalid
question
Refactor
Tests
wontfix
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: fsfw/fsfw#109
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "KSat/fsfw:mueller_HybridIterator"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
I think there was a mistake (using a pointer where no pointer was passed).
Also, I am not sure what happens if a bool is initialized with NULL and I am not sure this was intended.
There is another issue in the other constructor. End(NULL) can now be removed.
@ -68,3 +66,2 @@bool operator==(HybridIterator other) {return value == other->value;bool operator==(const HybridIterator& other) {This function can also be const
@ -71,3 +69,3 @@}bool operator!=(HybridIterator other) {bool operator!=(const HybridIterator& other) {This function can be const as well
@ -90,3 +87,4 @@T *end = nullptr;};#endif /* HYBRIDITERATOR_H_ */This is picky, but the comment is wrong :P