fsfw/fsfw
fsfw/fsfw
11
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

framework submakefile improvements #114

Merged
gaisser merged 2 commits from KSat/fsfw:mueller_Framework_mk_OS_FSFW into master 2020-07-28 12:37:29 +02:00
Conversation 2 Commits 2 Files Changed 1 +8 -7
muellerr commented 2020-06-19 14:38:39 +02:00
Owner
Copy Link

Fixes #115.

OS renamed to OS_FSFW because OS sometimes
is a system variable which can be used to determine the OS (windows, linux).

Fixes #115. OS renamed to OS_FSFW because OS sometimes is a system variable which can be used to determine the OS (windows, linux).
muellerr added the
feature
API Change
 labels 2020-06-19 14:38:39 +02:00
gaisser self-assigned this 2020-06-22 21:35:07 +02:00
gaisser reviewed 2020-06-22 21:36:06 +02:00
framework.mk Outdated
@ -34,1 +35,4 @@
else ifeq ($(OS_FSFW),freeRTOS)
CXXSRC += $(wildcard $(FRAMEWORK_PATH)/osal/FreeRTOS/*.cpp)
else ifeq ($(OS_FSFW),host)
CXXSRC += $(wildcard $(FRAMEWORK_PATH)/osal/host/*.cpp)
gaisser commented 2020-06-22 21:36:06 +02:00
Owner
Copy Link

This is intended to be used as user specific host?

This is intended to be used as user specific host?
muellerr commented 2020-06-23 08:50:57 +02:00
Author
Owner
Copy Link

It's basically an OS implemented as portable as possible for host machines by using C++ features.

It's basically an OS implemented as portable as possible for host machines by using C++ features.
muellerr commented 2020-06-23 10:25:01 +02:00
Author
Owner
Copy Link

By detecting the underlying OS, I can for example make thread settings (e.g. sched priority)
by using the native handle.

By detecting the underlying OS, I can for example make thread settings (e.g. sched priority) by using the native handle.
gaisser commented 2020-06-23 20:20:34 +02:00
Owner
Copy Link

And that is part of another pull request?

And that is part of another pull request?
muellerr commented 2020-06-24 11:32:52 +02:00
Author
Owner
Copy Link

I have not made a pull request yet, although I could do that. there are still some parts (like semaphores) which are not implemented yet because C++20 will feature them..

I have not made a pull request yet, although I could do that. there are still some parts (like semaphores) which are not implemented yet because C++20 will feature them..
gaisser reviewed 2020-07-21 12:06:12 +02:00
framework.mk Outdated
@ -8,11 +8,13 @@ CXXSRC += $(wildcard $(FRAMEWORK_PATH)/controller/*.cpp)
CXXSRC += $(wildcard $(FRAMEWORK_PATH)/coordinates/*.cpp)
CXXSRC += $(wildcard $(FRAMEWORK_PATH)/datalinklayer/*.cpp)
CXXSRC += $(wildcard $(FRAMEWORK_PATH)/datapool/*.cpp)
CXXSRC += $(wildcard $(FRAMEWORK_PATH)/datapoolglob/*.cpp)
gaisser commented 2020-07-21 12:06:12 +02:00
Owner
Copy Link

Could you remove the global datapool includes?

Could you remove the global datapool includes?
muellerr commented 2020-07-25 11:06:09 +02:00
Author
Owner
Copy Link

This would break a lot of exisiting code which still uses the global datapool

This would break a lot of exisiting code which still uses the global datapool
gaisser closed this pull request 2020-07-28 12:37:29 +02:00
muellerr deleted branch mueller_Framework_mk_OS_FSFW 2020-07-29 19:25:40 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
API Change
Changes the API, so Users need to adapted
Breaking API Change
Changes the API in a non backwards compatible way
bug
Something is not working
build
Issues related to the buildsystem, including CI
cosmetics
Small change most users won't notice
Documentation
Improvement of code documentation
duplicate
This issue or pull request already exists
feature
New feature
help wanted
Need some help
hotfix
Quick or important fix that is merged directly into master, causing a new revision
invalid
#worksforme
question
More information is needed
Refactor
Contains a refactoring of some code
Tests
Issues related to testing code
wontfix
This won't be fixed
No Label
API Change
feature
Milestone
No items
No Milestone
Assignees
Clear assignees
ahinkel dwoodward gaisser hanke jenkins_buildfix lrajer meierj mohr muellerr taheran tbaumgartl
No Assignees gaisser
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fsfw/fsfw#114
No description provided.
Delete Branch "KSat/fsfw:mueller_Framework_mk_OS_FSFW"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?