fsfw/fsfw
11
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

Fixed a shadowing issue with moving a declaration to inner scope #163

Merged
muellerr merged 4 commits from gaisser/fsfw:gaisser_small_bugfix_subsystem into master 2020-08-28 17:01:19 +02:00
Conversation 1 Commits 4 Files Changed 3 +9 -9
gaisser commented 2020-08-13 18:04:19 +02:00
Owner
Copy Link

Fixed a shadowing issue with moving a declaration to inner scope.

I would encourage all to add -Wshadow=local to the compile flags.

Fixed a shadowing issue with moving a declaration to inner scope. I would encourage all to add -Wshadow=local to the compile flags.
gaisser added the
bug
 label 2020-08-13 18:14:02 +02:00
muellerr was assigned by gaisser 2020-08-28 13:25:50 +02:00
muellerr merged commit b4978e7df3 into master 2020-08-28 17:01:17 +02:00
muellerr commented 2020-08-28 17:01:52 +02:00
Owner
Copy Link

Propably would be a good idea to add -Wshadow=local in the FSFW example.

Propably would be a good idea to add -Wshadow=local in the FSFW example.
gaisser deleted branch gaisser_small_bugfix_subsystem 2020-09-10 18:22:58 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
API Change
Changes the API, so Users need to adapted
Breaking API Change
Changes the API in a non backwards compatible way
bug
Something is not working
build
Issues related to the buildsystem, including CI
cosmetics
Small change most users won't notice
Documentation
Improvement of code documentation
duplicate
This issue or pull request already exists
feature
New feature
help wanted
Need some help
hotfix
Quick or important fix that is merged directly into master, causing a new revision
invalid
#worksforme
question
More information is needed
Refactor
Contains a refactoring of some code
Tests
Issues related to testing code
wontfix
This won't be fixed
No Label
bug
Milestone
No items
No Milestone
Assignees
Clear assignees
ahinkel dwoodward gaisser hanke jenkins_buildfix lrajer meierj mohr muellerr taheran tbaumgartl
No Assignees muellerr
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fsfw/fsfw#163
No description provided.
Delete Branch "gaisser/fsfw:gaisser_small_bugfix_subsystem"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?