fsfw/fsfw
fsfw
/
fsfw
10
3
Fork 6
Code Issues 31 Pull Requests 4 Releases 10 Wiki Activity

parameter improvements #181

Merged
gaisser merged 5 commits from KSat/fsfw:mueller/parameter-updates into master 2020-09-01 12:45:23 +02:00
Conversation 0 Commits 5 Files Changed 8 +127 -82
muellerr commented 2020-08-28 18:48:50 +02:00
Owner
Copy Link

message queue ID was initialized with 0 (but not explicitely..). Is initialized to MessageQueueIF::NO_QUEUE now

message queue ID was initialized with 0 (but not explicitely..). Is initialized to MessageQueueIF::NO_QUEUE now
muellerr added the
bug
feature
 labels 2020-08-28 18:48:50 +02:00
muellerr changed title from typo fixes to parameter improvements 2020-08-28 18:49:00 +02:00
gaisser requested changes 2020-09-01 12:28:50 +02:00
parameters/ParameterWrapper.cpp Outdated
@ -274,3 +273,1 @@
+ (((startingRow + fromRow) * columns)
+ startingColumn) * typeSize,
from->readonlyData, typeSize * from->columns);
uint8_t offset = (((startingRow + fromRow) * columns) + startingColumn) * typeSize;
gaisser commented 2020-09-01 12:25:48 +02:00
Owner
Copy Link

The offset can be larger than 8 bit.

The offset can be larger than 8 bit.
gaisser marked this conversation as resolved
gaisser self-assigned this 2020-09-01 12:29:04 +02:00
gaisser approved these changes 2020-09-01 12:45:06 +02:00
gaisser merged commit 96c421b72c into master 2020-09-01 12:45:20 +02:00
gaisser deleted branch mueller/parameter-updates 2020-09-01 12:45:24 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
gaisser
Labels
Clear labels   
API Change

Changes the API, so Users need to adapted

  
Breaking API Change

Changes the API in a non backwards compatible way

  
bug

Something is not working

  
build

Issues related to the buildsystem, including CI

  
cosmetics

Small change most users won't notice

  
Documentation

Improvement of code documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
hotfix

Quick or important fix that is merged directly into master, causing a new revision

  
invalid

#worksforme

  
question

More information is needed

  
Refactor

Contains a refactoring of some code

  
Tests

Issues related to testing code

  
wontfix

This won't be fixed

No Label
API Change
Breaking API Change
bug
build
cosmetics
Documentation
duplicate
feature
help wanted
hotfix
invalid
question
Refactor
Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
gaisser
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: fsfw/fsfw#181
No description provided.
Delete Branch "KSat/fsfw:mueller/parameter-updates"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?