fsfw/fsfw
fsfw/fsfw
10
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

Important bugfix for Linux MQ #394

Merged
gaisser merged 2 commits from KSat/fsfw:linux/hotfix-mq into development 2021-04-08 16:31:05 +02:00
Conversation 1 Commits 2 Files Changed 4 +11 -3
muellerr commented 2021-04-08 15:29:35 +02:00
Owner
Copy Link

This bug was not an issue on hosted Linux or Rapsberry Pi (at least on the surface), but causes crashes on a Zynq SoC.

A buffer write was exceeded by 4 bytes, causing buffer overflow errors on that system.

The former implementation used the hardcoded value MAX_DATA_SIZE.
I replaced this with getMaximumMessageSize() but this is actually a problem because this will return the size with the header as well.

I suspect even a unit test would not have caught this because this was not an obvious issue on host systems. Maybe valgrind or a static code analyzer would have caught it..

This bug was not an issue on hosted Linux or Rapsberry Pi (at least on the surface), but causes crashes on a Zynq SoC. A buffer write was exceeded by 4 bytes, causing buffer overflow errors on that system. The former implementation used the hardcoded value `MAX_DATA_SIZE`. I replaced this with `getMaximumMessageSize()` but this is actually a problem because this will return the size with the header as well. I suspect even a unit test would not have caught this because this was not an obvious issue on host systems. Maybe `valgrind` or a static code analyzer would have caught it..
muellerr added the
bug
 label 2021-04-08 15:29:35 +02:00
muellerr added 1 commit 2021-04-08 15:29:35 +02:00
muellerr changed title from super evil bugfix for Linux MQ to Important bugfix for Linux MQ 2021-04-08 15:32:03 +02:00
muellerr added 1 commit 2021-04-08 15:39:33 +02:00
gaisser commented 2021-04-08 15:58:04 +02:00
Owner
Copy Link

Bug is also in OSAL for RTEMS!

**Bug is also in OSAL for RTEMS!**
gaisser added this to the ASTP 1.0.0 Local pools milestone 2021-04-08 16:21:02 +02:00
gaisser self-assigned this 2021-04-08 16:21:05 +02:00
gaisser merged commit 2dd2d8f133 into development 2021-04-08 16:31:05 +02:00
gaisser deleted branch linux/hotfix-mq 2021-04-08 16:31:08 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
API Change

Changes the API, so Users need to adapted

  
Breaking API Change

Changes the API in a non backwards compatible way

  
bug

Something is not working

  
build

Issues related to the buildsystem, including CI

  
cosmetics

Small change most users won't notice

  
Documentation

Improvement of code documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
hotfix

Quick or important fix that is merged directly into master, causing a new revision

  
invalid

#worksforme

  
question

More information is needed

  
Refactor

Contains a refactoring of some code

  
Tests

Issues related to testing code

  
wontfix

This won't be fixed

No Label
API Change
Breaking API Change
bug
build
cosmetics
Documentation
duplicate
feature
help wanted
hotfix
invalid
question
Refactor
Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
ASTP 1.0.0 Local pools
Assignees
Clear assignees
No Assignees
gaisser
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: fsfw/fsfw#394
No description provided.
Delete Branch "KSat/fsfw:linux/hotfix-mq"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?