thermal sensor update #402

2021-04-12T12:43:23+02:00

muellerr commented

2021-04-12 12:43:23 +02:00

Updates ThermalSensor. I am still not entirely sure what the passed PoolVariableIF is. Also, getting the validity from the variable might require reading it first for the new local data pool implementation. The PoolVariableIF already implemented the ReadCommitIF so maybe it would be okay if the variable is simply read before getting the valid state.

Updates `ThermalSensor`. I am still not entirely sure what the passed PoolVariableIF is. Also, getting the validity from the variable might require reading it first for the new local data pool implementation. The `PoolVariableIF` already implemented the `ReadCommitIF` so maybe it would be okay if the variable is simply read before getting the valid state.

muellerr added the feature label 2021-04-12 12:43:23 +02:00

muellerr added 1 commit 2021-04-12 12:43:24 +02:00

thermal sensor update 4bb078c451

muellerr added this to the ASTP 1.0.0 Local pools milestone 2021-04-12 12:46:06 +02:00

gaisser added 1 commit 2021-04-13 14:02:26 +02:00

Merge branch 'development' into mueller/thermal-handler 43fb05ac5d

gaisser added 1 commit 2021-04-13 14:44:46 +02:00

Merge branch 'development' into mueller/thermal-handler 39940823d1

gaisser commented

2021-04-20 11:29:39 +02:00

To me it looks like

T *inputTemperature

is not really necessary besides the type deduction. We can get the current value by reading it directly. Overall this class is very complicated with the additional monitor which reads the value again. Maybe we should rewrite that stuff to the new update messages (or snapshot messages) and use a monitor which does not read again.

For SOURCE and EIVE the way temperatures are read are different than FLP (FLP gets its analog values for all temp sensors from the PCDU) so this might also change this class in way that it is more general.

To me it looks like ``` T *inputTemperature ``` is not really necessary besides the type deduction. We can get the current value by reading it directly. Overall this class is very complicated with the additional monitor which reads the value again. Maybe we should rewrite that stuff to the new update messages (or snapshot messages) and use a monitor which does not read again. For SOURCE and EIVE the way temperatures are read are different than FLP (FLP gets its analog values for all temp sensors from the PCDU) so this might also change this class in way that it is more general.

gaisser added 1 commit 2021-04-20 14:37:06 +02:00

Merge branch 'development' into mueller/thermal-handler 9784d5123b

muellerr added 2 commits 2021-04-20 14:47:23 +02:00

temp sensor update 6873d2b847

Merge branch 'mueller/thermal-handler' of https://egit.irs.uni-stuttgart.de/fsfw/fsfw into mueller/thermal-handler c8b2b3a038

muellerr added 1 commit 2021-04-20 14:58:46 +02:00

temperature sensor update 64efb8ec7f

muellerr added 1 commit 2021-04-20 15:01:10 +02:00

temperature sensor update e6a8371d4a

gaisser added 1 commit 2021-04-20 15:11:21 +02:00

Merge branch 'development' into mueller/thermal-handler 1af7870b15

gaisser reviewed

2021-04-20 15:22:47 +02:00

thermal/TemperatureSensor.h Outdated

						
				@@ -65,2 +63,2 @@

					 * @param datapoolId Datapool ID of the output temperature

					 * @param outputSet Output dataset for the output temperature to fetch it with read()

					 * @param setObjectid   objectId of the sensor object

					 * @param inputValue    Pointer to input value which is converted to a temperature