fsfw/fsfw
11
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

Activates new gcc compiler flags #568

Merged
muellerr merged 8 commits from gaisser/fsfw:gaisser_compiler_flags into development 2022-03-07 14:44:10 +01:00
Conversation 3 Commits 8 Files Changed 17 +179 -124
gaisser commented 2022-02-23 22:40:32 +01:00
Owner
Copy Link

Activates compiler flags according to #446.

Activates compiler flags according to #446. * Fixed some issues that came up and were easy to fix * Reported #566 and #567 * Fixed some missing includes * Fixed some const completeness * Added unit tests for CRC and some CCSDSTime functions which have been changed by this commit * Applied Clang format
gaisser added 4 commits 2022-02-23 22:40:43 +01:00
WIP compiler Flags and new unit tests for fixes f6357b4531
Clang format 09815f5cce
Fixed an issue with wrong buffer size 32381a7872
Fixed an missing include
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
1ef3dae72e
gaisser added this to the v5.0.0 milestone 2022-02-23 22:43:38 +01:00
gaisser added the bugbuild labels 2022-02-23 22:43:50 +01:00
muellerr requested changes 2022-02-24 10:39:21 +01:00
src/fsfw/cfdp/tlv/FilestoreTlvBase.h Outdated
@@ -1,11 +1,13 @@
#ifndef FSFW_SRC_FSFW_CFDP_FILESTOREREQUESTBASE_H_
#define FSFW_SRC_FSFW_CFDP_FILESTOREREQUESTBASE_H_
#include <FSFWConfig.h>
muellerr commented 2022-02-24 10:39:12 +01:00
Owner
Copy Link

Would be good to replace this with #include "fsfw/FSFW.h". That file includes the config but is also able to sanitize some of the values.

Would be good to replace this with `#include "fsfw/FSFW.h"`. That file includes the config but is also able to sanitize some of the values.
gaisser commented 2022-02-24 11:23:36 +01:00
Author
Owner
Copy Link

Done

Done
gaisser marked this conversation as resolved
muellerr requested changes 2022-02-24 10:42:06 +01:00
src/fsfw/serviceinterface/ServiceInterfacePrinter.h Outdated
@@ -1,6 +1,8 @@
#ifndef FSFW_SERVICEINTERFACE_SERVICEINTERFACEPRINTER
#define FSFW_SERVICEINTERFACE_SERVICEINTERFACEPRINTER
#include <FSFWConfig.h>
muellerr commented 2022-02-24 10:41:03 +01:00
Owner
Copy Link

Use #include "fsfw/FSFW.h" here

Use `#include "fsfw/FSFW.h"` here
gaisser commented 2022-02-24 11:23:51 +01:00
Author
Owner
Copy Link

Done

Done
gaisser marked this conversation as resolved
src/fsfw/storagemanager/LocalPool.cpp Outdated
@@ -1,5 +1,7 @@
#include "fsfw/storagemanager/LocalPool.h"
#include <FSFWConfig.h>
muellerr commented 2022-02-24 10:41:18 +01:00
Owner
Copy Link

Use #include "fsfw/FSFW.h" here

Use `#include "fsfw/FSFW.h"` here
gaisser commented 2022-02-24 11:23:59 +01:00
Author
Owner
Copy Link

Done

Done
gaisser marked this conversation as resolved
gaisser added 1 commit 2022-02-24 11:23:19 +01:00
Fixed include based on Feedback
Some checks failed
fsfw/fsfw/pipeline/pr-development There was a failure building this commit
Details
0e8328fca3
gaisser added 1 commit 2022-02-28 15:30:05 +01:00
Merge branch 'development' into gaisser_compiler_flags
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
68ca6fd122
gaisser added 1 commit 2022-03-07 13:09:25 +01:00
Merge branch 'development' into gaisser_compiler_flags
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
14b44f8bb2
gaisser added 1 commit 2022-03-07 14:39:05 +01:00
Merge branch 'development' into gaisser_compiler_flags 7db11588b4
muellerr approved these changes 2022-03-07 14:42:37 +01:00
muellerr merged commit 5912ddd2a2 into development 2022-03-07 14:44:10 +01:00
muellerr deleted branch gaisser_compiler_flags 2022-03-07 14:44:11 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
muellerr
Labels
Clear labels
API Change
Changes the API, so Users need to adapted
 Breaking API Change
Changes the API in a non backwards compatible way
 bug
Something is not working
 build
Issues related to the buildsystem, including CI
 cosmetics
Small change most users won't notice
 Documentation
Improvement of code documentation
 duplicate
This issue or pull request already exists
 feature
New feature
 help wanted
Need some help
 hotfix
Quick or important fix that is merged directly into master, causing a new revision
 invalid
#worksforme
 question
More information is needed
 Refactor
Contains a refactoring of some code
 Tests
Issues related to testing code
 wontfix
This won't be fixed
No Label bug build
Milestone
No items
No Milestone v5.0.0
Assignees
Clear assignees
ahinkel dwoodward gaisser hanke jenkins_buildfix lrajer meierj mohr muellerr taheran tbaumgartl
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: fsfw/fsfw#568
Delete Branch "gaisser/fsfw:gaisser_compiler_flags"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?