fsfw/fsfw
fsfw/fsfw
10
3
Fork 6
Code Issues 32 Pull Requests 4 Releases 10 Wiki Activity

HAL: Update for GPIO code #572

Merged
mohr merged 6 commits from eive/fsfw:mueller/gpio-update into development 2022-03-14 14:13:34 +01:00
Conversation 2 Commits 6 Files Changed 7 +26 -16
muellerr commented 2022-03-07 16:10:54 +01:00
Owner
Copy Link
  • GPIO HAL: Direction, GpioOperation and Levels are enum classes now, which prevents
    name clashes with Windows defines.
  • New CMake option FSFW_HAL_LINUX_ADD_LIBGPIOD to specifically exclude gpiod code.

This is a breaking API change because now the enums always have to prefixed with the enum scope. Also, they don't convert to their respective number values implicitely anymore.

- GPIO HAL: `Direction`, `GpioOperation` and `Levels` are enum classes now, which prevents name clashes with Windows defines. - New CMake option `FSFW_HAL_LINUX_ADD_LIBGPIOD` to specifically exclude `gpiod` code. This is a breaking API change because now the enums always have to prefixed with the enum scope. Also, they don't convert to their respective number values implicitely anymore.
muellerr added 2 commits 2022-03-07 16:10:56 +01:00
update changelog
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
41a82e923c
muellerr added the
Breaking API Change
 label 2022-03-07 16:11:34 +01:00
muellerr requested review from gaisser 2022-03-07 16:19:30 +01:00
gaisser refused to review 2022-03-07 18:32:44 +01:00
gaisser requested review from mohr 2022-03-07 18:32:49 +01:00
mohr commented 2022-03-07 18:44:38 +01:00
Owner
Copy Link

I am a bit confused, the code shows changing the enums to enum class, instead of renaming their value as shown in the description of the PR and in the changelog.
Which is the proposed change?
If I remember correctly, #556 is the precessor of this and was going for the enum class approch.

I am a bit confused, the code shows changing the enums to `enum class`, instead of renaming their value as shown in the description of the PR and in the changelog. Which is the proposed change? If I remember correctly, #556 is the precessor of this and was going for the `enum class` approch.
muellerr added 1 commit 2022-03-08 08:57:59 +01:00
fix changelog
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
e5a9cab34e
muellerr commented 2022-03-08 08:58:51 +01:00
Author
Owner
Copy Link

The documentation did not move with the code. Fixed it now

The documentation did not move with the code. Fixed it now
muellerr added 1 commit 2022-03-08 09:00:25 +01:00
another minor changelog update
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
d6856fc54a
muellerr added 1 commit 2022-03-08 09:01:30 +01:00
add link to PR
All checks were successful
fsfw/fsfw/pipeline/pr-development This commit looks good
Details
89c1878622
muellerr added 1 commit 2022-03-08 09:02:49 +01:00
minor correction
Some checks are pending
fsfw/fsfw/pipeline/pr-development Build started...
Details
14620fdd72
muellerr added this to the v5.0.0 milestone 2022-03-08 10:40:54 +01:00
mohr approved these changes 2022-03-08 20:08:27 +01:00
mohr left a comment
Owner
Copy Link

looks good

looks good
mohr merged commit 378c6c8006 into development 2022-03-14 14:13:34 +01:00
mohr deleted branch mueller/gpio-update 2022-03-14 14:13:38 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
mohr
Labels
Clear labels   
API Change

Changes the API, so Users need to adapted

  
Breaking API Change

Changes the API in a non backwards compatible way

  
bug

Something is not working

  
build

Issues related to the buildsystem, including CI

  
cosmetics

Small change most users won't notice

  
Documentation

Improvement of code documentation

  
duplicate

This issue or pull request already exists

  
feature

New feature

  
help wanted

Need some help

  
hotfix

Quick or important fix that is merged directly into master, causing a new revision

  
invalid

#worksforme

  
question

More information is needed

  
Refactor

Contains a refactoring of some code

  
Tests

Issues related to testing code

  
wontfix

This won't be fixed

No Label
API Change
Breaking API Change
bug
build
cosmetics
Documentation
duplicate
feature
help wanted
hotfix
invalid
question
Refactor
Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
v5.0.0
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: fsfw/fsfw#572
No description provided.
Delete Branch "eive/fsfw:mueller/gpio-update"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?