HAL: Update for GPIO code #572

muellerr · 2022-03-07T16:10:54+01:00

muellerr commented

2022-03-07 16:10:54 +01:00

GPIO HAL: Direction, GpioOperation and Levels are enum classes now, which prevents
name clashes with Windows defines.
New CMake option FSFW_HAL_LINUX_ADD_LIBGPIOD to specifically exclude gpiod code.

This is a breaking API change because now the enums always have to prefixed with the enum scope. Also, they don't convert to their respective number values implicitely anymore.

- GPIO HAL: `Direction`, `GpioOperation` and `Levels` are enum classes now, which prevents name clashes with Windows defines. - New CMake option `FSFW_HAL_LINUX_ADD_LIBGPIOD` to specifically exclude `gpiod` code. This is a breaking API change because now the enums always have to prefixed with the enum scope. Also, they don't convert to their respective number values implicitely anymore.

muellerr added 2 commits 2022-03-07 16:10:56 +01:00

5ddac36314

GPIO update

fsfw/fsfw/pipeline/pr-development This commit looks good Details

41a82e923c

update changelog

muellerr added the

Breaking API Change

label 2022-03-07 16:11:34 +01:00

muellerr requested review from gaisser 2022-03-07 16:19:30 +01:00

gaisser refused to review 2022-03-07 18:32:44 +01:00

gaisser requested review from mohr 2022-03-07 18:32:49 +01:00

mohr commented

2022-03-07 18:44:38 +01:00

I am a bit confused, the code shows changing the enums to enum class, instead of renaming their value as shown in the description of the PR and in the changelog.
Which is the proposed change?
If I remember correctly, #556 is the precessor of this and was going for the enum class approch.

I am a bit confused, the code shows changing the enums to `enum class`, instead of renaming their value as shown in the description of the PR and in the changelog. Which is the proposed change? If I remember correctly, #556 is the precessor of this and was going for the `enum class` approch.

muellerr added 1 commit 2022-03-08 08:57:59 +01:00